svn commit: r438159 - /ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/ManifestClassPath.java

Author: mbenson
Date: Tue Aug 29 11:51:27 2006
New Revision: 438159

URL: 
http://svn.apache.org/viewvc?rev=438159&view=rev
Log:
compromise with DD

Modified:
   
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Manife
stClassPath.java

Modified:
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Manife
stClassPath.java
URL: http://svn.apa
che.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/
taskdefs/ManifestClassPath.java?rev=438159&r1=438158&
;r2=438159&view=diff
============================================================
==================
---
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Manife
stClassPath.java (original)
+++
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Manife
stClassPath.java Tue Aug 29 11:51:27 2006
 -86,9
+86,6 
         StringBuffer buffer = new StringBuffer();
         StringBuffer element = new StringBuffer();
         for (int i = 0; i < elements.length; ++i) {
-            if (i > 0) {
-                buffer.append(' ');
-            }
             // Normalize the current file
             File pathEntry = new File(elements[i]);
             pathEntry =
fileUtils.normalize(pathEntry.getAbsolutePath());
 -136,10
+133,11 
                 throw new BuildException(exc);
             }
             buffer.append(relPath);
+            buffer.append(' ');
         }
 
         // Finally assign the property with the manifest
classpath
-        getProject().setNewProperty(_name,
buffer.toString());
+        getProject().setNewProperty(_name,
buffer.toString().trim());
     }
 
     /**



------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribeant.apache.org
For additional commands, e-mail: dev-helpant.apache.org

How about this, DD?

-Matt

--- mbensonapache.org wrote:

> Author: mbenson
> Date: Tue Aug 29 11:51:27 2006
> New Revision: 438159
> 
> URL:
> 
http://svn.apache.org/viewvc?rev=438159&view=rev
> Log:
> compromise with DD
> 
> Modified:
>    
>
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Manife
stClassPath.java
> 
> Modified:
>
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Manife
stClassPath.java
> URL:
>
http://svn.apa
che.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/
taskdefs/ManifestClassPath.java?rev=438159&r1=438158&
;r2=438159&view=diff
>
============================================================
==================
> ---
>
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Manife
stClassPath.java
> (original)
> +++
>
ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Manife
stClassPath.java
> Tue Aug 29 11:51:27 2006
>  -86,9 +86,6 
>          StringBuffer buffer = new StringBuffer();
>          StringBuffer element = new StringBuffer();
>          for (int i = 0; i < elements.length; ++i) {
> -            if (i > 0) {
> -                buffer.append(' ');
> -            }
>              // Normalize the current file
>              File pathEntry = new File(elements[i]);
>              pathEntry =
> fileUtils.normalize(pathEntry.getAbsolutePath());
>  -136,10 +133,11 
>                  throw new BuildException(exc);
>              }
>              buffer.append(relPath);
> +            buffer.append(' ');
>          }
>  
>          // Finally assign the property with the
> manifest classpath
> -        getProject().setNewProperty(_name,
> buffer.toString());
> +        getProject().setNewProperty(_name,
> buffer.toString().trim());
>      }
>  
>      /**
> 
> 
> 
>
------------------------------------------------------------
---------
> To unsubscribe, e-mail:
> dev-unsubscribeant.apache.org
> For additional commands, e-mail:
> dev-helpant.apache.org
> 
> 


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection
around 
http://mail.yahoo.com 

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribeant.apache.org
For additional commands, e-mail: dev-helpant.apache.org

On 8/29/06, Matt Benson <gudnabrsamyahoo.com> wrote:
> How about this, DD?

You didn't need to change it back Matt. I was simply
expressing my
opinion on the matter, and it's a style issue really. The
latest
version is less code and it's clean, but unlike the
setLength call on
StringBuffer, it's not an in-place op and creates an extra
String. But
enough about this  --DD

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribeant.apache.org
For additional commands, e-mail: dev-helpant.apache.org