svn commit: r438953 - /ant/core/trunk/src/main/org/apache/tools/ant/Project.java

Author: mbenson
Date: Thu Aug 31 08:37:27 2006
New Revision: 438953

URL: 
http://svn.apache.org/viewvc?rev=438953&view=rev
Log:
Strike lying comment.

Modified:
   
ant/core/trunk/src/main/org/apache/tools/ant/Project.java

Modified:
ant/core/trunk/src/main/org/apache/tools/ant/Project.java
URL: http://svn.apache.org/viewvc/ant/
core/trunk/src/main/org/apache/tools/ant/Project.java?rev=43
8953&r1=438952&r2=438953&view=diff
============================================================
==================
---
ant/core/trunk/src/main/org/apache/tools/ant/Project.java
(original)
+++
ant/core/trunk/src/main/org/apache/tools/ant/Project.java
Thu Aug 31 08:37:27 2006
 -1,5
+1,5 
 /*
- * Copyright  2000-2006 The Apache Software Foundation
+ * Copyright 2000-2006 The Apache Software Foundation
  *
  *  Licensed under the Apache License, Version 2.0 (the
"License");
  *  you may not use this file except in compliance with the
License.
 -1804,7
+1804,7 
      * Add a reference to the project.
      *
      * param referenceName The name of the reference. Must
not be <code>null</code>.
-     * param value The value of the reference. Must not be
<code>null</code>.
+     * param value The value of the reference.
      */
     public void addReference(String referenceName, Object
value) {
         synchronized (references) {



------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribeant.apache.org
For additional commands, e-mail: dev-helpant.apache.org

On 8/31/06, mbensonapache.org <mbensonapache.org> wrote:
> Strike lying comment.
> -     * param value The value of the reference.
Must not be <code>null</code>.
> +     * param value The value of the reference.

How about enforcing the comment in fact? Binding null values
to refs
is bad, and will only show up later in the build, making it
difficult
to troubleshoot, no?

So why not throw an NPE or IllegalArgEx for null values?
--DD

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribeant.apache.org
For additional commands, e-mail: dev-helpant.apache.org

--- Dominique Devienne <ddeviennegmail.com> wrote:

> On 8/31/06, mbensonapache.org <mbensonapache.org>
> wrote:
> > Strike lying comment.
> > -     * param value The value of the reference.
> Must not be <code>null</code>.
> > +     * param value The value of the reference.
> 
> How about enforcing the comment in fact? Binding
> null values to refs
> is bad, and will only show up later in the build,
> making it difficult
> to troubleshoot, no?
> 
> So why not throw an NPE or IllegalArgEx for null
> values? --DD

No preference here.    But you
make sense.

-Matt

> 
>
------------------------------------------------------------
---------
> To unsubscribe, e-mail:
> dev-unsubscribeant.apache.org
> For additional commands, e-mail:
> dev-helpant.apache.org
> 
> 


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection
around 
http://mail.yahoo.com 

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribeant.apache.org
For additional commands, e-mail: dev-helpant.apache.org