DO NOT REPLY New: - NullPointException in FilterMapper

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43
292>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43292

           Summary: NullPointException in FilterMapper
           Product: Ant
           Version: 1.7.0
          Platform: Other
        OS/Version: Windows XP
            Status: NEW
          Severity: major
          Priority: P2
         Component: Core tasks
        AssignedTo: devant.apache.org
        ReportedBy: gekisyandex.ru


No check for null:

    public String[] mapFileName(String sourceFileName) {

            String result =
FileUtils.readFully(helper.getAssembledReader());
!!!         if (result.length() == 0) {
                return null;

change to:
            if (result==null || result.length() == 0) {


java.lang.NullPointerException
	at
org.apache.tools.ant.types.mappers.FilterMapper.mapFileName(
FilterMapper.java:74)
	at
org.apache.tools.ant.util.CompositeMapper.mapFileName(Compos
iteMapper.java:38)
	at gekis.ant.taskdefs.Append.buildMap(Append.java:691)
	at gekis.ant.taskdefs.Append.scan(Append.java:630)
	at gekis.ant.taskdefs.Append.execute(Append.java:513)
	at
org.apache.tools.ant.UnknownElement.execute(UnknownElement.j
ava:288)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
	at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAcce
ssorImpl.java:39)
	at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMe
thodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:585)
	at
org.apache.tools.ant.dispatch.DispatchUtils.execute(Dispatch
Utils.java:105)
	at org.apache.tools.ant.Task.perform(Task.java:348)
	at org.apache.tools.ant.Target.execute(Target.java:357)
	at
org.apache.tools.ant.Target.performTasks(Target.java:385)
	at
org.apache.tools.ant.Project.executeSortedTargets(Project.ja
va:1329)
	at
org.apache.tools.ant.helper.SingleCheckExecutor.executeTarge
ts(SingleCheckExecutor.java:38)
	at
org.apache.tools.ant.Project.executeTargets(Project.java:118
1)
	at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:416)
	at
gekis.ant.process.StepsProcessor.execute(StepsProcessor.java
:136)
	at
org.apache.tools.ant.UnknownElement.execute(UnknownElement.j
ava:288)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
	at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAcce
ssorImpl.java:39)
	at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMe
thodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:585)
	at
org.apache.tools.ant.dispatch.DispatchUtils.execute(Dispatch
Utils.java:105)
	at org.apache.tools.ant.Task.perform(Task.java:348)
	at org.apache.tools.ant.Target.execute(Target.java:357)
	at
org.apache.tools.ant.Target.performTasks(Target.java:385)
	at
org.apache.tools.ant.Project.executeSortedTargets(Project.ja
va:1329)
	at
org.apache.tools.ant.Project.executeTarget(Project.java:1298
)
	at
org.apache.tools.ant.helper.DefaultExecutor.executeTargets(D
efaultExecutor.java:41)
	at
org.apache.tools.ant.Project.executeTargets(Project.java:118
1)
	at org.apache.tools.ant.Main.runBuild(Main.java:698)
	at org.apache.tools.ant.Main.startAnt(Main.java:199)
	at org.apache.tools.ant.Main.start(Main.java:161)
	at org.apache.tools.ant.Main.main(Main.java:250)

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=ema
il
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the
assignee.

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribeant.apache.org
For additional commands, e-mail: dev-helpant.apache.org

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43
292>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43292





------- Additional Comments From peterreillyapache.org  2007-09-03 03:45 -------
Yes, FileUtils.readFully() can return null for empty
files.
I would rather change FileUtils.readFully() rather
that have all the clients do the null check stepdance.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=ema
il
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the
assignee.

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribeant.apache.org
For additional commands, e-mail: dev-helpant.apache.org

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43
292>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43292


peterreillyapache.org changed:

           What    |Removed                     |Added
------------------------------------------------------------
----------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |1.7.1




------- Additional Comments From peterreillyapache.org  2007-09-03 05:59 -------
Thanks for the report, I fixed FileUtils.readFully
to do the right thing.
Will be in the next ant release.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=ema
il
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the
assignee.

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribeant.apache.org
For additional commands, e-mail: dev-helpant.apache.org