List Info

Thread: Broken APXS




Broken APXS
country flaguser name
Poland
2007-07-22 02:53:00
Greetings.

apxs accepts only *.c files as its input. For other
extensions it
doesn't invoke libtool in compile mode and several different
issues
leading to empty Apache module creation. The most probably
reason is
poor regex design.
We've been having a nice discussion on modules-dev about
fixing apxs and
finally I decided to write a note here.

Here's what we found we think is poor and needs a fix:

//---------------------------------------------------------
around line 350
>     foreach $f (args) {
>         if ($f =~ m|.c$|) {  <----------------
Here, bad
>         coder! BAD!
>             push(srcs, $f);
>         }
>         else {
>             push(objs, $f);
>         }
>     }
//---------------------------------------------------------

around line 400
> foreach $s (srcs) {
>	my $slo = $s;
>	$slo =~ s|.c$|.slo|;
>	my $lo = $s;
>	$lo =~ s|.c$|.lo|;
>	my $la = $s;
>	$la =~ s|.c$|.la|;
>	my $o = $s;
>	$o =~ s|.c$|.o|; 
//---------------------------------------------------------

Where could I find current apxs maintainter?

Kind regards.

[1]

about | contact  Other archives ( Real Estate discussion Medical topics )