Re: svn commit: r571203 - /httpd/httpd/branches/2.2.x/modules/proxy/ajp_header.c

On 8/30/07, martinapache.org <martinapache.org> wrote:
> Author: martin
> Date: Thu Aug 30 08:22:58 2007
> New Revision: 571203
>
> URL: 
http://svn.apache.org/viewvc?rev=571203&view=rev
> Log:
> Add missing end-of-string checks by using strcmp in
place of memcmp

memcmp() is not needed when you know the length of one of
the strings;
there's no missing check.  The style on the other hand is
subject to
debate.

Meanwhile there may be a bug fix buried in here -- using
case-insignificant comparison for a HTTP header field name.

On 8/30/07, Jeff Trawick <trawickgmail.com> wrote:
> On 8/30/07, martinapache.org <martinapache.org> wrote:
> > Author: martin
> > Date: Thu Aug 30 08:22:58 2007
> > New Revision: 571203
> >
> > URL: 
http://svn.apache.org/viewvc?rev=571203&view=rev
> > Log:
> > Add missing end-of-string checks by using strcmp
in place of memcmp
>
> memcmp() is not needed when you know the length of one
of the strings;
> there's no missing check.  The style on the other hand
is subject to
> debate.
>
> Meanwhile there may be a bug fix buried in here --
using
> case-insignificant comparison for a HTTP header field
name.

I guess it is shame on me for not reading prior devhttpd
posts to
understand the commit message.