List Info

Thread: Re: Win32 MPM patch




Re: Win32 MPM patch
country flaguser name
Croatia
2007-10-15 01:38:48
William A. Rowe, Jr. wrote:
> 
> I had refactored your patch on trunk so that we no
longer name the
> silly function wait_for_many_objects (since it
obviously didn't do
> that properly, at least not with any consideration of
fairness or
> parallel signals).  Roy's concerns should be
addressed.
>

+1 It works. Although not sure why you removed the extra
function,
but It's a creative freedom I suppose 

Regards,
Mladen

Re: Win32 MPM patch
country flaguser name
United States
2007-10-15 01:56:03
Mladen Turk wrote:
> William A. Rowe, Jr. wrote:
>>
>> I had refactored your patch on trunk so that we no
longer name the
>> silly function wait_for_many_objects (since it
obviously didn't do
>> that properly, at least not with any consideration
of fairness or
>> parallel signals).  Roy's concerns should be
addressed.
>>
> 
> +1 It works. Although not sure why you removed the
extra function,
> but It's a creative freedom I suppose 

Well, we could and should probably implement a true
mass-event handler
with multiple threads, but using it for this trivial
application
seemed like overkill 

Thanks for the review!

Bill

[1-2]

about | contact  Other archives ( Real Estate discussion Medical topics )