Andreas Hartmann wrote:
> Joern Nettingsmeier schrieb:
>> Andreas Hartmann wrote:
>>> Jörn Nettingsmeier schrieb:
>>>> hi *!
>>>>
>>>> i'm trying to update the Instantiator
class. i have it working, but
>>>> there are a number of hard-coded strings in
there i'd like to get rid
>>>> of. so i'd like to do:
>
> [...]
>
>> is this build problem i'm seeing part of the
"fundamental problem" you
>> describe?
>
> Yes, this is exactly the fundamental problem.
>
>> if so, can you give details?
>
> The location and content of the publication.xconf file
is private
> information of the PublicationConfiguration.
doh. of course, "private static final..."
/me hides under a stone.
> They are implementation
> details, therefore the PublicationConfiguration is not
part of the
> Lenya API. You can't compile anything which accesses
this class.
> This protects you from losing binary backwards
compatibility when the
> syntax of publication.xconf changes.
>
> If you want to configure a publication, this should be
done using the
> Lenya API. But ATM we don't provide these configuration
options
> (i.e., there are no corresponding setters in the
Publication interface).
>
> There are two options:
>
> 1) add these setters now and everything which that
implies
>
> 2) leave the duplicated strings in the Instantiator
until
> we have these setters
should these setters go into Publication or rather
PublicationConfiguration? anyways, looks like post-1.4
stuff.
for now, i wonder whether it would be the lesser evil to
make the string
constants in PublicationConfiguration public? like "if
you want to screw
around on my turf, at least have the manners to do it my
way...".
------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribe lenya.apache.org
For additional commands, e-mail: dev-help lenya.apache.org
|