Re: change of Publication interface?

Joern Nettingsmeier schrieb:
> hi everyone !
> 
> getting rid of the bogus multiple-inheritance has an
impact on the
> publication interface. (quote of the relevant
discussion below, for your
> reference)
> 
> basically, i see these options:
> 
> 1. leave public String[] getTemplateIds() as it is, and
return a
> one-element String[].

This would have the advantage that we can
"upgrade" to multiple
inheritance later on without changing the API. Does anyone
see
the necessity to use more than one template?

> 2. deprecate getTemplateIds() and make it return
getTemplateId() cast to
> String[], add public String getTemplateId()
> 
> 
> 3. rip out getTemplateIds() entirely, breaking
backwards compatibility,
> and introduce public String getTemplateId()

If nobody needs multiple inheritance, then +1 for (3).

-- Andreas

> 
> 
> i'm in favour of (3), because we never published an API
that contained
> getTemplateId(), and it fits well with my personal
NoCruft(tm) agenda.
> there's only a handful places in the code that need to
be updated.
> (1) is not an option to me, because it implies
functionality that we
> can't provide, and that's bad manners. if people are
willing to dig in
> and learn by reading code, we should not plant red
herrings to lead them
> astray...
> 
> 
> wdyt?
> 
> 
> regards,
> 
> jörn
> 
> 
> 
> Andreas Hartmann wrote:
>> Jörn Nettingsmeier schrieb:
>>> Andreas Hartmann wrote:
>>>> Jörn Nettingsmeier schrieb:
>>>>> hi everyone!
>>>>>
>>>>>
>>>>> i just found out about the method
>>>>> String[] getTemplateIds
>>>>> in
org.apache.lenya.cms.publication.Publication.
>>>>>
>>>>> does that mean we support or plan to
support multiple inheritance?
>>>> Actually it should work
>>>> (see
PublicationTemplateManagerImpl.getPublications(publication))
.
>>>>
>>>> But this is of course subject to
discussion.
>>>> Do you consider this concept valuable or
even necessary?
>>> warming up an old thread...
>>>
>>> andreas: is this mechanism tested and
functional? reason i'm asking is
>>> i'm hacking on the PublicationConfiguration
anyways, and if nobody
>>> really uses it, i could rip it out while i'm at
it.
>>
>> +1 to rip it out.
>>
>> Thanks for mentioning it again!
>>
>> -- Andreas
>>
>>
>>
------------------------------------------------------------
---------
>> To unsubscribe, e-mail: dev-unsubscribelenya.apache.org
>> For additional commands, e-mail: dev-helplenya.apache.org
>>
>>


------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribelenya.apache.org
For additional commands, e-mail: dev-helplenya.apache.org