Re: XSPectomy

Jörn Nettingsmeier schrieb:
> Andreas Hartmann wrote:
>> Andreas Hartmann schrieb:
>> I did some more tests - maybe I did missed
something before, but now I
>> get different results which resemble my
expectations.
>>
>> * same setup as above
>> * Lenya 2.0.2-dev without modifications
>> * Fallback source URI caching enabled
>>
>> a) standard publication.xml:                       
 avg. 1200 ms
>> b) publication.xml contains only modules with
menus: avg.  800 ms
>>
>> In case b), the aggregated menu XML is cached
because the include
>> transformer didn't come across any non-existing
sources and therefore
>> the validity could be computed.
>>
>> At the moment b) can't be enforced because the
publication.xml entries
>> are also used for i18n. But I'm confident that we
would find another way
>> to assemble the modules i18n catalogue.
>>
>> WDYT - can we require that publication.xml contains
only modules which
>> provide a menu, and throw an exception otherwise?
> 
> nah.

If the patch for htt
ps://issues.apache.org/jira/browse/COCOON-2166 
proves useful (or we find another solution), this will
fortunately not 
be necessary.

-- Andreas


-- 
Andreas Hartmann, CTO
BeCompany GmbH
http://www.becompany.ch
Tel.: +41 (0) 43 818 57 01


------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribelenya.apache.org
For additional commands, e-mail: dev-helplenya.apache.org

Andreas Hartmann wrote:
> Jörn Nettingsmeier schrieb:
>> 
>> nah.
> 
> If the patch for htt
ps://issues.apache.org/jira/browse/COCOON-2166 
> proves useful (or we find another solution), this will
fortunately
> not be necessary.

i just looked at the patch - if i understand it correctly,
it's really
slick!

i'm not sure i understand vadim's comment, though:

> Vadim Gritsenko - 07/Feb/08 07:28 PM You should
differentiate the
> case when source exists but not cacheable, and when
source does not
> exist. Otherwise you will be caching what must not be
cached.

isn't that what

   return (newValidity == null) ? SourceValidity.VALID
                                : SourceValidity.INVALID;

does?

-- 
Jörn Nettingsmeier

"One of my most productive days was throwing away 1000
lines of code."
  - Ken Thompson.

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribelenya.apache.org
For additional commands, e-mail: dev-helplenya.apache.org