Checkout Screens

Andreas Hartmann wrote:

> Michael Wechner wrote:
>
>> Hi
>>
>> I have noticed that within Lenya 1.4 the checkout
screens for BXE, 
>> Form(s) are not really helpful, because
>> they don't really tell you what's the problem,
whereas the Kupu 
>> screen is fine.
>
>
> The check happens in
AbstractUsecase.lockInvolvedObjects().
> The error handling could certainly be improved by
adding
> an error message for each source which is checked out:
>
> * foo_en.xml is checked out by user "john"
> * sitetree.xml is checked out by user
"alice"
> * ...
>
> And maybe add a link to the forceCheckIn-Usecase,
passing the
> source(s) as parameters.
>
>
>> What I don't understand is why each editor as
another screen anyway ....
>>
>> Any idea why this is the case?
>
>
> The screen belongs to the usecase, each usecase can
display it
> as it likes. The error message is generated by
AbstractUsecase.
> The BXE screen lacks the cancel button, this should be
easy to fix.


btw, if you click on the cancel button, you will receive an
ugly 
exception 

I think Kupu offers a very good screen, so I would suggest
to reuse the 
Kupu screen
for all other screens.

Michi

>
>
> -- Andreas
>
>
>


-- 
Michael Wechner
Wyona      -   Open Source Content Management   -    Apache
Lenya
http://www.wyona.com     
                http://lenya.apache.org
michael.wechnerwyona.com                        michiapache.org
+41 44 272 91 61


------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribelenya.apache.org
For additional commands, e-mail: dev-helplenya.apache.org

Michael Wechner wrote:

[...]

>>> What I don't understand is why each editor as
another screen anyway ....
>>>
>>> Any idea why this is the case?
>>
>>
>> The screen belongs to the usecase, each usecase can
display it
>> as it likes. The error message is generated by
AbstractUsecase.
>> The BXE screen lacks the cancel button, this should
be easy to fix.
> 
> 
> btw, if you click on the cancel button, you will
receive an ugly 
> exception 

Yes, I noticed that. Would you mind filing a bug?


> I think Kupu offers a very good screen, so I would
suggest to reuse the 
> Kupu screen
> for all other screens.

The problem is that the Kupu screen is not generic, because
it only
checks for the current document. It won't work for usecases
where
multiple sources are involved (e.g., moving a subtree).

I'd suggest to enhance the error handling in
AbstractUsecase.

-- Andreas



-- 
Andreas Hartmann
Wyona Inc.  -   Open Source Content Management   -   Apache
Lenya
http://www.wyona.com     
                http://lenya.apache.org
andreas.hartmannwyona.com                     andreasapache.org


------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribelenya.apache.org
For additional commands, e-mail: dev-helplenya.apache.org