svnversion in manifest Implementation-Version?

Any thoughts on adding the svn version info to the manifest

Implementation-Version?

currently, the ant task sets something that looks like:
Implementation-Version: 1.3-dev - ryan - 2007-06-03
12:49:52

It would be nice to have:
Implementation-Version: 1.3-dev 543971M - ryan - 2007-06-03
12:49:52

The one *major* problem with this is that MANIFEST.MF has a
max line 
length of 70...  if you have a login name longer then 7
(bdelacretaz) it 
wraps to the next line.  If we remove the time, then we are
fine also.
Implementation-Version: 1.3-dev 543971M - bdelacretaz-
2007-06-03

For me, the repos version is way more useful then the build
time, so I 
think its a good trade off.

This works for my local build.xml:

<exec dir="." executable="svnversion"
outputproperty="svnversion"
  failifexecutionfails="false">
   <arg line="."/>
</exec>
...
<attribute name="Implementation-Version"
            value="$ $ -
${user.name} - $"/>


thoughts?
ryan

: Any thoughts on adding the svn version info to the
manifest
: Implementation-Version?

No objections from me.  I didn't do it back in the day out
of dislike for
the and <exec> task and fear that i would get it wrong
and make Solr
completely unbuildable from source relases (either becuase
there was no
.svn metadata or because the user didn't have svnversion in
their path)

: The one *major* problem with this is that MANIFEST.MF has
a max line
: length of 70...  if you have a login name longer then 7
(bdelacretaz) it
: wraps to the next line.  If we remove the time, then we
are fine also.

i'm confused, what's wrong with wrapping the line?

it's only the manifest header's that are confined to 70
bytes, the values
can happily be longer as long as they wrap with space
indenting -- tools
that extract the manifest info from the jar understand that.
 (set
"version" to something really supper crazy long
and check out registry.jsp
... the full details are all there.

: thoughts?

unless i'm missing something, let's put all the detail we
can in
(svnverison, user, date, time, the works)



-Hoss

Chris Hostetter wrote:
> : Any thoughts on adding the svn version info to the
manifest
> : Implementation-Version?
> 
> No objections from me.  I didn't do it back in the day
out of dislike for
> the and <exec> task and fear that i would get it
wrong and make Solr
> completely unbuildable from source relases (either
becuase there was no
> .svn metadata or because the user didn't have
svnversion in their path)
> 

This *should* only output an error, but continue
building....


> : The one *major* problem with this is that MANIFEST.MF
has a max line
> : length of 70...  if you have a login name longer then
7 (bdelacretaz) it
> : wraps to the next line.  If we remove the time, then
we are fine also.
> 
> i'm confused, what's wrong with wrapping the line?
> 

apparently nothing!  I saw the line wrapping and got
nervous.  I just 
tried one that wraps (even two lines) and works fine.


> it's only the manifest header's that are confined to 70
bytes, the values
> can happily be longer as long as they wrap with space
indenting -- tools
> that extract the manifest info from the jar understand
that.  (set
> "version" to something really supper crazy
long and check out registry.jsp
> ... the full details are all there.
> 
> : thoughts?
> 
> unless i'm missing something, let's put all the detail
we can in
> (svnverison, user, date, time, the works)
> 

great.  I will add this...