Created: (SOLR-301) Clean up param interface. Leave deprecated options in deprecated classes

Thread: Created: (SOLR-301) Clean up param interface. Leave deprecated options in deprecated classes

Search this list only Search all lists
Created: (SOLR-301) Clean up param interface. Leave deprecated options in deprecated classes
United States	2007-07-14 18:41:04
Clean up param interface. Leave deprecated options in deprecated classes ------------------------------------------------------------ ------------- Key: SOLR-301 URL: https: //issues.apache.org/jira/browse/SOLR-301 Project: Solr Issue Type: Improvement Reporter: Ryan McKinley Priority: Minor Fix For: 1.3 In SOLR-135, we moved the parameter handling stuff to a new package: o.a.s.common.params and left deprecated classes in the old location. Classes in the new package should not contain any deprecated options. Aditionally, we should aim to seperate parameter manipulation logic (DefaultSolrParams, AppendedSolrParams, etc) from 'parameter' interface classes: 'HighlightParams', 'UpdateParams' -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.

Updated: (SOLR-301) Clean up param interface. Leave deprecated options in deprecated classes
United States	2007-07-14 18:48:04
[ https://issues.apache.org/jira/browse/SOLR-301?page=com.atla ssian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan McKinley updated SOLR-301: ------------------------------- Attachment: SOLR-301-ParamCleanup.patch This patch makes all the 'interface' classes into interfaces and keeps the logic classes as classes The params from SolrParams are moved to CommonParams. deprecated DisMax logic is moved to the deprecated o.a.s.util.DisMaxParams class Facet parameters from SolrParams are moved to FacetParams.java core classes are all updated to use the clean classes I'll wait for SOLR-258 to be committed, then without objection add this. > Clean up param interface. Leave deprecated options in deprecated classes > ------------------------------------------------------------ ------------- > > Key: SOLR-301 > URL: https: //issues.apache.org/jira/browse/SOLR-301 > Project: Solr > Issue Type: Improvement > Reporter: Ryan McKinley > Priority: Minor > Fix For: 1.3 > > Attachments: SOLR-301-ParamCleanup.patch > > > In SOLR-135, we moved the parameter handling stuff to a new package: o.a.s.common.params and left deprecated classes in the old location. > Classes in the new package should not contain any deprecated options. > Aditionally, we should aim to seperate parameter manipulation logic (DefaultSolrParams, AppendedSolrParams, etc) from 'parameter' interface classes: 'HighlightParams', 'UpdateParams' -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.

Updated: (SOLR-301) Clean up param interface. Leave deprecated options in deprecated classes
United States	2007-07-30 20:08:52
[ https://issues.apache.org/jira/browse/SOLR-301?page=com.atla ssian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan McKinley updated SOLR-301: ------------------------------- Attachment: SOLR-301-ParamCleanup.patch moves SOLR-258 params into their own file. This touches a lot of files, but isolates (most) deprecated features to deprecated classes. > Clean up param interface. Leave deprecated options in deprecated classes > ------------------------------------------------------------ ------------- > > Key: SOLR-301 > URL: https: //issues.apache.org/jira/browse/SOLR-301 > Project: Solr > Issue Type: Improvement > Reporter: Ryan McKinley > Priority: Minor > Fix For: 1.3 > > Attachments: SOLR-301-ParamCleanup.patch, SOLR-301-ParamCleanup.patch > > > In SOLR-135, we moved the parameter handling stuff to a new package: o.a.s.common.params and left deprecated classes in the old location. > Classes in the new package should not contain any deprecated options. > Aditionally, we should aim to seperate parameter manipulation logic (DefaultSolrParams, AppendedSolrParams, etc) from 'parameter' interface classes: 'HighlightParams', 'UpdateParams' -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.

Assigned: (SOLR-301) Clean up param interface. Leave deprecated options in deprecated classe
United States	2007-07-31 16:27:53
[ https://issues.apache.org/jira/browse/SOLR-301?page=com.atla ssian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan McKinley reassigned SOLR-301: ---------------------------------- Assignee: Ryan McKinley I'd like to commit this soon > Clean up param interface. Leave deprecated options in deprecated classes > ------------------------------------------------------------ ------------- > > Key: SOLR-301 > URL: https: //issues.apache.org/jira/browse/SOLR-301 > Project: Solr > Issue Type: Improvement > Reporter: Ryan McKinley > Assignee: Ryan McKinley > Priority: Minor > Fix For: 1.3 > > Attachments: SOLR-301-ParamCleanup.patch, SOLR-301-ParamCleanup.patch > > > In SOLR-135, we moved the parameter handling stuff to a new package: o.a.s.common.params and left deprecated classes in the old location. > Classes in the new package should not contain any deprecated options. > Aditionally, we should aim to seperate parameter manipulation logic (DefaultSolrParams, AppendedSolrParams, etc) from 'parameter' interface classes: 'HighlightParams', 'UpdateParams' -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.

Commented: (SOLR-301) Clean up param interface. Leave deprecated options in deprecated class
United States	2007-07-31 19:39:53
[ https://issues.apache.org/jira/browse/SO LR-301?page=com.atlassian.jira.plugin.system.issuetabpanels: comment-tabpanel#action_12516839 ] Pieter Berkel commented on SOLR-301: ------------------------------------ While you're in the process of cleaning up the Params interfaces, I wonder if it worthwhile moving MoreLikeThisParams from o.a.s.common.util to o.a.s.common.params at the same time? I made a note of this in my comments on <a href="http://issues.apache.org/jira/browse/S OLR-295">SOLR-295</a>. > Clean up param interface. Leave deprecated options in deprecated classes > ------------------------------------------------------------ ------------- > > Key: SOLR-301 > URL: https: //issues.apache.org/jira/browse/SOLR-301 > Project: Solr > Issue Type: Improvement > Reporter: Ryan McKinley > Assignee: Ryan McKinley > Priority: Minor > Fix For: 1.3 > > Attachments: SOLR-301-ParamCleanup.patch, SOLR-301-ParamCleanup.patch > > > In SOLR-135, we moved the parameter handling stuff to a new package: o.a.s.common.params and left deprecated classes in the old location. > Classes in the new package should not contain any deprecated options. > Aditionally, we should aim to seperate parameter manipulation logic (DefaultSolrParams, AppendedSolrParams, etc) from 'parameter' interface classes: 'HighlightParams', 'UpdateParams' -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.

Issue Comment Edited: (SOLR-301) Clean up param interface. Leave deprecated options in deprec
United States	2007-07-31 19:39:53
[ https://issues.apache.org/jira/browse/SO LR-301?page=com.atlassian.jira.plugin.system.issuetabpanels: comment-tabpanel#action_12516839 ] Pieter Berkel edited comment on SOLR-301 at 7/31/07 5:39 PM: ------------------------------------------------------------ - While you're in the process of cleaning up the Params interfaces, I wonder if it worthwhile moving MoreLikeThisParams from o.a.s.common.util to o.a.s.common.params at the same time? I made a note of this in my comments on SOLR-295. was: While you're in the process of cleaning up the Params interfaces, I wonder if it worthwhile moving MoreLikeThisParams from o.a.s.common.util to o.a.s.common.params at the same time? I made a note of this in my comments on <a href="http://issues.apache.org/jira/browse/S OLR-295">SOLR-295</a>. > Clean up param interface. Leave deprecated options in deprecated classes > ------------------------------------------------------------ ------------- > > Key: SOLR-301 > URL: https: //issues.apache.org/jira/browse/SOLR-301 > Project: Solr > Issue Type: Improvement > Reporter: Ryan McKinley > Assignee: Ryan McKinley > Priority: Minor > Fix For: 1.3 > > Attachments: SOLR-301-ParamCleanup.patch, SOLR-301-ParamCleanup.patch > > > In SOLR-135, we moved the parameter handling stuff to a new package: o.a.s.common.params and left deprecated classes in the old location. > Classes in the new package should not contain any deprecated options. > Aditionally, we should aim to seperate parameter manipulation logic (DefaultSolrParams, AppendedSolrParams, etc) from 'parameter' interface classes: 'HighlightParams', 'UpdateParams' -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.

Resolved: (SOLR-301) Clean up param interface. Leave deprecated options in deprecated classe
United States	2007-08-01 13:53:53
[ https://issues.apache.org/jira/browse/SOLR-301?page=com.atla ssian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan McKinley resolved SOLR-301. -------------------------------- Resolution: Fixed committed along with moving MoreLikeThisParams to o.a.s.common.params > Clean up param interface. Leave deprecated options in deprecated classes > ------------------------------------------------------------ ------------- > > Key: SOLR-301 > URL: https: //issues.apache.org/jira/browse/SOLR-301 > Project: Solr > Issue Type: Improvement > Reporter: Ryan McKinley > Assignee: Ryan McKinley > Priority: Minor > Fix For: 1.3 > > Attachments: SOLR-301-ParamCleanup.patch, SOLR-301-ParamCleanup.patch > > > In SOLR-135, we moved the parameter handling stuff to a new package: o.a.s.common.params and left deprecated classes in the old location. > Classes in the new package should not contain any deprecated options. > Aditionally, we should aim to seperate parameter manipulation logic (DefaultSolrParams, AppendedSolrParams, etc) from 'parameter' interface classes: 'HighlightParams', 'UpdateParams' -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.

[1-7]

about | contact Other archives ( Real Estate discussion Medical topics )