Created: (SOLR-307) NGramFilterFactory and EdgeNGramFilterFactory

NGramFilterFactory and EdgeNGramFilterFactory
---------------------------------------------

                 Key: SOLR-307
                 URL: https:
//issues.apache.org/jira/browse/SOLR-307
             Project: Solr
          Issue Type: New Feature
          Components: search
            Reporter: Thomas Peuss
            Priority: Minor
         Attachments: SolrNGramFilters.patch

Here is a patch that adds an NGramFilterFactory and
EdgeNGramFilterFactory to Solr.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.

     [ 
https://issues.apache.org/jira/browse/SOLR-307?page=com.atla
ssian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Peuss updated SOLR-307:
------------------------------

    Attachment: SolrNGramFilters.patch

The patch against trunk.

> NGramFilterFactory and EdgeNGramFilterFactory
> ---------------------------------------------
>
>                 Key: SOLR-307
>                 URL: https:
//issues.apache.org/jira/browse/SOLR-307
>             Project: Solr
>          Issue Type: New Feature
>          Components: search
>            Reporter: Thomas Peuss
>            Priority: Minor
>         Attachments: SolrNGramFilters.patch
>
>
> Here is a patch that adds an NGramFilterFactory and
EdgeNGramFilterFactory to Solr.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.

    [ https://issues.apache.org/jira/browse/SO
LR-307?page=com.atlassian.jira.plugin.system.issuetabpanels:
comment-tabpanel#action_12513581 ] 

Otis Gospodnetic commented on SOLR-307:
---------------------------------------

Maybe it's just me and my Eclipse, but I had to remove Override
from the two create method before thing would compile. 
Yeah, must be my Eclipse settings, this compiled with ant
compile.  I'll commit in a bit, I just reformatted the code
to fit https:
//issues.apache.org/jira/browse/SOLR-245 and removed
some tabs.



> NGramFilterFactory and EdgeNGramFilterFactory
> ---------------------------------------------
>
>                 Key: SOLR-307
>                 URL: https:
//issues.apache.org/jira/browse/SOLR-307
>             Project: Solr
>          Issue Type: New Feature
>          Components: search
>            Reporter: Thomas Peuss
>            Priority: Minor
>         Attachments: SolrNGramFilters.patch
>
>
> Here is a patch that adds an NGramFilterFactory and
EdgeNGramFilterFactory to Solr.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.

    [ https://issues.apache.org/jira/browse/SO
LR-307?page=com.atlassian.jira.plugin.system.issuetabpanels:
comment-tabpanel#action_12513583 ] 

Otis Gospodnetic commented on SOLR-307:
---------------------------------------

Eh, that abstract BaseTokenFilterFactory implements
TokenFilterFactory interface, but does not implement (and
keep abstract) its create(TokenStream) method, that must be
why Eclipse is complaining.  Should we add an abstract
create(TokenStream) to BTFF class?


> NGramFilterFactory and EdgeNGramFilterFactory
> ---------------------------------------------
>
>                 Key: SOLR-307
>                 URL: https:
//issues.apache.org/jira/browse/SOLR-307
>             Project: Solr
>          Issue Type: New Feature
>          Components: search
>            Reporter: Thomas Peuss
>            Priority: Minor
>         Attachments: SolrNGramFilters.patch
>
>
> Here is a patch that adds an NGramFilterFactory and
EdgeNGramFilterFactory to Solr.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.

    [ https://issues.apache.org/jira/browse/SO
LR-307?page=com.atlassian.jira.plugin.system.issuetabpanels:
comment-tabpanel#action_12513618 ] 

Yonik Seeley commented on SOLR-307:
-----------------------------------

Just remove Override (since there isn't an implementation it's
overriding, eclipse was correct to complain I guess).

> NGramFilterFactory and EdgeNGramFilterFactory
> ---------------------------------------------
>
>                 Key: SOLR-307
>                 URL: https:
//issues.apache.org/jira/browse/SOLR-307
>             Project: Solr
>          Issue Type: New Feature
>          Components: search
>            Reporter: Thomas Peuss
>            Priority: Minor
>         Attachments: SolrNGramFilters.patch
>
>
> Here is a patch that adds an NGramFilterFactory and
EdgeNGramFilterFactory to Solr.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.

    [ https://issues.apache.org/jira/browse/SO
LR-307?page=com.atlassian.jira.plugin.system.issuetabpanels:
comment-tabpanel#action_12513815 ] 

Thomas Peuss commented on SOLR-307:
-----------------------------------

You are perfectly right. I am wondering why my Eclipse was
not complaining.

> NGramFilterFactory and EdgeNGramFilterFactory
> ---------------------------------------------
>
>                 Key: SOLR-307
>                 URL: https:
//issues.apache.org/jira/browse/SOLR-307
>             Project: Solr
>          Issue Type: New Feature
>          Components: search
>            Reporter: Thomas Peuss
>            Priority: Minor
>         Attachments: SolrNGramFilters.patch
>
>
> Here is a patch that adds an NGramFilterFactory and
EdgeNGramFilterFactory to Solr.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.

     [ 
https://issues.apache.org/jira/browse/SOLR-307?page=com.atla
ssian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Otis Gospodnetic resolved SOLR-307.
-----------------------------------

    Resolution: Fixed

Thanks Thomas, this is committed.


> NGramFilterFactory and EdgeNGramFilterFactory
> ---------------------------------------------
>
>                 Key: SOLR-307
>                 URL: https:
//issues.apache.org/jira/browse/SOLR-307
>             Project: Solr
>          Issue Type: New Feature
>          Components: search
>            Reporter: Thomas Peuss
>            Priority: Minor
>         Attachments: SolrNGramFilters.patch
>
>
> Here is a patch that adds an NGramFilterFactory and
EdgeNGramFilterFactory to Solr.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.