[ https://issues.apache.org/jira/browse/SO
LR-139?page=com.atlassian.jira.plugin.system.issuetabpanels:
comment-tabpanel#action_12514099 ]
Mike Klaas commented on SOLR-139:
---------------------------------
It is my fault that the DUH2 locking is so hairy to begin
with, so I should at least review changes to it ;)
With your last change, the locking looks sound. However, I
noticed a few things:
This comment is now inaccurate:
+ // need to start off with the write lock because we
can't aquire
+ // the write lock if we need to.
Should openSearcher() call closeSearcher() instead of doing
it manually? It looks like searcherHasChanges is not being
reset to false.
> Support updateable/modifiable documents
> ---------------------------------------
>
> Key: SOLR-139
> URL: https:
//issues.apache.org/jira/browse/SOLR-139
> Project: Solr
> Issue Type: Improvement
> Components: update
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Attachments: getStoredFields.patch,
getStoredFields.patch, getStoredFields.patch,
SOLR-139-IndexDocumentCommand.patch,
SOLR-139-IndexDocumentCommand.patch,
SOLR-139-IndexDocumentCommand.patch,
SOLR-139-IndexDocumentCommand.patch,
SOLR-139-IndexDocumentCommand.patch,
SOLR-139-IndexDocumentCommand.patch,
SOLR-139-IndexDocumentCommand.patch,
SOLR-139-IndexDocumentCommand.patch,
SOLR-139-IndexDocumentCommand.patch,
SOLR-139-IndexDocumentCommand.patch,
SOLR-139-IndexDocumentCommand.patch,
SOLR-139-ModifyInputDocuments.patch,
SOLR-139-ModifyInputDocuments.patch,
SOLR-139-XmlUpdater.patch,
SOLR-269+139-ModifiableDocumentUpdateProcessor.patch
>
>
> It would be nice to be able to update some fields on a
document without having to insert the entire document.
> Given the way lucene is structured, (for now) one can
only modify stored fields.
> While we are at it, we can support incrementing an
existing value - I think this only makes sense for numbers.
> for background, see:
> http://www.nabble.com/loading-many-doc
uments-by-ID-tf3145666.html#a8722293
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.
|
