Created: (MWAR-114) Different builds for ejb-client optional with parent

Different builds for ejb-client optional with parent
----------------------------------------------------

                 Key: MWAR-114
                 URL: http://jira.
codehaus.org/browse/MWAR-114
             Project: Maven 2.x War Plugin
          Issue Type: Bug
    Affects Versions: 2.1
            Reporter: Tim Reilly
         Attachments: mytime.zip

When trying to package a  j2ee project's ejb-client artifact
in the ear /lib directory the war plugin's optional
attribute is ignored if building from the parent app
project. If you build from the parent project you get the
ejb-client packaged in the web-inf/lib directory. If you
build the ejb, war, and ear independently you get the
ejb-client packaged in the ear /lib directory. It seems when
run from the parent project the dependency/artifact doesn't
have the optional attribute set.

Perhaps this is b/c the artifact is a project artifact that
was attached from the ejb plugin it is not resolved as
optional when the dependency is resolved from the war
project.


Attaching Geronimo's mytime sample with modifications to
reproduce the behavior.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the
administrators: h
ttp://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atl
assian.com/software/jira

        

    [ http://jira.codehaus.org/browse/MWAR-114?page=co
m.atlassian.jira.plugin.system.issuetabpanels:comment-tabpan
el#action_108416 ] 

Tim Reilly commented on MWAR-114:
---------------------------------

I think the underlying issue is a possible false assumption.

The WAR plugin assumes  that all of it's dependencies will
be resolved to artifacts from _it's_ pom. But in a
multimodule build, some artifact's such as an attached an
attached ejb-client artifact are not resolved from the war's
dependency list. It's already attached to the project. Due
to this declaring the ejb-client as optional has no effect.

I will attach the patch we are using as a candidate patch.
The patch iterates the dependency list to develop an
optional artifacts sub-list. It then iterates the optional
artifacts list and ensures the resolved artifacts reflect
the optional attribute.

> Different builds for ejb-client optional with parent
> ----------------------------------------------------
>
>                 Key: MWAR-114
>                 URL: http://jira.
codehaus.org/browse/MWAR-114
>             Project: Maven 2.x War Plugin
>          Issue Type: Bug
>    Affects Versions: 2.1
>            Reporter: Tim Reilly
>         Attachments: mytime.zip
>
>
> When trying to package a  j2ee project's ejb-client
artifact in the ear /lib directory the war plugin's optional
attribute is ignored if building from the parent app
project. If you build from the parent project you get the
ejb-client packaged in the web-inf/lib directory. If you
build the ejb, war, and ear independently you get the
ejb-client packaged in the ear /lib directory. It seems when
run from the parent project the dependency/artifact doesn't
have the optional attribute set.
> Perhaps this is b/c the artifact is a project artifact
that was attached from the ejb plugin it is not resolved as
optional when the dependency is resolved from the war
project.
> Attaching Geronimo's mytime sample with modifications
to reproduce the behavior.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the
administrators: h
ttp://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atl
assian.com/software/jira

        

     [ http:/
/jira.codehaus.org/browse/MWAR-114?page=com.atlassian.jira.p
lugin.system.issuetabpanels:all-tabpanel ]

Tim Reilly updated MWAR-114:
----------------------------

    Attachment: MWAR114-maven-war-plugin-2.0.2.patch

Patch provides solution for version 2.0.2 of plugin. 


> Different builds for ejb-client optional with parent
> ----------------------------------------------------
>
>                 Key: MWAR-114
>                 URL: http://jira.
codehaus.org/browse/MWAR-114
>             Project: Maven 2.x War Plugin
>          Issue Type: Bug
>    Affects Versions: 2.1
>            Reporter: Tim Reilly
>         Attachments:
MWAR114-maven-war-plugin-2.0.2.patch, mytime.zip
>
>
> When trying to package a  j2ee project's ejb-client
artifact in the ear /lib directory the war plugin's optional
attribute is ignored if building from the parent app
project. If you build from the parent project you get the
ejb-client packaged in the web-inf/lib directory. If you
build the ejb, war, and ear independently you get the
ejb-client packaged in the ear /lib directory. It seems when
run from the parent project the dependency/artifact doesn't
have the optional attribute set.
> Perhaps this is b/c the artifact is a project artifact
that was attached from the ejb plugin it is not resolved as
optional when the dependency is resolved from the war
project.
> Attaching Geronimo's mytime sample with modifications
to reproduce the behavior.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the
administrators: h
ttp://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atl
assian.com/software/jira

        

     [ http:/
/jira.codehaus.org/browse/MWAR-114?page=com.atlassian.jira.p
lugin.system.issuetabpanels:all-tabpanel ]

Tim Reilly updated MWAR-114:
----------------------------

    Attachment: MWAR114-maven-war-plugin-2.0.2.patch

Fixed the the relative path in the previous patch file

-  Index:
maven-war-plugin-2.0.2/src/main/java/org/apache/maven/plugin
/war/AbstractWarMojo.java
+ Index:
src/main/java/org/apache/maven/plugin/war/AbstractWarMojo.ja
va                


> Different builds for ejb-client optional with parent
> ----------------------------------------------------
>
>                 Key: MWAR-114
>                 URL: http://jira.
codehaus.org/browse/MWAR-114
>             Project: Maven 2.x War Plugin
>          Issue Type: Bug
>    Affects Versions: 2.1
>            Reporter: Tim Reilly
>         Attachments:
MWAR114-maven-war-plugin-2.0.2.patch,
MWAR114-maven-war-plugin-2.0.2.patch, mytime.zip
>
>
> When trying to package a  j2ee project's ejb-client
artifact in the ear /lib directory the war plugin's optional
attribute is ignored if building from the parent app
project. If you build from the parent project you get the
ejb-client packaged in the web-inf/lib directory. If you
build the ejb, war, and ear independently you get the
ejb-client packaged in the ear /lib directory. It seems when
run from the parent project the dependency/artifact doesn't
have the optional attribute set.
> Perhaps this is b/c the artifact is a project artifact
that was attached from the ejb plugin it is not resolved as
optional when the dependency is resolved from the war
project.
> Attaching Geronimo's mytime sample with modifications
to reproduce the behavior.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the
administrators: h
ttp://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atl
assian.com/software/jira

        

     [ http:/
/jira.codehaus.org/browse/MWAR-114?page=com.atlassian.jira.p
lugin.system.issuetabpanels:all-tabpanel ]

Tim Reilly updated MWAR-114:
----------------------------

    Attachment: MWAR114-maven-war-plugin-2.1-alpha-1.patch

Candidate patch for 2.1-alpha-1

> Different builds for ejb-client optional with parent
> ----------------------------------------------------
>
>                 Key: MWAR-114
>                 URL: http://jira.
codehaus.org/browse/MWAR-114
>             Project: Maven 2.x War Plugin
>          Issue Type: Bug
>    Affects Versions: 2.1
>            Reporter: Tim Reilly
>         Attachments:
MWAR114-maven-war-plugin-2.0.2.patch,
MWAR114-maven-war-plugin-2.0.2.patch,
MWAR114-maven-war-plugin-2.1-alpha-1.patch, mytime.zip
>
>
> When trying to package a  j2ee project's ejb-client
artifact in the ear /lib directory the war plugin's optional
attribute is ignored if building from the parent app
project. If you build from the parent project you get the
ejb-client packaged in the web-inf/lib directory. If you
build the ejb, war, and ear independently you get the
ejb-client packaged in the ear /lib directory. It seems when
run from the parent project the dependency/artifact doesn't
have the optional attribute set.
> Perhaps this is b/c the artifact is a project artifact
that was attached from the ejb plugin it is not resolved as
optional when the dependency is resolved from the war
project.
> Attaching Geronimo's mytime sample with modifications
to reproduce the behavior.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the
administrators: h
ttp://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atl
assian.com/software/jira

        

    [ http://jira.codehaus.org/browse/MWAR-114?page=co
m.atlassian.jira.plugin.system.issuetabpanels:comment-tabpan
el#action_110668 ] 

Tim Reilly commented on MWAR-114:
---------------------------------

Test Steps:

1) Extract mytime.zip

2) set JAVA_HOME to jdk 1.5 or higher (the test project uses
ejb annotations)

3) cd into mytime-ejb directory and execute mvn clean
install. Build should be successful.
mytime-ejb-2.0-SNAPSHOT.jar and
mytime-ejb-2.0-SNAPSHOT-client.jar are installed to local
repo.

4) Next, cd to the mytime-war project and run mvn clean
install. Build should be successful.
mytime-war-2.0-SNAPSHOT.war is installed to local repo.

5) Next, cd to mytime-ear project and run mvn clean install.
Build should be successful and mytime-ear-2.0-SNAPSHOT.ear
is installed to local repo.

6) Validate the following regarding the generated artifacts.
Validation point: mytime-war does not contain a WEB-INF/lib
directory and does not contain the mytime-ejb-client. This
is the correct behavior. Validation point PASSES

7) Next, cd to the mytime project (the parent and aggregator
of the other projects) Run mvn clean install. Note
successful builds from each project.

8)  Validate the following regarding the generated
artifacts. Validation point: mytime-war does not contain a
WEB-INF/lib directory and does not contain the
mytime-ejb-client. This is the correct behavior. Validation
point FAILS

> Different builds for ejb-client optional with parent
> ----------------------------------------------------
>
>                 Key: MWAR-114
>                 URL: http://jira.
codehaus.org/browse/MWAR-114
>             Project: Maven 2.x War Plugin
>          Issue Type: Bug
>    Affects Versions: 2.1
>            Reporter: Tim Reilly
>         Attachments:
MWAR114-maven-war-plugin-2.0.2.patch,
MWAR114-maven-war-plugin-2.0.2.patch,
MWAR114-maven-war-plugin-2.1-alpha-1.patch, mytime.zip
>
>
> When trying to package a  j2ee project's ejb-client
artifact in the ear /lib directory the war plugin's optional
attribute is ignored if building from the parent app
project. If you build from the parent project you get the
ejb-client packaged in the web-inf/lib directory. If you
build the ejb, war, and ear independently you get the
ejb-client packaged in the ear /lib directory. It seems when
run from the parent project the dependency/artifact doesn't
have the optional attribute set.
> Perhaps this is b/c the artifact is a project artifact
that was attached from the ejb plugin it is not resolved as
optional when the dependency is resolved from the war
project.
> Attaching Geronimo's mytime sample with modifications
to reproduce the behavior.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the
administrators: h
ttp://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atl
assian.com/software/jira

        

    [ http://jira.codehaus.org/browse/MNG-3269?page=co
m.atlassian.jira.plugin.system.issuetabpanels:comment-tabpan
el#action_112979 ] 

Tim Reilly commented on MNG-3269:
---------------------------------

I wanted to check with the team I work with about this. They
basically said they are not against this, but they would
like to know more about how this change would be implemented
before 'giving a thumbs up' at least for our team here.

On a different but potentially related noete: I can say that
we ran into a seemly unresolvable issue a few months ago. We
build (or at least tried to build) a properties file into
the ear's "resource" directory. In the Ant world
this worked fine for them, but when we moved to Maven we
could not figure out how to get the property file in the ear
referenced in the war's manifest class-path (and still use
the add classpath feature of the mwar plugin.)

Let us know what the change might look like and I'll run it
by the various team members here to see what they think.

Thank you

> Different builds for ejb-client optional with parent
> ----------------------------------------------------
>
>                 Key: MNG-3269
>                 URL: http://jira.
codehaus.org/browse/MNG-3269
>             Project: Maven 2
>          Issue Type: Bug
>    Affects Versions: 2.0.7
>            Reporter: Tim Reilly
>         Attachments:
MWAR114-maven-war-plugin-2.0.2.patch,
MWAR114-maven-war-plugin-2.0.2.patch,
MWAR114-maven-war-plugin-2.1-alpha-1.patch, mytime.zip
>
>
> When trying to package a  j2ee project's ejb-client
artifact in the ear /lib directory the war plugin's optional
attribute is ignored if building from the parent app
project. If you build from the parent project you get the
ejb-client packaged in the web-inf/lib directory. If you
build the ejb, war, and ear independently you get the
ejb-client packaged in the ear /lib directory. It seems when
run from the parent project the dependency/artifact doesn't
have the optional attribute set.
> Perhaps this is b/c the artifact is a project artifact
that was attached from the ejb plugin it is not resolved as
optional when the dependency is resolved from the war
project.
> Attaching Geronimo's mytime sample with modifications
to reproduce the behavior.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the
administrators: h
ttp://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atl
assian.com/software/jira