List Info

Thread: Small change to build.xml




Small change to build.xml
user name
2007-01-05 14:57:32
Hi,

would it make sense to define the tasks to start/stop Derby
in the 
targets "start-db"/"stop-db", where they
are actually used instead of in 
"build-tests"? This way, you can run the tests w/o
running 
"build-tests", once the tests are build, and the
environment doesn't 
change. The new build.xml and diff are attached.

Thanks!

-- markus.

bash-3.00$ cat build.xml.diff
Index: build.xml
============================================================
=======
--- build.xml   (Revision 493039)
+++ build.xml   (Arbeitskopie)
 -891,12
+891,6 
             excludes="**/*.java, **/*.html,
**/*.png" />
     </copy>

-    <!-- register Ant tasks that were just built -->
-    <taskdef name="startdb" 
classname="org.apache.roller.ant.StartDerbyTask"
-        
classpath="${ro.tools}/buildtime/derby.jar;${ro.tools}/
buildtime/derbynet.jar;${build.compile.tests}" 
/>
-    <taskdef name="stopdb"
classname="org.apache.roller.ant.StopDerbyTask"
-        
classpath="${ro.tools}/buildtime/derby.jar;${ro.tools}/
buildtime/derbynet.jar;${build.compile.tests}" 
/>
-
     <!--
     Copy web config files to ${build.tests} to make them
available for 
testing.
     This includes the WEB-INF directory, minus jsps
 -1176,6
+1170,8 
 </target>

 <target name="start-db"
description="Starts built-in database">
+    <taskdef name="startdb" 
classname="org.apache.roller.ant.StartDerbyTask"
+        
classpath="${ro.tools}/buildtime/derby.jar;${ro.tools}/
buildtime/derbynet.jar;${build.compile.tests}" 
/>
     <startdb
database="${build.tests}/derby-system/roller"
port="3219" />
     <!--
     <delete
dir="${build.tests}/derby-system/roller" />
 -1191,6
+1187,8 
 </target>

 <target name="stop-db" description="Drop
tables and stops the built-in 
database">
+    <taskdef name="stopdb"
classname="org.apache.roller.ant.StopDerbyTask"
+        
classpath="${ro.tools}/buildtime/derby.jar;${ro.tools}/
buildtime/derbynet.jar;${build.compile.tests}" 
/>
     <stopdb port="3219"/>
     <!--
     <delete
dir="${build.tests}/derby-system/roller" />

Small change to build.xml
user name
2007-01-06 14:25:35
On 1/5/07, Markus Fuchs <Markus.Fuchssun.com> wrote:
> would it make sense to define the tasks to start/stop
Derby in the
> targets "start-db"/"stop-db", where
they are actually used instead of in
> "build-tests"? This way, you can run the
tests w/o running
> "build-tests", once the tests are build, and
the environment doesn't
> change. The new build.xml and diff are attached.

Yes. That is what we do now in the current code-base (i.e.
the SVN trunk).

You must be working with a slightly older version of the
code.

- Dave


>
> Thanks!
>
> -- markus.
>
> bash-3.00$ cat build.xml.diff
> Index: build.xml
>
============================================================
=======
> --- build.xml   (Revision 493039)
> +++ build.xml   (Arbeitskopie)
>  -891,12 +891,6 
>              excludes="**/*.java, **/*.html,
**/*.png" />
>      </copy>
>
> -    <!-- register Ant tasks that were just built
-->
> -    <taskdef name="startdb"
>
classname="org.apache.roller.ant.StartDerbyTask"
> -
>
classpath="${ro.tools}/buildtime/derby.jar;${ro.tools}/
buildtime/derbynet.jar;${build.compile.tests}"
> />
> -    <taskdef name="stopdb"
classname="org.apache.roller.ant.StopDerbyTask"
> -
>
classpath="${ro.tools}/buildtime/derby.jar;${ro.tools}/
buildtime/derbynet.jar;${build.compile.tests}"
> />
> -
>      <!--
>      Copy web config files to ${build.tests} to make
them available for
> testing.
>      This includes the WEB-INF directory, minus jsps
>  -1176,6 +1170,8 
>  </target>
>
>  <target name="start-db"
description="Starts built-in database">
> +    <taskdef name="startdb"
>
classname="org.apache.roller.ant.StartDerbyTask"
> +
>
classpath="${ro.tools}/buildtime/derby.jar;${ro.tools}/
buildtime/derbynet.jar;${build.compile.tests}"
> />
>      <startdb
database="${build.tests}/derby-system/roller"
port="3219" />
>      <!--
>      <delete
dir="${build.tests}/derby-system/roller" />
>  -1191,6 +1187,8 
>  </target>
>
>  <target name="stop-db"
description="Drop tables and stops the built-in
> database">
> +    <taskdef name="stopdb"
classname="org.apache.roller.ant.StopDerbyTask"
> +
>
classpath="${ro.tools}/buildtime/derby.jar;${ro.tools}/
buildtime/derbynet.jar;${build.compile.tests}"
> />
>      <stopdb port="3219"/>
>      <!--
>      <delete
dir="${build.tests}/derby-system/roller" />
>
>
>
>
Small change to build.xml
user name
2007-01-06 23:10:29
Hi Markus,

Please disregard my previous email.
I just committed your suggested change.

Thanks,
- Dave


On 1/6/07, Dave <snoopdavegmail.com> wrote:
> On 1/5/07, Markus Fuchs <Markus.Fuchssun.com> wrote:
> > would it make sense to define the tasks to
start/stop Derby in the
> > targets "start-db"/"stop-db",
where they are actually used instead of in
> > "build-tests"? This way, you can run the
tests w/o running
> > "build-tests", once the tests are build,
and the environment doesn't
> > change. The new build.xml and diff are attached.
>
> Yes. That is what we do now in the current code-base
(i.e. the SVN trunk).
>
> You must be working with a slightly older version of
the code.
>
> - Dave
>
>
> >
> > Thanks!
> >
> > -- markus.
> >
> > bash-3.00$ cat build.xml.diff
> > Index: build.xml
> >
============================================================
=======
> > --- build.xml   (Revision 493039)
> > +++ build.xml   (Arbeitskopie)
> >  -891,12 +891,6 
> >              excludes="**/*.java, **/*.html,
**/*.png" />
> >      </copy>
> >
> > -    <!-- register Ant tasks that were just
built -->
> > -    <taskdef name="startdb"
> >
classname="org.apache.roller.ant.StartDerbyTask"
> > -
> >
classpath="${ro.tools}/buildtime/derby.jar;${ro.tools}/
buildtime/derbynet.jar;${build.compile.tests}"
> > />
> > -    <taskdef name="stopdb"
classname="org.apache.roller.ant.StopDerbyTask"
> > -
> >
classpath="${ro.tools}/buildtime/derby.jar;${ro.tools}/
buildtime/derbynet.jar;${build.compile.tests}"
> > />
> > -
> >      <!--
> >      Copy web config files to ${build.tests} to
make them available for
> > testing.
> >      This includes the WEB-INF directory, minus
jsps
> >  -1176,6 +1170,8 
> >  </target>
> >
> >  <target name="start-db"
description="Starts built-in database">
> > +    <taskdef name="startdb"
> >
classname="org.apache.roller.ant.StartDerbyTask"
> > +
> >
classpath="${ro.tools}/buildtime/derby.jar;${ro.tools}/
buildtime/derbynet.jar;${build.compile.tests}"
> > />
> >      <startdb
database="${build.tests}/derby-system/roller"
port="3219" />
> >      <!--
> >      <delete
dir="${build.tests}/derby-system/roller" />
> >  -1191,6 +1187,8 
> >  </target>
> >
> >  <target name="stop-db"
description="Drop tables and stops the built-in
> > database">
> > +    <taskdef name="stopdb"
classname="org.apache.roller.ant.StopDerbyTask"
> > +
> >
classpath="${ro.tools}/buildtime/derby.jar;${ro.tools}/
buildtime/derbynet.jar;${build.compile.tests}"
> > />
> >      <stopdb port="3219"/>
> >      <!--
> >      <delete
dir="${build.tests}/derby-system/roller" />
> >
> >
> >
> >
>
Small change to build.xml
user name
2007-01-08 10:18:33
I must have missed a recent update... Thanks!

-- markus.

Dave wrote:
> On 1/5/07, Markus Fuchs <Markus.Fuchssun.com> wrote:
>> would it make sense to define the tasks to
start/stop Derby in the
>> targets "start-db"/"stop-db",
where they are actually used instead of in
>> "build-tests"? This way, you can run the
tests w/o running
>> "build-tests", once the tests are build,
and the environment doesn't
>> change. The new build.xml and diff are attached.
>
> Yes. That is what we do now in the current code-base
(i.e. the SVN 
> trunk).
>
> You must be working with a slightly older version of
the code.
>
> - Dave
>
>
>>
>> Thanks!
>>
>> -- markus.
>>
>> bash-3.00$ cat build.xml.diff
>> Index: build.xml
>>
============================================================
=======
>> --- build.xml   (Revision 493039)
>> +++ build.xml   (Arbeitskopie)
>>  -891,12 +891,6 
>>              excludes="**/*.java, **/*.html,
**/*.png" />
>>      </copy>
>>
>> -    <!-- register Ant tasks that were just
built -->
>> -    <taskdef name="startdb"
>>
classname="org.apache.roller.ant.StartDerbyTask"
>> -
>>
classpath="${ro.tools}/buildtime/derby.jar;${ro.tools}/
buildtime/derbynet.jar;${build.compile.tests}" 
>>
>> />
>> -    <taskdef name="stopdb" 
>>
classname="org.apache.roller.ant.StopDerbyTask"
>> -
>>
classpath="${ro.tools}/buildtime/derby.jar;${ro.tools}/
buildtime/derbynet.jar;${build.compile.tests}" 
>>
>> />
>> -
>>      <!--
>>      Copy web config files to ${build.tests} to
make them available for
>> testing.
>>      This includes the WEB-INF directory, minus
jsps
>>  -1176,6 +1170,8 
>>  </target>
>>
>>  <target name="start-db"
description="Starts built-in database">
>> +    <taskdef name="startdb"
>>
classname="org.apache.roller.ant.StartDerbyTask"
>> +
>>
classpath="${ro.tools}/buildtime/derby.jar;${ro.tools}/
buildtime/derbynet.jar;${build.compile.tests}" 
>>
>> />
>>      <startdb
database="${build.tests}/derby-system/roller" 
>> port="3219" />
>>      <!--
>>      <delete
dir="${build.tests}/derby-system/roller" />
>>  -1191,6 +1187,8 
>>  </target>
>>
>>  <target name="stop-db"
description="Drop tables and stops the built-in
>> database">
>> +    <taskdef name="stopdb" 
>>
classname="org.apache.roller.ant.StopDerbyTask"
>> +
>>
classpath="${ro.tools}/buildtime/derby.jar;${ro.tools}/
buildtime/derbynet.jar;${build.compile.tests}" 
>>
>> />
>>      <stopdb port="3219"/>
>>      <!--
>>      <delete
dir="${build.tests}/derby-system/roller" />
>>
>>
>>
>>
[1-4]

about | contact  Other archives ( Real Estate discussion Medical topics )