PROPOSAL: register user with e-mail activation

I have taken a look at Sedat's patch and the design and
actual code
look good. I tested against Roller trunk and everything
worked fine --
there are a couple of small fixes in error handling and
email
word/formatting that I will make before committing, but
overall it is
ready to go.

I wrote-up a proposal based on his work here:
http://cwiki.apache.org/confluence/
display/ROLLER/Proposal+Email+Registration

Please review and comment on this proposal.

- Dave

I don't understand what exactly this is trying to
accomplish.  How do 
you actually register an account via email?  You need to
supply input 
for the various form fields at some point right?

Can we get a description of the work flow that this is
advocating?  When 
does the email get sent?  What does it contain?  What action
does the 
recipient take?  etc.

Can we get Sedat access to the wiki so that he can add this
info since 
this is really his proposal?

-- Allen


Dave wrote:
> I have taken a look at Sedat's patch and the design and
actual code
> look good. I tested against Roller trunk and everything
worked fine --
> there are a couple of small fixes in error handling and
email
> word/formatting that I will make before committing, but
overall it is
> ready to go.
> 
> I wrote-up a proposal based on his work here:
> http://cwiki.apache.org/confluence/
display/ROLLER/Proposal+Email+Registration 
> 
> 
> Please review and comment on this proposal.
> 
> - Dave

On 3/21/07, Allen Gilliland <allen.gillilandsun.com> wrote:
> I don't understand what exactly this is trying to
accomplish.  How do
> you actually register an account via email?  You need
to supply input
> for the various form fields at some point right?
>
> Can we get a description of the work flow that this is
advocating?  When
> does the email get sent?  What does it contain?  What
action does the
> recipient take?  etc.

The work flow is this:
1) User enters registration info into existing registration
form and posts
2) Roller responds: thanks for registering, please wait for
activation email
3) User gets email, clicks activation link
4) Roller responds: You are registered! Here's a link for
you to login


> Can we get Sedat access to the wiki so that he can add
this info since
> this is really his proposal?

That's my question as well. Can we give non-committers
access to the wiki?

Anybody (hi Henri) know?

- Dave



> Dave wrote:
> > I have taken a look at Sedat's patch and the
design and actual code
> > look good. I tested against Roller trunk and
everything worked fine --
> > there are a couple of small fixes in error
handling and email
> > word/formatting that I will make before
committing, but overall it is
> > ready to go.
> >
> > I wrote-up a proposal based on his work here:
> > http://cwiki.apache.org/confluence/
display/ROLLER/Proposal+Email+Registration
> >
> >
> > Please review and comment on this proposal.
> >
> > - Dave
>

Dave wrote:
> On 3/21/07, Allen Gilliland <allen.gillilandsun.com> wrote:
>> I don't understand what exactly this is trying to
accomplish.  How do
>> you actually register an account via email?  You
need to supply input
>> for the various form fields at some point right?
>>
>> Can we get a description of the work flow that this
is advocating?  When
>> does the email get sent?  What does it contain? 
What action does the
>> recipient take?  etc.
> 
> The work flow is this:
> 1) User enters registration info into existing
registration form and posts
> 2) Roller responds: thanks for registering, please wait
for activation 
> email
> 3) User gets email, clicks activation link
> 4) Roller responds: You are registered! Here's a link
for you to login

gotcha, i don't know why i was thinking of something else.

in any case, i think the design could be simplified a bit. 
rather than 
create a whole new table why not just add the activationcode
column to 
the existing rolleruser table?  that way we don't need the
new table, 
pojo, and manager methods.  in fact, the registration code
is basically 
unchanged except for adding in this logic ...

if(emailActivationEnabled) {
   newUser.setEnabled(false);

   // generate activation code
   newUser.setActivationCode(code);

   // send activation email
}

-- Allen


> 
> 
>> Can we get Sedat access to the wiki so that he can
add this info since
>> this is really his proposal?
> 
> That's my question as well. Can we give non-committers
access to the wiki?
> 
> Anybody (hi Henri) know?
> 
> - Dave
> 
> 
> 
>> Dave wrote:
>> > I have taken a look at Sedat's patch and the
design and actual code
>> > look good. I tested against Roller trunk and
everything worked fine --
>> > there are a couple of small fixes in error
handling and email
>> > word/formatting that I will make before
committing, but overall it is
>> > ready to go.
>> >
>> > I wrote-up a proposal based on his work here:
>> > 
>> http://cwiki.apache.org/confluence/
display/ROLLER/Proposal+Email+Registration 
>>
>> >
>> >
>> > Please review and comment on this proposal.
>> >
>> > - Dave
>>

On 3/21/07, Allen Gilliland <allen.gillilandsun.com> wrote:
> Dave wrote:
> > On 3/21/07, Allen Gilliland
<allen.gillilandsun.com> wrote:
> >> I don't understand what exactly this is trying
to accomplish.  How do
> >> you actually register an account via email? 
You need to supply input
> >> for the various form fields at some point
right?
> >>
> >> Can we get a description of the work flow that
this is advocating?  When
> >> does the email get sent?  What does it
contain?  What action does the
> >> recipient take?  etc.
> >
> > The work flow is this:
> > 1) User enters registration info into existing
registration form and posts
> > 2) Roller responds: thanks for registering, please
wait for activation
> > email
> > 3) User gets email, clicks activation link
> > 4) Roller responds: You are registered! Here's a
link for you to login
>
> gotcha, i don't know why i was thinking of something
else.
>
> in any case, i think the design could be simplified a
bit.  rather than
> create a whole new table why not just add the
activationcode column to
> the existing rolleruser table?  that way we don't need
the new table,
> pojo, and manager methods.  in fact, the registration
code is basically
> unchanged except for adding in this logic ...
>
> if(emailActivationEnabled) {
>    newUser.setEnabled(false);
>
>    // generate activation code
>    newUser.setActivationCode(code);
>
>    // send activation email
> }

Yes. I prefer that too.

- Dave

I'm fine with this proposal.

Matt

On 3/21/07, Dave <snoopdavegmail.com> wrote:
> On 3/21/07, Allen Gilliland <allen.gillilandsun.com> wrote:
> > Dave wrote:
> > > On 3/21/07, Allen Gilliland
<allen.gillilandsun.com> wrote:
> > >> I don't understand what exactly this is
trying to accomplish.  How do
> > >> you actually register an account via
email?  You need to supply input
> > >> for the various form fields at some point
right?
> > >>
> > >> Can we get a description of the work flow
that this is advocating?  When
> > >> does the email get sent?  What does it
contain?  What action does the
> > >> recipient take?  etc.
> > >
> > > The work flow is this:
> > > 1) User enters registration info into
existing registration form and posts
> > > 2) Roller responds: thanks for registering,
please wait for activation
> > > email
> > > 3) User gets email, clicks activation link
> > > 4) Roller responds: You are registered!
Here's a link for you to login
> >
> > gotcha, i don't know why i was thinking of
something else.
> >
> > in any case, i think the design could be
simplified a bit.  rather than
> > create a whole new table why not just add the
activationcode column to
> > the existing rolleruser table?  that way we don't
need the new table,
> > pojo, and manager methods.  in fact, the
registration code is basically
> > unchanged except for adding in this logic ...
> >
> > if(emailActivationEnabled) {
> >    newUser.setEnabled(false);
> >
> >    // generate activation code
> >    newUser.setActivationCode(code);
> >
> >    // send activation email
> > }
>
> Yes. I prefer that too.
>
> - Dave
>


-- 
http://raibledesigns.com