Submitting patches, Microsoft SQL Server

Dave,

      The patch I gave you is a bit old, I've since updated
it to fix
some problems with the getReferrers call (text and clob
fields on SQL
server, Sybase and Oracle does not allow = '', only like
'')

Moreover, I've updated parts of the metadata db files and
added a field
definition for the TIMESTAMP type (on some databases, it's
timestamp, on
others like SQL server and Sybase, it's datetime (up to the
millisecond).  SQL server and Sybase treat the timestamp
data type in a
weird way hence can't be used as a timestamp in a normal
sense.

I'm planning on generating a new patch in diff to the
latest trunk,
would that be okay?

I've been using SQL Server here along with roller 2.1+ and
it's working
just fine.

George

-----Original Message-----
From: Dave Johnson [mailto:dave.johnsonrollerweblogger.org] 
Sent: Tuesday, March 21, 2006 1:35 PM
To: roller-devincubator.apache.org
Subject: Re: Submitting patches, Microsoft SQL Server

George,

Thanks for the patch, I've integrated it into my workspace
and it  
looks safe to commit. However, you did not provide the  
mssql.properties file. Would you please send that along too.

- Dave


On Feb 11, 2006, at 4:23 PM, George Daswani wrote:

> Here are the patches, attached.
>
> the msssql.properties goes to /trunk/metadata/database
>
> -----Original Message-----
> From: George Daswani [mailto:gdaswaniesri.com]
> Sent: Friday, February 10, 2006 11:18 PM
> To: roller-devincubator.apache.org
> Subject: RE: Submitting patches, Microsoft SQL Server
>
>
> Thanks for the reply.
>
> I submitted it to the JIRA - as ROL-1044
>
> Attached an svn diff file, along with the new
properties file  
> (datatype) for Microsoft SQL Server 2000 (should also
work with 2005).
>
> I've tested it both on the JTDS 1.2 Type4 JDBC Driver,
along with  
> Microsoft's MSSQL-2005 Type JDBC driver.
>
> George Daswani
>
> -----Original Message-----
> From: Davidm.JohnsonSun.COM [mailtoavidm.Jo
hnsonSun.COM]
> Sent: Tuesday, February 07, 2006 6:10 AM
> To: roller-devincubator.apache.org
> Subject: Re: Submitting patches, Microsoft SQL Server
>
>
>
> You should be able to use the "svn diff"
command or your favorite IDE
> file to create a patch containing your changes and new
files. Once
> you have that, send it to the Roller dev mailing list
or create an
> issue in JIRA and attach it to that issue. Once you've
done that, one
> of us will look at it and if it looks good we'll
commit it.
>
> - Dave
>
>
>
> On Feb 6, 2006, at 4:16 PM, George Daswani wrote:
>> Hello Roller Developers,
>>
>> 	We looked at the Roller package and we are
planning on using it
as
>> our main blog software.  I've modified the sources
and builds to
>> support Microsoft SQL server - how do we go about
submitting the
>> patches? (format, and etc).
>>
>> The process/procedure doesn't seem to be listed in
the Roller Wiki.
>>
>> Thanks,
>> George Daswani
>> ESRI / InfoServices-Systems Development
>>
>>
>>
>>
>
>
>
> <svndiff.txt>

Yes, please do send a new patch.

- Dave


On Mar 21, 2006, at 5:33 PM, George Daswani wrote:

> Dave,
>
>       The patch I gave you is a bit old, I've since
updated it to fix
> some problems with the getReferrers call (text and clob
fields on SQL
> server, Sybase and Oracle does not allow = '', only
like '')
>
> Moreover, I've updated parts of the metadata db files
and added a  
> field
> definition for the TIMESTAMP type (on some databases,
it's  
> timestamp, on
> others like SQL server and Sybase, it's datetime (up
to the
> millisecond).  SQL server and Sybase treat the
timestamp data type  
> in a
> weird way hence can't be used as a timestamp in a
normal sense.
>
> I'm planning on generating a new patch in diff to the
latest trunk,
> would that be okay?
>
> I've been using SQL Server here along with roller 2.1+
and it's  
> working
> just fine.
>
> George
>
> -----Original Message-----
> From: Dave Johnson [mailto:dave.johnsonrollerweblogger.org]
> Sent: Tuesday, March 21, 2006 1:35 PM
> To: roller-devincubator.apache.org
> Subject: Re: Submitting patches, Microsoft SQL Server
>
> George,
>
> Thanks for the patch, I've integrated it into my
workspace and it
> looks safe to commit. However, you did not provide the
> mssql.properties file. Would you please send that along
too.
>
> - Dave
>
>
> On Feb 11, 2006, at 4:23 PM, George Daswani wrote:
>
>> Here are the patches, attached.
>>
>> the msssql.properties goes to
/trunk/metadata/database
>>
>> -----Original Message-----
>> From: George Daswani [mailto:gdaswaniesri.com]
>> Sent: Friday, February 10, 2006 11:18 PM
>> To: roller-devincubator.apache.org
>> Subject: RE: Submitting patches, Microsoft SQL
Server
>>
>>
>> Thanks for the reply.
>>
>> I submitted it to the JIRA - as ROL-1044
>>
>> Attached an svn diff file, along with the new
properties file
>> (datatype) for Microsoft SQL Server 2000 (should
also work with  
>> 2005).
>>
>> I've tested it both on the JTDS 1.2 Type4 JDBC
Driver, along with
>> Microsoft's MSSQL-2005 Type JDBC driver.
>>
>> George Daswani
>>
>> -----Original Message-----
>> From: Davidm.JohnsonSun.COM [mailtoavidm.Jo
hnsonSun.COM]
>> Sent: Tuesday, February 07, 2006 6:10 AM
>> To: roller-devincubator.apache.org
>> Subject: Re: Submitting patches, Microsoft SQL
Server
>>
>>
>>
>> You should be able to use the "svn
diff" command or your favorite IDE
>> file to create a patch containing your changes and
new files. Once
>> you have that, send it to the Roller dev mailing
list or create an
>> issue in JIRA and attach it to that issue. Once
you've done that, one
>> of us will look at it and if it looks good we'll
commit it.
>>
>> - Dave
>>
>>
>>
>> On Feb 6, 2006, at 4:16 PM, George Daswani wrote:
>>> Hello Roller Developers,
>>>
>>> 	We looked at the Roller package and we are
planning on using it
> as
>>> our main blog software.  I've modified the
sources and builds to
>>> support Microsoft SQL server - how do we go
about submitting the
>>> patches? (format, and etc).
>>>
>>> The process/procedure doesn't seem to be
listed in the Roller Wiki.
>>>
>>> Thanks,
>>> George Daswani
>>> ESRI / InfoServices-Systems Development
>>>
>>>
>>>
>>>
>>
>>
>>
>> <svndiff.txt>
>
>