List Info

Thread: Created: (WW-1938) Bug with multiple s:param tags inside s:url tag




Created: (WW-1938) Bug with multiple s:param tags inside s:url tag
country flaguser name
United States
2007-05-21 06:43:43
Bug with multiple  s:param tags inside s:url tag
------------------------------------------------

                 Key: WW-1938
                 URL: https
://issues.apache.org/struts/browse/WW-1938
             Project: Struts 2
          Issue Type: Bug
    Affects Versions: 2.1.0
            Reporter: Pavel Rodionov


 <s:url id="urlFlash"
action="viewFlash" includeParams="none"
>
        <s:param name="blogid"
value="%"/>
        <s:param name="haaa"
value="111"/>
    </s:url>
Following construction generate strange url 
http://10.2.1.25:8081/Co
mmentSystemWebApp/viewFlash.action?blogid=4&amp;amp;haaa
=111
Look at "amp;amp;" it's like encoding ampersand
'&'


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


Updated: (WW-1938) Bug with multiple s:param tags inside s:url tag
country flaguser name
United States
2007-05-22 07:48:43
     [ https://issues.apache.org/struts/browse/WW-1938?page=com.at
lassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Don Brown updated WW-1938:
--------------------------

    Affects Version/s:     (was: 2.1.0)
                       2.0.6
        Fix Version/s: 2.0.9

> Bug with multiple  s:param tags inside s:url tag
> ------------------------------------------------
>
>                 Key: WW-1938
>                 URL: https
://issues.apache.org/struts/browse/WW-1938
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.0.6
>            Reporter: Pavel Rodionov
>             Fix For: 2.0.9
>
>
>  <s:url id="urlFlash"
action="viewFlash" includeParams="none"
>
>         <s:param name="blogid"
value="%"/>
>         <s:param name="haaa"
value="111"/>
>     </s:url>
> Following construction generate strange url 
> http://10.2.1.25:8081/Co
mmentSystemWebApp/viewFlash.action?blogid=4&amp;amp;haaa
=111
> Look at "amp;amp;" it's like encoding
ampersand '&'

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


Updated: (WW-1938) Bug with multiple s:param tags inside s:url tag
country flaguser name
United States
2007-07-19 14:37:12
     [ https://issues.apache.org/struts/browse/WW-1938?page=com.at
lassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

James Holmes updated WW-1938:
-----------------------------

    Fix Version/s:     (was: 2.0.9)
                   2.0.10

Moving to 2.0.10 so that 2.0.9 can be released.

> Bug with multiple  s:param tags inside s:url tag
> ------------------------------------------------
>
>                 Key: WW-1938
>                 URL: https
://issues.apache.org/struts/browse/WW-1938
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.0.6
>            Reporter: Pavel Rodionov
>             Fix For: 2.0.10
>
>
>  <s:url id="urlFlash"
action="viewFlash" includeParams="none"
>
>         <s:param name="blogid"
value="%"/>
>         <s:param name="haaa"
value="111"/>
>     </s:url>
> Following construction generate strange url 
> http://10.2.1.25:8081/Co
mmentSystemWebApp/viewFlash.action?blogid=4&amp;amp;haaa
=111
> Look at "amp;amp;" it's like encoding
ampersand '&'

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


Assigned: (WW-1938) Bug with multiple s:param tags inside s:url tag
country flaguser name
United States
2007-07-23 14:18:05
     [ https://issues.apache.org/struts/browse/WW-1938?page=com.at
lassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

James Holmes reassigned WW-1938:
--------------------------------

    Assignee: James Holmes

> Bug with multiple  s:param tags inside s:url tag
> ------------------------------------------------
>
>                 Key: WW-1938
>                 URL: https
://issues.apache.org/struts/browse/WW-1938
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.0.6
>            Reporter: Pavel Rodionov
>            Assignee: James Holmes
>             Fix For: 2.0.10
>
>
>  <s:url id="urlFlash"
action="viewFlash" includeParams="none"
>
>         <s:param name="blogid"
value="%"/>
>         <s:param name="haaa"
value="111"/>
>     </s:url>
> Following construction generate strange url 
> http://10.2.1.25:8081/Co
mmentSystemWebApp/viewFlash.action?blogid=4&amp;amp;haaa
=111
> Look at "amp;amp;" it's like encoding
ampersand '&'

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


Commented: (WW-1938) Bug with multiple s:param tags inside s:url tag
country flaguser name
United States
2007-07-23 14:18:05
    [ https://issues.apache.org/struts/browse/WW
-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:c
omment-tabpanel#action_41623 ] 

James Holmes commented on WW-1938:
----------------------------------

This was resolved in WebWork by adding an additional
attribute to the url tag that supports disabling/enabling
escaping the ampersands that are used to separate
parameters.

http://ji
ra.opensymphony.com/browse/WW-1403

> Bug with multiple  s:param tags inside s:url tag
> ------------------------------------------------
>
>                 Key: WW-1938
>                 URL: https
://issues.apache.org/struts/browse/WW-1938
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.0.6
>            Reporter: Pavel Rodionov
>             Fix For: 2.0.10
>
>
>  <s:url id="urlFlash"
action="viewFlash" includeParams="none"
>
>         <s:param name="blogid"
value="%"/>
>         <s:param name="haaa"
value="111"/>
>     </s:url>
> Following construction generate strange url 
> http://10.2.1.25:8081/Co
mmentSystemWebApp/viewFlash.action?blogid=4&amp;amp;haaa
=111
> Look at "amp;amp;" it's like encoding
ampersand '&'

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


Commented: (WW-1938) Bug with multiple s:param tags inside s:url tag
country flaguser name
United States
2007-07-23 23:52:05
    [ https://issues.apache.org/struts/browse/WW
-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:c
omment-tabpanel#action_41629 ] 

Aram Mkhitaryan commented on WW-1938:
-------------------------------------

I think the parameters should always be escaped 
and the separator ampersands should never be escaped
and there is no need to add the additional attribute to
enable or disable the escaping

> Bug with multiple  s:param tags inside s:url tag
> ------------------------------------------------
>
>                 Key: WW-1938
>                 URL: https
://issues.apache.org/struts/browse/WW-1938
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.0.6
>            Reporter: Pavel Rodionov
>            Assignee: James Holmes
>             Fix For: 2.0.10
>
>
>  <s:url id="urlFlash"
action="viewFlash" includeParams="none"
>
>         <s:param name="blogid"
value="%"/>
>         <s:param name="haaa"
value="111"/>
>     </s:url>
> Following construction generate strange url 
> http://10.2.1.25:8081/Co
mmentSystemWebApp/viewFlash.action?blogid=4&amp;amp;haaa
=111
> Look at "amp;amp;" it's like encoding
ampersand '&'

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


Commented: (WW-1938) Bug with multiple s:param tags inside s:url tag
country flaguser name
United States
2007-07-24 09:56:05
    [ https://issues.apache.org/struts/browse/WW
-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:c
omment-tabpanel#action_41634 ] 

James Holmes commented on WW-1938:
----------------------------------

The separator ampersands have to encoded to support XHTML
compliance. Please follow the discussion of WebWork ticket
1403 (URL above) to see the full history.

> Bug with multiple  s:param tags inside s:url tag
> ------------------------------------------------
>
>                 Key: WW-1938
>                 URL: https
://issues.apache.org/struts/browse/WW-1938
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.0.6
>            Reporter: Pavel Rodionov
>            Assignee: James Holmes
>             Fix For: 2.0.10
>
>
>  <s:url id="urlFlash"
action="viewFlash" includeParams="none"
>
>         <s:param name="blogid"
value="%"/>
>         <s:param name="haaa"
value="111"/>
>     </s:url>
> Following construction generate strange url 
> http://10.2.1.25:8081/Co
mmentSystemWebApp/viewFlash.action?blogid=4&amp;amp;haaa
=111
> Look at "amp;amp;" it's like encoding
ampersand '&'

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


Commented: (WW-1938) Bug with multiple s:param tags inside s:url tag
country flaguser name
United States
2007-07-24 10:02:05
    [ https://issues.apache.org/struts/browse/WW
-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:c
omment-tabpanel#action_41635 ] 

James Holmes commented on WW-1938:
----------------------------------

A quick note. When using the JSP EL, there is no issue with
the ampersands. For example, consider the following

<s:url id="testUrl"
action="AssimilatorMySeekers"
includeParams="none" >
	<s:param name="foo" value="1"/>
	<s:param name="bar" value="2"/>
	<s:param name="baz" value="3"/>
</s:url>

<a href="<s:property
value="%"/>">test
1</a><br>
<a href="$">test
2</a><br>
<s:a href="%">test 3</s:a>

Only "test 1" in the example above has the issue.
This is because the <s:property/> tag escapes
everything it is passed.

I'm going to commit a fix similar to the one that was
implemented for WebWork. I will add an escapeAmp attribute
to the <s:url/> tag and have it default to true.

> Bug with multiple  s:param tags inside s:url tag
> ------------------------------------------------
>
>                 Key: WW-1938
>                 URL: https
://issues.apache.org/struts/browse/WW-1938
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.0.6
>            Reporter: Pavel Rodionov
>            Assignee: James Holmes
>             Fix For: 2.0.10
>
>
>  <s:url id="urlFlash"
action="viewFlash" includeParams="none"
>
>         <s:param name="blogid"
value="%"/>
>         <s:param name="haaa"
value="111"/>
>     </s:url>
> Following construction generate strange url 
> http://10.2.1.25:8081/Co
mmentSystemWebApp/viewFlash.action?blogid=4&amp;amp;haaa
=111
> Look at "amp;amp;" it's like encoding
ampersand '&'

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


Work started: (WW-1938) Bug with multiple s:param tags inside s:url tag
country flaguser name
United States
2007-07-24 11:10:05
     [ https://issues.apache.org/struts/browse/WW-1938?page=com.at
lassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Work on WW-1938 started by James Holmes.

> Bug with multiple  s:param tags inside s:url tag
> ------------------------------------------------
>
>                 Key: WW-1938
>                 URL: https
://issues.apache.org/struts/browse/WW-1938
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.0.6
>            Reporter: Pavel Rodionov
>            Assignee: James Holmes
>             Fix For: 2.0.10
>
>
>  <s:url id="urlFlash"
action="viewFlash" includeParams="none"
>
>         <s:param name="blogid"
value="%"/>
>         <s:param name="haaa"
value="111"/>
>     </s:url>
> Following construction generate strange url 
> http://10.2.1.25:8081/Co
mmentSystemWebApp/viewFlash.action?blogid=4&amp;amp;haaa
=111
> Look at "amp;amp;" it's like encoding
ampersand '&'

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


Commented: (WW-1938) Bug with multiple s:param tags inside s:url tag
country flaguser name
United States
2007-07-24 12:40:05
    [ https://issues.apache.org/struts/browse/WW
-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:c
omment-tabpanel#action_41638 ] 

James Holmes commented on WW-1938:
----------------------------------

Fixed on the trunk (Struts 2.1) in SVN revision 559127.

> Bug with multiple  s:param tags inside s:url tag
> ------------------------------------------------
>
>                 Key: WW-1938
>                 URL: https
://issues.apache.org/struts/browse/WW-1938
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.0.6
>            Reporter: Pavel Rodionov
>            Assignee: James Holmes
>             Fix For: 2.0.10
>
>
>  <s:url id="urlFlash"
action="viewFlash" includeParams="none"
>
>         <s:param name="blogid"
value="%"/>
>         <s:param name="haaa"
value="111"/>
>     </s:url>
> Following construction generate strange url 
> http://10.2.1.25:8081/Co
mmentSystemWebApp/viewFlash.action?blogid=4&amp;amp;haaa
=111
> Look at "amp;amp;" it's like encoding
ampersand '&'

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


[1-10] [11-12]

about | contact  Other archives ( Real Estate discussion Medical topics )