List Info

Thread: Created: (WW-2064) XHTML chekbox template does not include tooltip consistently




Created: (WW-2064) XHTML chekbox template does not include tooltip consistently
country flaguser name
United States
2007-07-26 09:10:06
XHTML chekbox template does not include tooltip
consistently
------------------------------------------------------------


                 Key: WW-2064
                 URL: https
://issues.apache.org/struts/browse/WW-2064
             Project: Struts 2
          Issue Type: Bug
          Components: Views
    Affects Versions: 2.0.9, 2.0.8
            Reporter: Max Pimm
            Priority: Trivial


In the freemarker template for the checkbox element in the
xhtml template (templates/xhtml/checkbox.ftl) the way the
tooltip element in generated is not consistent.

>From what i can see in all other templates the tooltip
is generated by including templats/xhtml/tooltip.ftl. In the
check box template the tooltip is required three times (one
for each of the different label positions). For the top
position this is implemented via an include.

line37: <#include
"/${parameters.templateDir}/xhtml/tooltip.ftl"
/>

However in the left and right positions it is implemented
with inline code:

lines 69 and 79: <img src='<s.url
value="/struts/tooltip/tooltip.gif"
includeParams="none"
encode="false"/>'
alt="${parameters.tooltip}"
title="${parameters.tooltip}"
onmouseover="return
escape('${parameters.tooltip?js_string}');" />

I think that the lines 69 and 79 should use the same include
as the line 37 so as to be able to profit from the dojo
tooltip in the include and future changes to the tooltip
include.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


Assigned: (WW-2064) XHTML chekbox template does not include tooltip consistently
country flaguser name
United States
2007-07-26 10:02:06
     [ https://issues.apache.org/struts/browse/WW-2064?page=com.at
lassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

James Holmes reassigned WW-2064:
--------------------------------

    Assignee: James Holmes

> XHTML chekbox template does not include tooltip
consistently
>
------------------------------------------------------------

>
>                 Key: WW-2064
>                 URL: https
://issues.apache.org/struts/browse/WW-2064
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Views
>    Affects Versions: 2.0.8, 2.0.9
>            Reporter: Max Pimm
>            Assignee: James Holmes
>            Priority: Trivial
>             Fix For: 2.0.10
>
>
> In the freemarker template for the checkbox element in
the xhtml template (templates/xhtml/checkbox.ftl) the way
the tooltip element in generated is not consistent.
> From what i can see in all other templates the tooltip
is generated by including templats/xhtml/tooltip.ftl. In the
check box template the tooltip is required three times (one
for each of the different label positions). For the top
position this is implemented via an include.
> line37: <#include
"/${parameters.templateDir}/xhtml/tooltip.ftl"
/>
> However in the left and right positions it is
implemented with inline code:
> lines 69 and 79: <img src='<s.url
value="/struts/tooltip/tooltip.gif"
includeParams="none"
encode="false"/>'
alt="${parameters.tooltip}"
title="${parameters.tooltip}"
onmouseover="return
escape('${parameters.tooltip?js_string}');" />
> I think that the lines 69 and 79 should use the same
include as the line 37 so as to be able to profit from the
dojo tooltip in the include and future changes to the
tooltip include.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


Updated: (WW-2064) XHTML chekbox template does not include tooltip consistently
country flaguser name
United States
2007-07-26 10:02:06
     [ https://issues.apache.org/struts/browse/WW-2064?page=com.at
lassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

James Holmes updated WW-2064:
-----------------------------

    Fix Version/s: 2.0.10

> XHTML chekbox template does not include tooltip
consistently
>
------------------------------------------------------------

>
>                 Key: WW-2064
>                 URL: https
://issues.apache.org/struts/browse/WW-2064
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Views
>    Affects Versions: 2.0.8, 2.0.9
>            Reporter: Max Pimm
>            Assignee: James Holmes
>            Priority: Trivial
>             Fix For: 2.0.10
>
>
> In the freemarker template for the checkbox element in
the xhtml template (templates/xhtml/checkbox.ftl) the way
the tooltip element in generated is not consistent.
> From what i can see in all other templates the tooltip
is generated by including templats/xhtml/tooltip.ftl. In the
check box template the tooltip is required three times (one
for each of the different label positions). For the top
position this is implemented via an include.
> line37: <#include
"/${parameters.templateDir}/xhtml/tooltip.ftl"
/>
> However in the left and right positions it is
implemented with inline code:
> lines 69 and 79: <img src='<s.url
value="/struts/tooltip/tooltip.gif"
includeParams="none"
encode="false"/>'
alt="${parameters.tooltip}"
title="${parameters.tooltip}"
onmouseover="return
escape('${parameters.tooltip?js_string}');" />
> I think that the lines 69 and 79 should use the same
include as the line 37 so as to be able to profit from the
dojo tooltip in the include and future changes to the
tooltip include.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


Updated: (WW-2064) XHTML checkbox template does not include tooltip consistently
country flaguser name
United States
2007-07-26 10:12:06
     [ https://issues.apache.org/struts/browse/WW-2064?page=com.at
lassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

James Holmes updated WW-2064:
-----------------------------

    Summary: XHTML checkbox template does not include
tooltip consistently  (was: XHTML chekbox template does not
include tooltip consistently)

> XHTML checkbox template does not include tooltip
consistently
>
------------------------------------------------------------
-
>
>                 Key: WW-2064
>                 URL: https
://issues.apache.org/struts/browse/WW-2064
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Views
>    Affects Versions: 2.0.8, 2.0.9
>            Reporter: Max Pimm
>            Assignee: James Holmes
>            Priority: Trivial
>             Fix For: 2.0.10
>
>
> In the freemarker template for the checkbox element in
the xhtml template (templates/xhtml/checkbox.ftl) the way
the tooltip element in generated is not consistent.
> From what i can see in all other templates the tooltip
is generated by including templats/xhtml/tooltip.ftl. In the
check box template the tooltip is required three times (one
for each of the different label positions). For the top
position this is implemented via an include.
> line37: <#include
"/${parameters.templateDir}/xhtml/tooltip.ftl"
/>
> However in the left and right positions it is
implemented with inline code:
> lines 69 and 79: <img src='<s.url
value="/struts/tooltip/tooltip.gif"
includeParams="none"
encode="false"/>'
alt="${parameters.tooltip}"
title="${parameters.tooltip}"
onmouseover="return
escape('${parameters.tooltip?js_string}');" />
> I think that the lines 69 and 79 should use the same
include as the line 37 so as to be able to profit from the
dojo tooltip in the include and future changes to the
tooltip include.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


Resolved: (WW-2064) XHTML checkbox template does not include tooltip consistently
country flaguser name
United States
2007-07-26 10:20:05
     [ https://issues.apache.org/struts/browse/WW-2064?page=com.at
lassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

James Holmes resolved WW-2064.
------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1.0

Fixed on the Struts 2_0_X branch in SVN revision 559846.
Fixed on the trunk (Struts 2.1) in SVN revision 559849.

Thanks for the heads up. Keep 'em coming!

> XHTML checkbox template does not include tooltip
consistently
>
------------------------------------------------------------
-
>
>                 Key: WW-2064
>                 URL: https
://issues.apache.org/struts/browse/WW-2064
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Views
>    Affects Versions: 2.0.8, 2.0.9
>            Reporter: Max Pimm
>            Assignee: James Holmes
>            Priority: Trivial
>             Fix For: 2.0.10, 2.1.0
>
>
> In the freemarker template for the checkbox element in
the xhtml template (templates/xhtml/checkbox.ftl) the way
the tooltip element in generated is not consistent.
> From what i can see in all other templates the tooltip
is generated by including templats/xhtml/tooltip.ftl. In the
check box template the tooltip is required three times (one
for each of the different label positions). For the top
position this is implemented via an include.
> line37: <#include
"/${parameters.templateDir}/xhtml/tooltip.ftl"
/>
> However in the left and right positions it is
implemented with inline code:
> lines 69 and 79: <img src='<s.url
value="/struts/tooltip/tooltip.gif"
includeParams="none"
encode="false"/>'
alt="${parameters.tooltip}"
title="${parameters.tooltip}"
onmouseover="return
escape('${parameters.tooltip?js_string}');" />
> I think that the lines 69 and 79 should use the same
include as the line 37 so as to be able to profit from the
dojo tooltip in the include and future changes to the
tooltip include.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


[1-5]

about | contact  Other archives ( Real Estate discussion Medical topics )