List Info

Thread: Created: (XMLRPC-149) customizable user agent header for the client




Created: (XMLRPC-149) customizable user agent header for the client
user name
2007-09-27 08:18:51
customizable user agent header for the client
---------------------------------------------

                 Key: XMLRPC-149
                 URL: http
s://issues.apache.org/jira/browse/XMLRPC-149
             Project: XML-RPC
          Issue Type: Improvement
    Affects Versions: 3.1
         Environment: Gentoo / jdk 1.6
            Reporter: Andreas Sahlbach


Our client sets the user agent to an application string +
version information. The user agent field can be easily read
out at the web server and is an important information for
the support and for statistics (how many old clients are
still out there? how many customer have upgraded? is it true
that the customer is using the new client or is he really
using an old client, lying somewhere hidden in the
classpath? etc.)

Now we want to upgrade the xmlrpc lib to 3.1 and noticed
that the user agent field is set by the library.
Unfortunately it's not possible to customize this setting to
our needs. I've added a patch that is allowing us to set the
user agent to a string we are choosing. The code should be
100% compatible and there should be no negative side
effects. Please consider to put this into the upstream as
soon as possible. Thanks a lot!


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


Updated: (XMLRPC-149) customizable user agent header for the client
user name
2007-09-27 08:20:50
     [ https://issues.apache.org/jira/browse/XMLRPC-149?page=com.
atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andreas Sahlbach updated XMLRPC-149:
------------------------------------

    Attachment: xmlrpc-ua.patch

Adds a ctor to the http transport factories to allow the
user to set the user agent header to a value he has chosen.

> customizable user agent header for the client
> ---------------------------------------------
>
>                 Key: XMLRPC-149
>                 URL: http
s://issues.apache.org/jira/browse/XMLRPC-149
>             Project: XML-RPC
>          Issue Type: Improvement
>    Affects Versions: 3.1
>         Environment: Gentoo / jdk 1.6
>            Reporter: Andreas Sahlbach
>         Attachments: xmlrpc-ua.patch
>
>
> Our client sets the user agent to an application string
+ version information. The user agent field can be easily
read out at the web server and is an important information
for the support and for statistics (how many old clients are
still out there? how many customer have upgraded? is it true
that the customer is using the new client or is he really
using an old client, lying somewhere hidden in the
classpath? etc.)
> Now we want to upgrade the xmlrpc lib to 3.1 and
noticed that the user agent field is set by the library.
Unfortunately it's not possible to customize this setting to
our needs. I've added a patch that is allowing us to set the
user agent to a string we are choosing. The code should be
100% compatible and there should be no negative side
effects. Please consider to put this into the upstream as
soon as possible. Thanks a lot!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


Commented: (XMLRPC-149) customizable user agent header for the client
user name
2007-09-27 08:54:50
    [ https://issues.apache.org/jira/browse/
XMLRPC-149?page=com.atlassian.jira.plugin.system.issuetabpan
els:comment-tabpanel#action_12530727 ] 

Jochen Wiedmann commented on XMLRPC-149:
----------------------------------------

The transport factories must not have constructor
arguments.

If you want to bring your patch in, use
XmlRpcHttpClientConfig, or whatever class comes close.


> customizable user agent header for the client
> ---------------------------------------------
>
>                 Key: XMLRPC-149
>                 URL: http
s://issues.apache.org/jira/browse/XMLRPC-149
>             Project: XML-RPC
>          Issue Type: Improvement
>    Affects Versions: 3.1
>         Environment: Gentoo / jdk 1.6
>            Reporter: Andreas Sahlbach
>         Attachments: xmlrpc-ua.patch
>
>
> Our client sets the user agent to an application string
+ version information. The user agent field can be easily
read out at the web server and is an important information
for the support and for statistics (how many old clients are
still out there? how many customer have upgraded? is it true
that the customer is using the new client or is he really
using an old client, lying somewhere hidden in the
classpath? etc.)
> Now we want to upgrade the xmlrpc lib to 3.1 and
noticed that the user agent field is set by the library.
Unfortunately it's not possible to customize this setting to
our needs. I've added a patch that is allowing us to set the
user agent to a string we are choosing. The code should be
100% compatible and there should be no negative side
effects. Please consider to put this into the upstream as
soon as possible. Thanks a lot!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


Commented: (XMLRPC-149) customizable user agent header for the client
user name
2007-09-27 09:57:50
    [ https://issues.apache.org/jira/browse/
XMLRPC-149?page=com.atlassian.jira.plugin.system.issuetabpan
els:comment-tabpanel#action_12530751 ] 

Andreas Sahlbach commented on XMLRPC-149:
-----------------------------------------

Could you tell me why? No offence, I just want to
understand.

The transport factories already had an argument
(XmlRpcClient) and they are instantiated by the user.
Therefore I thought it's a good place to put it in.


> customizable user agent header for the client
> ---------------------------------------------
>
>                 Key: XMLRPC-149
>                 URL: http
s://issues.apache.org/jira/browse/XMLRPC-149
>             Project: XML-RPC
>          Issue Type: Improvement
>    Affects Versions: 3.1
>         Environment: Gentoo / jdk 1.6
>            Reporter: Andreas Sahlbach
>         Attachments: xmlrpc-ua.patch
>
>
> Our client sets the user agent to an application string
+ version information. The user agent field can be easily
read out at the web server and is an important information
for the support and for statistics (how many old clients are
still out there? how many customer have upgraded? is it true
that the customer is using the new client or is he really
using an old client, lying somewhere hidden in the
classpath? etc.)
> Now we want to upgrade the xmlrpc lib to 3.1 and
noticed that the user agent field is set by the library.
Unfortunately it's not possible to customize this setting to
our needs. I've added a patch that is allowing us to set the
user agent to a string we are choosing. The code should be
100% compatible and there should be no negative side
effects. Please consider to put this into the upstream as
soon as possible. Thanks a lot!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


Commented: (XMLRPC-149) customizable user agent header for the client
user name
2007-09-27 10:13:50
    [ https://issues.apache.org/jira/browse/
XMLRPC-149?page=com.atlassian.jira.plugin.system.issuetabpan
els:comment-tabpanel#action_12530754 ] 

Jochen Wiedmann commented on XMLRPC-149:
----------------------------------------

Because we wouldn't want to introduce new constructors for
any new configurable value and because the *Config objects
are made exactly for the purpose of configuration. And
setting the user-agent is a configuration, isn't it?


> customizable user agent header for the client
> ---------------------------------------------
>
>                 Key: XMLRPC-149
>                 URL: http
s://issues.apache.org/jira/browse/XMLRPC-149
>             Project: XML-RPC
>          Issue Type: Improvement
>    Affects Versions: 3.1
>         Environment: Gentoo / jdk 1.6
>            Reporter: Andreas Sahlbach
>         Attachments: xmlrpc-ua.patch
>
>
> Our client sets the user agent to an application string
+ version information. The user agent field can be easily
read out at the web server and is an important information
for the support and for statistics (how many old clients are
still out there? how many customer have upgraded? is it true
that the customer is using the new client or is he really
using an old client, lying somewhere hidden in the
classpath? etc.)
> Now we want to upgrade the xmlrpc lib to 3.1 and
noticed that the user agent field is set by the library.
Unfortunately it's not possible to customize this setting to
our needs. I've added a patch that is allowing us to set the
user agent to a string we are choosing. The code should be
100% compatible and there should be no negative side
effects. Please consider to put this into the upstream as
soon as possible. Thanks a lot!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


Updated: (XMLRPC-149) customizable user agent header for the client
user name
2007-09-27 10:50:50
     [ https://issues.apache.org/jira/browse/XMLRPC-149?page=com.
atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andreas Sahlbach updated XMLRPC-149:
------------------------------------

    Attachment:     (was: xmlrpc-ua.patch)

> customizable user agent header for the client
> ---------------------------------------------
>
>                 Key: XMLRPC-149
>                 URL: http
s://issues.apache.org/jira/browse/XMLRPC-149
>             Project: XML-RPC
>          Issue Type: Improvement
>    Affects Versions: 3.1
>         Environment: Gentoo / jdk 1.6
>            Reporter: Andreas Sahlbach
>
> Our client sets the user agent to an application string
+ version information. The user agent field can be easily
read out at the web server and is an important information
for the support and for statistics (how many old clients are
still out there? how many customer have upgraded? is it true
that the customer is using the new client or is he really
using an old client, lying somewhere hidden in the
classpath? etc.)
> Now we want to upgrade the xmlrpc lib to 3.1 and
noticed that the user agent field is set by the library.
Unfortunately it's not possible to customize this setting to
our needs. I've added a patch that is allowing us to set the
user agent to a string we are choosing. The code should be
100% compatible and there should be no negative side
effects. Please consider to put this into the upstream as
soon as possible. Thanks a lot!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


Updated: (XMLRPC-149) customizable user agent header for the client
user name
2007-09-27 10:52:50
     [ https://issues.apache.org/jira/browse/XMLRPC-149?page=com.
atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andreas Sahlbach updated XMLRPC-149:
------------------------------------

    Attachment: xmlrpc-ua2.patch

Modified the XmlRpcHttpClientConfig and Impl to have an
customizable user agent string. Modifed the
XmlRpcHttpTransport to use it if it is set.

> customizable user agent header for the client
> ---------------------------------------------
>
>                 Key: XMLRPC-149
>                 URL: http
s://issues.apache.org/jira/browse/XMLRPC-149
>             Project: XML-RPC
>          Issue Type: Improvement
>    Affects Versions: 3.1
>         Environment: Gentoo / jdk 1.6
>            Reporter: Andreas Sahlbach
>         Attachments: xmlrpc-ua2.patch
>
>
> Our client sets the user agent to an application string
+ version information. The user agent field can be easily
read out at the web server and is an important information
for the support and for statistics (how many old clients are
still out there? how many customer have upgraded? is it true
that the customer is using the new client or is he really
using an old client, lying somewhere hidden in the
classpath? etc.)
> Now we want to upgrade the xmlrpc lib to 3.1 and
noticed that the user agent field is set by the library.
Unfortunately it's not possible to customize this setting to
our needs. I've added a patch that is allowing us to set the
user agent to a string we are choosing. The code should be
100% compatible and there should be no negative side
effects. Please consider to put this into the upstream as
soon as possible. Thanks a lot!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


Commented: (XMLRPC-149) customizable user agent header for the client
user name
2007-09-27 10:56:50
    [ https://issues.apache.org/jira/browse/
XMLRPC-149?page=com.atlassian.jira.plugin.system.issuetabpan
els:comment-tabpanel#action_12530761 ] 

Andreas Sahlbach commented on XMLRPC-149:
-----------------------------------------

Ok, I see and fully agree. I've attached a new patch in
which I modified the configuration instead. 

> customizable user agent header for the client
> ---------------------------------------------
>
>                 Key: XMLRPC-149
>                 URL: http
s://issues.apache.org/jira/browse/XMLRPC-149
>             Project: XML-RPC
>          Issue Type: Improvement
>    Affects Versions: 3.1
>         Environment: Gentoo / jdk 1.6
>            Reporter: Andreas Sahlbach
>         Attachments: xmlrpc-ua2.patch
>
>
> Our client sets the user agent to an application string
+ version information. The user agent field can be easily
read out at the web server and is an important information
for the support and for statistics (how many old clients are
still out there? how many customer have upgraded? is it true
that the customer is using the new client or is he really
using an old client, lying somewhere hidden in the
classpath? etc.)
> Now we want to upgrade the xmlrpc lib to 3.1 and
noticed that the user agent field is set by the library.
Unfortunately it's not possible to customize this setting to
our needs. I've added a patch that is allowing us to set the
user agent to a string we are choosing. The code should be
100% compatible and there should be no negative side
effects. Please consider to put this into the upstream as
soon as possible. Thanks a lot!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


Commented: (XMLRPC-149) customizable user agent header for the client
user name
2007-10-14 13:27:50
    [ https://issues.apache.org/jira/browse/
XMLRPC-149?page=com.atlassian.jira.plugin.system.issuetabpan
els:comment-tabpanel#action_12534654 ] 

Andreas Sahlbach commented on XMLRPC-149:
-----------------------------------------

Is this ok this way now? 

> customizable user agent header for the client
> ---------------------------------------------
>
>                 Key: XMLRPC-149
>                 URL: http
s://issues.apache.org/jira/browse/XMLRPC-149
>             Project: XML-RPC
>          Issue Type: Improvement
>    Affects Versions: 3.1
>         Environment: Gentoo / jdk 1.6
>            Reporter: Andreas Sahlbach
>         Attachments: xmlrpc-ua2.patch
>
>
> Our client sets the user agent to an application string
+ version information. The user agent field can be easily
read out at the web server and is an important information
for the support and for statistics (how many old clients are
still out there? how many customer have upgraded? is it true
that the customer is using the new client or is he really
using an old client, lying somewhere hidden in the
classpath? etc.)
> Now we want to upgrade the xmlrpc lib to 3.1 and
noticed that the user agent field is set by the library.
Unfortunately it's not possible to customize this setting to
our needs. I've added a patch that is allowing us to set the
user agent to a string we are choosing. The code should be
100% compatible and there should be no negative side
effects. Please consider to put this into the upstream as
soon as possible. Thanks a lot!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.


[1-9]

about | contact  Other archives ( Real Estate discussion Medical topics )