Re: Nit in the AbstractWMFReader

Yeah, stupid me. You're absolutely right. Thanks for
catching that.

Jeremias Maerki



On 07.11.2007 02:02:39 Cameron McCormack wrote:
> Jeremias Maerki:
> > I think I found a bug in AbstractWMFReader. The
methods for
> > getViewportWidthInch() and getViewportHeightInch()
are different. The
> > attached patch should fix this.
> 
> I think it should be the other way around;
getViewportHeightInch()
> should be changed not to multiply by PIXEL_PER_INCH,
since ‘inch’ is the
> number of units per inch and ‘vpW’ is in units. 
Can you confirm this?
> 
> -- 
> Cameron McCormack, http://mcc.id.au/
> 	xmpp:heycamjabber.org  ▪  ICQ 26955922  ▪  MSN
cammcc.id.au


------------------------------------------------------------
---------
To unsubscribe, e-mail: batik-dev-unsubscribexmlgraphics.apache.org
For additional commands, e-mail: batik-dev-helpxmlgraphics.apache.org

I think I found a bug in AbstractWMFReader. The methods for
getViewportWidthInch() and getViewportHeightInch() are
different. The
attached patch should fix this.

Jeremias Maerki

------------------------------------------------------------
---------
To unsubscribe, e-mail: batik-dev-unsubscribexmlgraphics.apache.org
For additional commands, e-mail: batik-dev-helpxmlgraphics.apache.org

Jeremias Maerki:
> I think I found a bug in AbstractWMFReader. The methods
for
> getViewportWidthInch() and getViewportHeightInch() are
different. The
> attached patch should fix this.

I think it should be the other way around;
getViewportHeightInch()
should be changed not to multiply by PIXEL_PER_INCH, since
‘inch’ is the
number of units per inch and ‘vpW’ is in units.  Can you
confirm this?

-- 
Cameron McCormack, http://mcc.id.au/
	xmpp:heycamjabber.org  ▪  ICQ 26955922  ▪  MSN cammcc.id.au

------------------------------------------------------------
---------
To unsubscribe, e-mail: batik-dev-unsubscribexmlgraphics.apache.org
For additional commands, e-mail: batik-dev-helpxmlgraphics.apache.org