Created: (FOR-1052) Add class attributes to the html generated by the FOAF plugin for later C

Add class attributes to the html generated by the FOAF
plugin for later CSS styling
------------------------------------------------------------
-----------------------

                 Key: FOR-1052
                 URL: https:
//issues.apache.org/jira/browse/FOR-1052
             Project: Forrest
          Issue Type: Improvement
          Components: Plugin: input.foaf
            Reporter: stuart yeates
            Priority: Minor


This patch adds class attributes into the html generated by
the FOAF plugin.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.

     [ 
https://issues.apache.org/jira/browse/FOR-1052?page=com.atla
ssian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stuart yeates updated FOR-1052:
-------------------------------

    Attachment: faof-attributes-patch

Patch to add class attributes to the html generated by the
foaf plugin.

> Add class attributes to the html generated by the FOAF
plugin for later CSS styling
>
------------------------------------------------------------
-----------------------
>
>                 Key: FOR-1052
>                 URL: https:
//issues.apache.org/jira/browse/FOR-1052
>             Project: Forrest
>          Issue Type: Improvement
>          Components: Plugin: input.foaf
>            Reporter: stuart yeates
>            Priority: Minor
>         Attachments: faof-attributes-patch
>
>
> This patch adds class attributes into the html
generated by the FOAF plugin.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.

    [ https://issues.apache.org/jira/browse/FO
R-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:
comment-tabpanel#action_12534267 ] 

Ross Gardler commented on FOR-1052:
-----------------------------------

Why are these class attributes so fine grained?

Instead of:

+            <td
class="foaf-mbox_sha1sum-label">Mbox
SH1Sum</td>
+            <td
class="foaf-mbox_sha1sum-value">

...

+            <td
class="foaf-mbox-label">Mbox</td>
+            <td class="foaf-mbox-value">

...

+                <td
class="foaf-knows-label">

etc.

Wouldn't it be better to have:

+            <td class="foaf-label">Mbox
SH1Sum</td>
+            <td class="foaf-value">

What is the purpoose of this class value? is it for styling
only? If so perhaps it would be even better to do:

<table class="foaf-data">
...
<tr>
  <th>MBox SH1 Sum</th>
  <td>[value]</td>
</tr>

Or perhaps, even better would be to using one or more
microformats for this?



> Add class attributes to the html generated by the FOAF
plugin for later CSS styling
>
------------------------------------------------------------
-----------------------
>
>                 Key: FOR-1052
>                 URL: https:
//issues.apache.org/jira/browse/FOR-1052
>             Project: Forrest
>          Issue Type: Improvement
>          Components: Plugin: input.foaf
>            Reporter: stuart yeates
>            Priority: Minor
>         Attachments: faof-attributes-patch
>
>
> This patch adds class attributes into the html
generated by the FOAF plugin.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.

     [ 
https://issues.apache.org/jira/browse/FOR-1052?page=com.atla
ssian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ross Gardler closed FOR-1052.
-----------------------------

       Resolution: Fixed
    Fix Version/s: 0.9-dev
         Assignee: Ross Gardler

Applied with modifications (as discussed on mailing list).

Rather than use individual class elements for each item we
have used a table class element. There is a case for
retaining contextual information via the class,a s Stuart
points out. However, it is felt (at least by me  that it
would be better to use a recognised microformat for this.

Opening a new issue for this.

> Add class attributes to the html generated by the FOAF
plugin for later CSS styling
>
------------------------------------------------------------
-----------------------
>
>                 Key: FOR-1052
>                 URL: https:
//issues.apache.org/jira/browse/FOR-1052
>             Project: Forrest
>          Issue Type: Improvement
>          Components: Plugin: input.foaf
>            Reporter: stuart yeates
>            Assignee: Ross Gardler
>            Priority: Minor
>             Fix For: 0.9-dev
>
>         Attachments: faof-attributes-patch
>
>
> This patch adds class attributes into the html
generated by the FOAF plugin.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue
online.