add_config test

The t/TestAPI/add_config test fails for me on Win32
because the current way of getting the directory in
on line 58 of add_config.pm produces an invalid directory
name on Windows due the the presence of the drive letter.
This diff:

=====================================================
Index: add_config.pm
============================================================
=======
--- add_config.pm	(revision 385119)
+++ add_config.pm	(working copy)
 -3,6
+3,7 
  use strict;
  use warnings FATAL => 'all';

+require File::Spec;
  use Apache2::Access ();
  use Apache2::CmdParms ();
  use Apache2::RequestUtil ();
 -54,7
+55,7 
      $r->pnotes(add_config2 => "$");

      eval {
-        my $directory = join '/', ('',
$r->document_root,
+        my $directory = 
File::Spec::Unix->catfile($r->document_root,
                                    
'TestAPI__add_config');
          $r->add_config(["<Directory
$directory>",
                        'AllowOverride All Options'.$o,

Property changes on: add_config.pm
____________________________________________________________
_______
Name: svn:eol-style
    + native

==========================================================

fixes it for me.

-- 
best regards,
Randy

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribeperl.apache.org
For additional commands, e-mail: dev-helpperl.apache.org

On Sat, 11 Mar 2006, Randy Kobes wrote:

> The t/TestAPI/add_config test fails for me on Win32
> because the current way of getting the directory in
> on line 58 of add_config.pm produces an invalid
directory
> name on Windows due the the presence of the drive
letter.
> This diff:
[ ... ]
> fixes it for me.

That diff does fix the problem for me when the test is 
run once, but in using SMOKE to track down failures
in perl/ithreads*.t when the full test sequence is run, I 
found this sequence:

C:\svn\mp2>perl t/TEST t\api\add_config.t  \
  t\api\lookup_misc.t t\api\aplog.t   \
  t\api\internal_redirect.t t\api\add_config.t

produces a failure when the 2nd t\api\add_config.t is run.
The message is
    t\api\add_config...........# connecting to
     http://loc
alhost:8561/TestAPI__add_config/
     request has failed (the response code was: 500)
but nothing appears in the error log related to this.

I tried this sequence on linux (prefork), but it was OK.

-- 
best regards,
Randy

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribeperl.apache.org
For additional commands, e-mail: dev-helpperl.apache.org

Randy Kobes wrote:
> The t/TestAPI/add_config test fails for me on Win32
> because the current way of getting the directory in
> on line 58 of add_config.pm produces an invalid
directory
> name on Windows due the the presence of the drive
letter.
> This diff:
> 
> =====================================================
> Index: add_config.pm
>
============================================================
=======
> --- add_config.pm	(revision 385119)
> +++ add_config.pm	(working copy)
>  -3,6 +3,7 
>   use strict;
>   use warnings FATAL => 'all';
> 
> +require File::Spec;
>   use Apache2::Access ();
>   use Apache2::CmdParms ();
>   use Apache2::RequestUtil ();
>  -54,7 +55,7 
>       $r->pnotes(add_config2 => "$");
> 
>       eval {
> -        my $directory = join '/', ('',
$r->document_root,
> +        my $directory = 
> File::Spec::Unix->catfile($r->document_root,
>                                     
'TestAPI__add_config');

Wouldn't that be

File::Spec->catfile() ?

>           $r->add_config(["<Directory
$directory>",
>                         'AllowOverride All
Options'.$o,
> 

------------------------------------------------------------
--------------------
Philippe M. Chiasson m/gozer\(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.or
g/     F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5

On Mon, 13 Mar 2006, Philippe M. Chiasson wrote:

> Randy Kobes wrote:
>> The t/TestAPI/add_config test fails for me on Win32
>> because the current way of getting the directory in
>> on line 58 of add_config.pm produces an invalid
directory
>> name on Windows due the the presence of the drive
letter.
>> This diff:
>>
>>
=====================================================
>> Index: add_config.pm
>>
============================================================
=======
>> --- add_config.pm	(revision 385119)
>> +++ add_config.pm	(working copy)
>>  -3,6 +3,7 
>>   use strict;
>>   use warnings FATAL => 'all';
>>
>> +require File::Spec;
>>   use Apache2::Access ();
>>   use Apache2::CmdParms ();
>>   use Apache2::RequestUtil ();
>>  -54,7 +55,7 
>>       $r->pnotes(add_config2 => "$");
>>
>>       eval {
>> -        my $directory = join '/', ('',
$r->document_root,
>> +        my $directory =
>> File::Spec::Unix->catfile($r->document_root,
>>                                     
'TestAPI__add_config');
>
> Wouldn't that be
>
> File::Spec->catfile() ?

Unfortunately, if one did use that on Windows here, then
the '\' directory separator used would lead to
problems in

>>           $r->add_config(["<Directory
$directory>",
>>                         'AllowOverride All
Options'.$o,
>>

as it would think characters following the '\' were
meant to be escaped. One could then fix that up, but
I thought using File::Spec::Unix would be simpler.

-- 
best regards,
Randy

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribeperl.apache.org
For additional commands, e-mail: dev-helpperl.apache.org