-------- Original Message --------
Subject: MP2: Patch to fix dynamic loading under OpenBSD
(Was: Patches
for two problems under OpenBSD)
Date: Sun, 10 Jun 2007 20:38:53 +0200
From: Simon Bertrang <januserrornet.de>
To: modperlperl.apache.org
References: <20070609182229.GD2049codefish>

On Sat, Jun 09, 2007 at 08:22:30PM +0200, Simon Bertrang
wrote:
> Hi,
> when porting libapreq2 to OpenBSD we noticed a problem
with a workaround
> that doesn't apply anymore (APR.pm):
> 
> $OpenBSD: patch-xs_APR_APR_APR_pm,v 1.1 2007/06/09
16:02:04 martynas Exp $
> --- xs/APR/APR/APR.pm.orig	Mon Nov 20 01:31:02 2006
> +++ xs/APR/APR/APR.pm	Sat Jun  9 18:10:04 2007
>  -23,7 +23,7  our ISA = qw(DynaLoader);
>  # XXX: see xs/ModPerl/Const/Const.pm for issues of
using 0x01
>  use Config ();
>  use constant DL_GLOBAL =>
> -  ( $Config::Config eq 'dl_dlopen.xs'
&& $^O ne 'openbsd' ) ? 0x01 : 0x0;
> +  ( $Config::Config eq 'dl_dlopen.xs' ) ? 0x01
: 0x0;
>  sub dl_load_flags 
>  
>  unless (defined &APR::XSLoader::BOOTSTRAP) {
> 

Here's a diff against svn.
The second thing from my previous mail is fixed already as
told by
Jonathan Vanasco.

Regards,
Simon

Index: xs/APR/APR/APR.pm
============================================================
=======
--- xs/APR/APR/APR.pm	(revision 545917)
+++ xs/APR/APR/APR.pm	(working copy)
 -23,7
+23,7 
 # XXX: see xs/ModPerl/Const/Const.pm for issues of using
0x01
 use Config ();
 use constant DL_GLOBAL =>
-  ( $Config::Config eq 'dl_dlopen.xs' && $^O
ne 'openbsd' ) ?
0x01 : 0x0;
+  ( $Config::Config eq 'dl_dlopen.xs' ) ? 0x01 :
0x0;
 sub dl_load_flags 

 unless (defined &APR::XSLoader::BOOTSTRAP) {

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribeperl.apache.org
For additional commands, e-mail: dev-helpperl.apache.org

Geoffrey Young wrote:
> -------- Original Message --------
> Subject: MP2: Patch to fix dynamic loading under
OpenBSD (Was: Patches
> for two problems under OpenBSD)
> Date: Sun, 10 Jun 2007 20:38:53 +0200
> From: Simon Bertrang <januserrornet.de>
> To: modperlperl.apache.org
> References: <20070609182229.GD2049codefish>
> 
> On Sat, Jun 09, 2007 at 08:22:30PM +0200, Simon
Bertrang wrote:
>> Hi,
>> when porting libapreq2 to OpenBSD we noticed a
problem with a workaround
>> that doesn't apply anymore (APR.pm):

Since what release of OpenBSD does this fix become
irrelevant ?

>> $OpenBSD: patch-xs_APR_APR_APR_pm,v 1.1 2007/06/09
16:02:04 martynas Exp $
>> --- xs/APR/APR/APR.pm.orig	Mon Nov 20 01:31:02
2006
>> +++ xs/APR/APR/APR.pm	Sat Jun  9 18:10:04 2007
>>  -23,7 +23,7  our ISA = qw(DynaLoader);
>>  # XXX: see xs/ModPerl/Const/Const.pm for issues of
using 0x01
>>  use Config ();
>>  use constant DL_GLOBAL =>
>> -  ( $Config::Config eq 'dl_dlopen.xs'
&& $^O ne 'openbsd' ) ? 0x01 : 0x0;
>> +  ( $Config::Config eq 'dl_dlopen.xs' ) ?
0x01 : 0x0;
>>  sub dl_load_flags 
>>  
>>  unless (defined &APR::XSLoader::BOOTSTRAP) {
>>

Is it safe enough to assume the older affected OpenBSDs
versions have
all upgraded ? Or wouldn't it be easier to do someting like
include
detection of the affected versions, and keep it working in
both cases ?

------------------------------------------------------------
------------
Philippe M. Chiasson     GPG: F9BFE0C2480E7680
1AE53631CB32A107 88C3A5A5
http://gozer.ectoplasm.or
g/       m/gozer(apache|cpan|ectoplasm).org/

Philippe M. Chiasson wrote:
> Geoffrey Young wrote:
>> -------- Original Message --------
>> Subject: MP2: Patch to fix dynamic loading under
OpenBSD (Was: Patches
>> for two problems under OpenBSD)
>> Date: Sun, 10 Jun 2007 20:38:53 +0200
>> From: Simon Bertrang <januserrornet.de>
>> To: modperlperl.apache.org
>> References: <20070609182229.GD2049codefish>
>>
>> On Sat, Jun 09, 2007 at 08:22:30PM +0200, Simon
Bertrang wrote:
>>> Hi,
>>> when porting libapreq2 to OpenBSD we noticed a
problem with a workaround
>>> that doesn't apply anymore (APR.pm):
> 
> Since what release of OpenBSD does this fix become
irrelevant ?

probably a question better suited to Simon or the bsd folks
- I was just
forwarding it here from modperl so it didn't get lost 

--Geoff

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribeperl.apache.org
For additional commands, e-mail: dev-helpperl.apache.org