svn commit: r412973 - /perl/modperl/trunk/ModPerl-Registry/t/fatalstobrowser.t

>  plan tests => 4, need need_module(qw(alias)),
>                        need_cgi,
> -                      need_min_module_version CGI
=> 3.16,
> +                      need_min_module_version CGI
=> 3.21,
>                        skip_reason('fatalsToBrowser
known not to work');

I wrote that, but I'm not at all sure it makes sense now...

say it's fixed in 3.21 - the test will still skip.  and
we'll get one
_less_ message, not one more reminding us to try the test
again...

anyone have a better solution?

--Geoff

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribeperl.apache.org
For additional commands, e-mail: dev-helpperl.apache.org

Geoffrey Young wrote:
>>  plan tests => 4, need need_module(qw(alias)),
>>                        need_cgi,
>> -                      need_min_module_version CGI
=> 3.16,
>> +                      need_min_module_version CGI
=> 3.21,
>>                       
skip_reason('fatalsToBrowser known not to work');
True, its one of _very_ few tests we skip with all the
relevant modules 
installed and an ithread enabled perl, so it jumped out at
me, and I 
upgraded CGI to get it to fire.

maybe a TODO: { local $TODO = '' } variant ?

I did some digging into the bug a good 4-6 months ago, and
ended up 
confusing myself horribly; thus, not posting anything to the
list(s) 
because I wasn't quite sure what I was trying to say or
point to as 
being at fault.

I vaguely remember it being something I thought I could fix
and 
contribute back to CGI.pm, but I've totally forgotten now.
Its related to doing whacky stuff to the $SIG{}s and turning
warnings 
into fatals inside an eval{} buring somewhere in ModPerl::
... Probably 
Cooker.pm




-- 
------------------------------------------------------------
------------
Philip M. Gollucci (pgolluccip6m7g8.com) 323.219.4708
Consultant / http://p6m7g8.n
et/Resume/resume.shtml
Senior Software Engineer - TicketMaster - http://ticketmaster.com
1024D/A79997FA F357 0FDD 2301 6296 690F  6A47 D55A 7172 A799
97F

"It takes a minute to have a crush on someone, an hour
to like someone,
and a day to love someone, but it takes a lifetime to forget
someone..."

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribeperl.apache.org
For additional commands, e-mail: dev-helpperl.apache.org