SpeakerNPC and Behaviours

Hi,

today I ran into a very annoying bug (1506178). I figured
out that the
easiest way to fix it was to get rid of Behaviours.java, a
step that I
already wanted to take earlier.

Miguel: I know that you created Behaviours.java to make
SpeakerNPC a
little bit smaller. I understand that SpeakerNPC is a little
large, but
from an object-oriented point of view, Behaviours was really
horrible.
In fact, it wasn't object-oriented at all; it only
consisted of static
methods. So please don't be angry that I refactored it; the
methods are
now all back in SpeakerNPC. The resulting code is hopefully
easier readable.

I will do some more testing tomorrow, but as far as I can
see,
everything works again, including the healing.


Daniel


_______________________________________________
Arianne-devel mailing list
Arianne-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/arianne-d
evel

hi,
well if we have to test SpeakerNPC now anyways ;) I figured
this  
might be a good time to commit an additional change to  
SpeakerNPC.logic() which is not yet a major breakthrough in 

performance but should help a little and makes the code of
that  
function a little easier to understand. I also commented out
 
duplicate code in tell() for timed out conversations which
were  
already treated in logic.
regards,
Jo

Am 15.06.2006 um 02:14 schrieb Daniel Herding:

> Hi,
>
> today I ran into a very annoying bug (1506178). I
figured out that the
> easiest way to fix it was to get rid of
Behaviours.java, a step that I
> already wanted to take earlier.
>
> Miguel: I know that you created Behaviours.java to make
SpeakerNPC a
> little bit smaller. I understand that SpeakerNPC is a
little large,  
> but
> from an object-oriented point of view, Behaviours was
really horrible.
> In fact, it wasn't object-oriented at all; it only
consisted of static
> methods. So please don't be angry that I refactored
it; the methods  
> are
> now all back in SpeakerNPC. The resulting code is
hopefully easier  
> readable.
>
> I will do some more testing tomorrow, but as far as I
can see,
> everything works again, including the healing.
>
>
> Daniel
>
>
> _______________________________________________
> Arianne-devel mailing list
> Arianne-devellists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/arianne-d
evel
>



_______________________________________________
Arianne-devel mailing list
Arianne-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/arianne-d
evel

>today I ran into a very annoying bug (1506178). I
figured out that the
>easiest way to fix it was to get rid of Behaviours.java,
a step that I
>already wanted to take earlier.
>
>Miguel: I know that you created Behaviours.java to make
SpeakerNPC a
>little bit smaller. I understand that SpeakerNPC is a
little large, but
>from an object-oriented point of view, Behaviours was
really horrible.
>In fact, it wasn't object-oriented at all; it only
consisted of static
>methods. So please don't be angry that I refactored it;
the methods are
>now all back in SpeakerNPC. The resulting code is
hopefully easier 
>readable.

Ok, no problem.
But I really see no direct relation between the bug and the
behaviours 
class.
Anyway... if it works 

Regards,
Miguel




_______________________________________________
Arianne-devel mailing list
Arianne-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/arianne-d
evel