Little modification in app_mysql.c

Hello *,
I've added a few lines to app_mysql.c, in order to see in
the Asterisk
log the exact mysql error when the query fails.

I'd like to see this little patch in the next version of
asterisk-addons, because I think this is a really useful
addition to
the addon.

What should I do? Should I send the patch here or should I
file a bug
somewhere?

Thanks in advance,

-- 
Andrea Spadaccini
Multimedia Technologies Institute s.r.l.
_______________________________________________
--Bandwidth and Colocation provided by Easynews.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

In article <20060830145727.43ed5c84iridiumIII>,
Andrea Spadaccini <a.spadaccinimediatechnologies.it>
wrote:
> Hello *,
> I've added a few lines to app_mysql.c, in order to see
in the Asterisk
> log the exact mysql error when the query fails.
> 
> I'd like to see this little patch in the next version
of
> asterisk-addons, because I think this is a really
useful addition to
> the addon.
> 
> What should I do? Should I send the patch here or
should I file a bug
> somewhere?

File it at http://bugs.digium.com

Cheers
Tony
-- 
Tony Mountifield
Work: tonysoftins.co.uk - http://www.softins.co.uk
Play: tonymountifield.org - http://tony.mountifield.o
rg
_______________________________________________
--Bandwidth and Colocation provided by Easynews.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

On Wednesday 30 August 2006 07:57, Andrea Spadaccini wrote:
> Hello *,
> I've added a few lines to app_mysql.c, in order to see
in the
> Asterisk log the exact mysql error when the query
fails.
>
> I'd like to see this little patch in the next version
of
> asterisk-addons, because I think this is a really
useful addition
> to the addon.
>
> What should I do? Should I send the patch here or
should I file a
> bug somewhere?

http://bugs.digium.com. 
Since this is for -addons, a disclaimer is
not strictly needed, but you should probably file one
anyway.  The
links to the disclaimers are on the Main page.

-- 
Tilghman
_______________________________________________
--Bandwidth and Colocation provided by Easynews.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

----- Tilghman Lesher <tilghmanmail.jeffandtilghman.com> wrote:
> http://bugs.digium.com. 
Since this is for -addons, a disclaimer is
> not strictly needed, but you should probably file one
anyway.  The
> links to the disclaimers are on the Main page.

This is incorrect. Disclaimers are needed for all
contributions to Asterisk, Asterisk-Addons, libpri and
Zaptel (and possibly other projects, this is not an
all-inclusive list).

-- 
Kevin P. Fleming
Senior Software Engineer
Digium, Inc.

_______________________________________________
--Bandwidth and Colocation provided by Easynews.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Ciao Kevin,

> Disclaimers are needed for all contributions to
Asterisk,
> Asterisk-Addons, libpri and Zaptel (and possibly other
projects, this
> is not an all-inclusive list).

So without a disclaimer my code is likely to be ignored? :(

-- 
Andrea Spadaccini
Multimedia Technologies Institute s.r.l.
_______________________________________________
--Bandwidth and Colocation provided by Easynews.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

On Wed, 2006-08-30 at 17:19 +0200, Andrea Spadaccini wrote:
> Ciao Kevin,
> 
> > Disclaimers are needed for all contributions to
Asterisk,
> > Asterisk-Addons, libpri and Zaptel (and possibly
other projects, this
> > is not an all-inclusive list).
> 
> So without a disclaimer my code is likely to be
ignored? :(

It is highly likely it would get ignored if you do not file
a
disclaimer. 

The problem comes down to that of copyright. If you put your
fix out
there, and another person wrote essentially the same patch
but had read
your code, it could be claimed they were tainted by reading
your code.
This could call into question the true ownership of the
finally accepted
code. 

So, when we adhere to best practises with regard to
copyright and
software licenses, it is better to ignore a chunk of code
than to get
hammered on it later.
-- 
Steven Critchfield <critchbasesys.com>

_______________________________________________
--Bandwidth and Colocation provided by Easynews.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

----- Andrea Spadaccini <a.spadaccinimediatechnologies.it> wrote:
> So without a disclaimer my code is likely to be
ignored? :(

Not likely, guaranteed. We do not look at undisclaimed code
for copyright and other licensing reasons, and in the near
future you would not even be able to upload a code
submission (and mark it as such) without a license agreement
already on file.

-- 
Kevin P. Fleming
Senior Software Engineer
Digium, Inc.

_______________________________________________
--Bandwidth and Colocation provided by Easynews.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

30 aug 2006 kl. 17.37 skrev Kevin P. Fleming:

> ----- Andrea Spadaccini <a.spadaccinimediatechnologies.it> wrote:
>> So without a disclaimer my code is likely to be
ignored? :(
>
> Not likely, guaranteed. We do not look at undisclaimed
code for  
> copyright and other licensing reasons, and in the near
future you  
> would not even be able to upload a code submission (and
mark it as  
> such) without a license agreement already on file.

To clarify a bit:

Without a disclaimer on file, your code will not be used in
the  
asterisk.org distribution managed by Digium.

You can still distribute it and there are plenty of
additions and  
patches for Asterisk out there on sourceforge
pbxfreeware.org and other sites that are distributed under
GPL.

/Olle
_______________________________________________
--Bandwidth and Colocation provided by Easynews.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

>> ----- Andrea Spadaccini <a.spadaccinimediatechnologies.it> wrote:
>>> So without a disclaimer my code is likely to be
ignored? :(
>>
>> Not likely, guaranteed. We do not look at
undisclaimed code for  
>> copyright and other licensing reasons, and in the
near future you  
>> would not even be able to upload a code submission
(and mark it as  
>> such) without a license agreement already on file.
>
> To clarify a bit:
>
> Without a disclaimer on file, your code will not be
used in the  
> asterisk.org distribution managed by Digium.
>
> You can still distribute it and there are plenty of
additions and  
> patches for Asterisk out there on sourceforge
> pbxfreeware.org and other sites that are distributed
under GPL.

But the asterisk-addons package is there for the sole reason
that the  
code in there cannot go into asterisk, right? Why, then,
will digium  
force this?

roy

--
Roy Sigurd Karlsbakk
roykarlsbakk.net
(+47) 98013356
---
In space, loud sounds, like explosions, are even louder
because there  
is no air to get in the way.


_______________________________________________
--Bandwidth and Colocation provided by Easynews.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

30 aug 2006 kl. 19.28 skrev Roy Sigurd Karlsbakk:

>>> ----- Andrea Spadaccini <a.spadaccinimediatechnologies.it> wrote:
>>>> So without a disclaimer my code is likely
to be ignored? :(
>>>
>>> Not likely, guaranteed. We do not look at
undisclaimed code for  
>>> copyright and other licensing reasons, and in
the near future you  
>>> would not even be able to upload a code
submission (and mark it  
>>> as such) without a license agreement already on
file.
>>
>> To clarify a bit:
>>
>> Without a disclaimer on file, your code will not be
used in the  
>> asterisk.org distribution managed by Digium.
>>
>> You can still distribute it and there are plenty of
additions and  
>> patches for Asterisk out there on sourceforge
>> pbxfreeware.org and other sites that are
distributed under GPL.
>
> But the asterisk-addons package is there for the sole
reason that  
> the code in there cannot go into asterisk, right? Why,
then, will  
> digium force this?

I think Kevin or Mark has to answer this, but I think that
the - 
addons code is still disclaimed, but isn't compatible
with the commercial licensing due to licenses in other Open
Source  
packages. I don't think that addons contains
code that is not disclaimed to Digium.

I would appreciate a clarification on this from Digium!

/Olle


---
Olle E. Johansson * Asterisk Evangelist, developer * VOOP
A/S
ollevoop.com



_______________________________________________
--Bandwidth and Colocation provided by Easynews.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev