Update coding guidelines

Array
Array
Array
Array
Array
On Sun, Dec 31, 2006 at 08:50:30AM +0100, SF Markus Elfring
wrote:

> >Could you please point to one specific place in the
code?
> >  
> Would you like to look at the variable variations like
"app", "synopsis" 
> and "descrip"?
> Use cases:
> http://svn.digium.co
m/view/asterisk/trunk/apps/app_alarmreceiver.c?rev=46339&
;view=markup
> http://svn.digium.com/view/as
terisk/trunk/apps/app_skel.c?rev=40722&view=markup
> http://asterisk.org/doxygen/1.4/pbx_
8h.html#b58400cbaac5b16c9ca258339394f3c1

So I guess that the question to ask here is: is there is
actually any
use to those variables being non-const? Is there any
application that
has some use of changing the description on reload?

I cannot recall any such use. I believe that in this case
patches for
adding the const would be welcomed. Though this is just MHO.
Have you
added there const-s where necessary and verified all to
still compile?

BTW: is there really a point to the following disclaimer on
the
documentation of app_alarmreceiver.c:

  * *** WARNING *** WARNING *** WARNING *** WARNING ***
WARNING *** WARNING *** WARNING *** WARNING *** 
  *
  * Use at your own risk. Please consult the GNU GPL license
document included with Asterisk.         *
  *
  * *** WARNING *** WARNING *** WARNING *** WARNING ***
WARNING *** WARNING *** WARNING *** WARNING ***

-- 
               Tzafrir Cohen       
icq#16849755                    jabber:tzafrirjabber.org
+972-50-7952406           mailto:tzafrir.cohenxorcom.com       
http://www.xorcom.com 
iax:guestlocal.xorcom.com/tzafrir
_______________________________________________
--Bandwidth and Colocation provided by Easynews.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Tzafrir Cohen wrote:
> I cannot recall any such use. I believe that in this
case patches for
> adding the const would be welcomed. Though this is just
MHO. Have you
> added there const-s where necessary and verified all to
still compile?

In fact, creating and testing said patch would probably have
taken less
time than posting the questions with dozens of hyperlinks to
this
mailing list did.

> BTW: is there really a point to the following
disclaimer on the
> documentation of app_alarmreceiver.c:
> 
>   * *** WARNING *** WARNING *** WARNING *** WARNING ***
WARNING *** WARNING *** WARNING *** WARNING *** 
>   *
>   * Use at your own risk. Please consult the GNU GPL
license document included with Asterisk.         *
>   *
>   * *** WARNING *** WARNING *** WARNING *** WARNING ***
WARNING *** WARNING *** WARNING *** WARNING ***

Yes, there is. People using that module should be made
explicitly aware
of the lack of warranty associated with Asterisk; in fact,
I'd prefer to
see that message displayed on the console when the module is
loaded, and
again the first time the application is called. That
application is used
for receiving alarm calls from security/life safety
systems... the lack
of warranty needs to be well understood by its users.
_______________________________________________
--Bandwidth and Colocation provided by Easynews.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Update coding guidelines

Thread: Update coding guidelines