Re: rizzo: trunk r72700 - /trunk/main/Makefile

SVN commits to the Digium repositories wrote:
> Author: rizzo
> Date: Fri Jun 29 15:33:35 2007
> New Revision: 72700
> 
> URL: http://svn.digium.com/view/asterisk?view=rev&rev=7
2700
> Log:
> Make sure that we properly recurse in subdirectories
to
> check dependencies for libraries.
> Because these targets (e.g. minimime/libmmime.a) are
real ones,
> declaring them .PHONY would cause them to be rebuilt
every time
> (see e.g. SVN 64355).
> 
> As a workaround I am using the following CHECK_SUBDIR
target:
> 
>   CHECK_SUBDIR:  # do nothing, just make sure that we
recurse in the subdir/
>   minimime/libmmime.a: CHECK_SUBDIR
> 	cd minimime && $(MAKE) libmmime.a
> 
> which seems to do a better job than .PHONY (probably
because
> .PHONY forces the rebuild even if the recursive make
does not think
> it is necessary).

Hm, this is interesting.  I have always thought that
declaring a target
as .PHONY did the exact same thing as what this method does.
 In fact,
the GNU make manual claims they do the same thing.

http://www.gnu.org/software/ma
ke/manual/html_node/Force-Targets.html#Force-Targets

-- 
Russell Bryant
Software Engineer
Digium, Inc.

_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.c
om--

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

On Fri, Jun 29, 2007 at 03:49:58PM -0500, Russell Bryant
wrote:
> SVN commits to the Digium repositories wrote:
> > Author: rizzo
> > Date: Fri Jun 29 15:33:35 2007
> > New Revision: 72700
> > 
> > URL: http://svn.digium.com/view/asterisk?view=rev&rev=7
2700
> > Log:
> > Make sure that we properly recurse in
subdirectories to
> > check dependencies for libraries.
> > Because these targets (e.g. minimime/libmmime.a)
are real ones,
> > declaring them .PHONY would cause them to be
rebuilt every time
> > (see e.g. SVN 64355).
> > 
> > As a workaround I am using the following
CHECK_SUBDIR target:
> > 
> >   CHECK_SUBDIR:  # do nothing, just make sure that
we recurse in the subdir/
> >   minimime/libmmime.a: CHECK_SUBDIR
> > 	cd minimime && $(MAKE) libmmime.a
> > 
> > which seems to do a better job than .PHONY
(probably because
> > .PHONY forces the rebuild even if the recursive
make does not think
> > it is necessary).
> 
> Hm, this is interesting.  I have always thought that
declaring a target
> as .PHONY did the exact same thing as what this method
does.  In fact,
> the GNU make manual claims they do the same thing.
> 
> http://www.gnu.org/software/ma
ke/manual/html_node/Force-Targets.html#Force-Targets

I think the last sentence in the above manpage is wrong and
the two things
are actually different (in fact, if you try, they do behave
differently
if the target is a real file). If you read the .PHONY page

http://www.gnu.org/software/ma
ke/manual/html_node/Phony-Targets.html#Phony-Targets

it says that .PHONY targets should not be real files, and i
bet that internally
gmake uses this assumption to imply that the target is not
just _possibly_ out
of date, but it _must_ be rebuilt.

Anyways, FORCE might be a better name than CHECK_SUBDIR for
the fake target.

	cheers
	luigi

_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.c
om--

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

At least on FreeBSD, i need this patch to get a clean
AST_DEVMODE build.
I know that there might be different version for iconv(), so
can
someone let me know if this patch breaks anything on linux
?

Index: funcs/func_iconv.c
============================================================
=======
--- funcs/func_iconv.c  (revision 72740)
+++ funcs/func_iconv.c  (working copy)
 -82,7
+82,7 
                return -1;
        }
 
-       if (iconv(cd, &args.text, &incount,
&buf, &outcount) == (size_t) -1) {
+       if (iconv(cd, (const char **)&args.text,
&incount, &buf, &outcount) == (size_t) -1) {
                if (errno == E2BIG)
                        ast_log(LOG_WARNING, "Iconv:
output buffer too small.n");
                else if (errno == EILSEQ)


thanks
luigi

_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.c
om--

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev