portaudio & portmixer patches - patch 3

Changes in portmixer. We use open mixers separately for
WinMM and DS now, as for 
WinMM, we actually supply a mixer ID, not wavein/waveout ID,
while for DS we 
supply wavein/waveout ID. Another possibility would be to
convert 
hwavein/hwaveout to just wavein/waveout ID. This change also
required moving 
static initialize and cleanup functions to the beginning of
files, and making 
them nonstatic in px_win_common.c.

With this change, setting mic/speaker volume works for both
WinMM and DS driver.

Without it, on some sound cards either for winMM or DS
volume couldn't be set, 
as the logic in portmixer when using mixerOpen was wrong
(once we got mixer ID, 
and 2nd time wavein/waveout ID).

Some code was moved to other files. I didn't test it for
other platforms than 
windows, so check that code is still compilable.

Jaro

------------------------------------------------------------
-------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Audacity-devel mailing list
Audacity-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/audacity
-devel

On Sat, 2008-01-19 at 00:43 +0100, Jaroslav Libak wrote:
> Changes in portmixer. We use open mixers separately for
WinMM and DS now, as for 
> WinMM, we actually supply a mixer ID, not
wavein/waveout ID, while for DS we 
> supply wavein/waveout ID. Another possibility would be
to convert 
> hwavein/hwaveout to just wavein/waveout ID. This change
also required moving 
> static initialize and cleanup functions to the
beginning of files, and making 
> them nonstatic in px_win_common.c.
> 
> With this change, setting mic/speaker volume works for
both WinMM and DS driver.
> 
> Without it, on some sound cards either for winMM or DS
volume couldn't be set, 
> as the logic in portmixer when using mixerOpen was
wrong (once we got mixer ID, 
> and 2nd time wavein/waveout ID).
> 
> Some code was moved to other files. I didn't test it
for other platforms than 
> windows, so check that code is still compilable.

This patch was very hard to make sense of, because there
were lots of
places where functions were deleted from one place in a file
and
re-inserted somewhere else. Distilling out the bits that are
actually
significant gives me two short patches.

The first simply moves two function declarations from the .c
file into
the associated .h file, which seems logical enough.

The second is presumably the one that you are describing in
your email.
It looks plausible, with the relevant function from
px_win_common.c
being removed and two implementations put into the relevant
files. I
don't have a windows install to test on, but I'll try and
get someone
else to test it in audacity.

Richard

------------------------------------------------------------
-------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Audacity-devel mailing list
Audacity-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/audacity
-devel

Are there any plans for audacity to use the latest portaudio
V19? I know it used 
  older version in november 2007, and the patch for
portmixer didn't apply 
cleanly anymore for the november V19 version. I could
theoretically supply a 
patch for the november V19 version.

Jaro

Richard Ash wrote:
> On Sat, 2008-01-19 at 00:43 +0100, Jaroslav Libak
wrote:
>> Changes in portmixer. We use open mixers separately
for WinMM and DS now, as for 
>> WinMM, we actually supply a mixer ID, not
wavein/waveout ID, while for DS we 
>> supply wavein/waveout ID. Another possibility would
be to convert 
>> hwavein/hwaveout to just wavein/waveout ID. This
change also required moving 
>> static initialize and cleanup functions to the
beginning of files, and making 
>> them nonstatic in px_win_common.c.
>>
>> With this change, setting mic/speaker volume works
for both WinMM and DS driver.
>>
>> Without it, on some sound cards either for winMM or
DS volume couldn't be set, 
>> as the logic in portmixer when using mixerOpen was
wrong (once we got mixer ID, 
>> and 2nd time wavein/waveout ID).
>>
>> Some code was moved to other files. I didn't test
it for other platforms than 
>> windows, so check that code is still compilable.
> 
> This patch was very hard to make sense of, because
there were lots of
> places where functions were deleted from one place in a
file and
> re-inserted somewhere else. Distilling out the bits
that are actually
> significant gives me two short patches.
> 
> The first simply moves two function declarations from
the .c file into
> the associated .h file, which seems logical enough.
> 
> The second is presumably the one that you are
describing in your email.
> It looks plausible, with the relevant function from
px_win_common.c
> being removed and two implementations put into the
relevant files. I
> don't have a windows install to test on, but I'll try
and get someone
> else to test it in audacity.
> 
> Richard
> 
> 
>
------------------------------------------------------------
------------
> 
>
------------------------------------------------------------
-------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> 
> 
>
------------------------------------------------------------
------------
> 
> _______________________________________________
> Audacity-devel mailing list
> Audacity-devellists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/audacity
-devel


------------------------------------------------------------
-------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Audacity-devel mailing list
Audacity-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/audacity
-devel

On Sat, 2008-01-19 at 21:25 +0100, Jaroslav Libak wrote:
> Are there any plans for audacity to use the latest
portaudio V19?
It is, right now, using the SVN HEAD version from portaudio
v19 SVN.
Both the portaudio snapshot and the patch have been updated
updated in
the last three months.

What I'm trying to get a sense of is why your patch makes
hundreds of
lines of changes before I try and integrate any of them into
our CVS for
testing.

Richard Ash

> Richard Ash wrote:
> > On Sat, 2008-01-19 at 00:43 +0100, Jaroslav Libak
wrote:
> >> Changes in portmixer. We use open mixers
separately for WinMM and DS now, as for 
> >> WinMM, we actually supply a mixer ID, not
wavein/waveout ID, while for DS we 
> >> supply wavein/waveout ID. Another possibility
would be to convert 
> >> hwavein/hwaveout to just wavein/waveout ID.
This change also required moving 
> >> static initialize and cleanup functions to the
beginning of files, and making 
> >> them nonstatic in px_win_common.c.
> >>
> >> With this change, setting mic/speaker volume
works for both WinMM and DS driver.
> >>
> >> Without it, on some sound cards either for
winMM or DS volume couldn't be set, 
> >> as the logic in portmixer when using mixerOpen
was wrong (once we got mixer ID, 
> >> and 2nd time wavein/waveout ID).
> >>
> >> Some code was moved to other files. I didn't
test it for other platforms than 
> >> windows, so check that code is still
compilable.
> > 
> > This patch was very hard to make sense of, because
there were lots of
> > places where functions were deleted from one place
in a file and
> > re-inserted somewhere else. Distilling out the
bits that are actually
> > significant gives me two short patches.
> > 
> > The first simply moves two function declarations
from the .c file into
> > the associated .h file, which seems logical
enough.
> > 
> > The second is presumably the one that you are
describing in your email.
> > It looks plausible, with the relevant function
from px_win_common.c
> > being removed and two implementations put into the
relevant files. I
> > don't have a windows install to test on, but I'll
try and get someone
> > else to test it in audacity.
> > 
> > Richard
> > 
> > 
> >
------------------------------------------------------------
------------
> > 
> >
------------------------------------------------------------
-------------
> > This SF.net email is sponsored by: Microsoft
> > Defy all challenges. Microsoft(R) Visual Studio
2008.
> > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> > 
> > 
> >
------------------------------------------------------------
------------
> > 
> > _______________________________________________
> > Audacity-devel mailing list
> > Audacity-devellists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/audacity
-devel
> 


------------------------------------------------------------
-------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Audacity-devel mailing list
Audacity-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/audacity
-devel