List Info

Thread: Re: Export multiple colon wrongly accepted as legal character




Re: Export multiple colon wrongly accepted as legal character
country flaguser name
United Kingdom
2008-01-19 03:53:41
| From Martyn Shaw <martynshaw99googlemail.com> 
| Sat, 19 Jan 2008 00:14:12 +0000
| Subject: [Audacity-devel] Export multiple colon wrongly
accepted as
| legal character
> Gale Andrews wrote:
> ...
> >>       
name.Replace(wxT("|"),wxT("_"));
> > 
> > Martyn
> > 
> > ...  Won't it mean
> > though that Mac/Linux users are going to get half
a dozen or so 
> > characters replaced where they don't need to be
replaced e.g. "?" on
> > Mac?  Yes it means the file names are portable,
but I would not 
> > expect it to be a "popular" move. No
doubt the current fix is better 
> > than what we have now for Windows users. 
> 
> Yes, it was just a trial.  We will have to do some
differences for 
> each OS - just a different set of illegal chars at
compile time.

Fine with me... 

> > I do think an informative error (the same error,
irrespective of the
> > format exported to) and no export would be the
best option of all.
> > This is (I think) what we were actually intending
to happen. If we do 
> > that, it might be better if the export cycle never
started. As it was
> > before (i.e. for WAV/AIFF), export proceeds until
a label with an
> > illegal character is found, then stops.  
> 
> Here's another idea:
> 1 Proceed until an illegal name is found.
> 2 Change the name to a legal one.
> 3 Pop up a dialog box with the suggested legal name so
it can be 
> edited, only allowing legal chars.
> 4 Cancel stops the rest of the export.
> 
> I have put another zip at http://mjshaw
.at-uclan.com/audacity.zip to 
> see if you like it.  Wording may change in dialog.

Yes I do like it, as long as we explain it properly in the
dialog. In
many ways it's better than a fixed generic error, and I'm
reading
between the lines that it's less messing with the code than
stopping 
the export starting at all? 

I'm a bit nervous that because it's a dialog we'll only
allow ourselves
five words though. Can the illegal characters we decide on
for each 
OS be passed into the dialog so they know what they can't
put in the 
label (or some other easy way to be OS-specific about them)?
 I did 
notice you've disallowed typing in the illegal characters in
the dialog,
but if a novice is convinced he must be able to type
"?" like he can 
in Wordpad, he could still be confused. And I think we
perhaps ought 
to say that the actual labels won't change, as I suspect
people may 
think that they will.  

Or, should we link in the dialog to 
http://audacityteam
.org/wiki/index.php?title=Splitting_recordings_into_separate
_tracks#Labels

instead of attempting to explain very much? Obviously the
content of
that page can easily be changed to take into account the
current
behaviour. Either way, I'd think 9 -12 words (plus the
illegal characters
themselves) would suffice. 
 

Thanks

Gale 




------------------------------------------------------------
-------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Audacity-devel mailing list
Audacity-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/audacity
-devel

[1]

about | contact  Other archives ( Real Estate discussion Medical topics )