Re: Is this really an Essential change?

| From Martyn Shaw <martynshaw99googlemail.com> 
| Tue, 22 Jan 2008 00:48:40 +0000
| Subject: [Audacity-devel] Is this really an Essential
change?
> > I think this may have happened de facto now. As I
look at the source, it
> > seems that checkbox doesn't do anything at all,
ever. There are only two
> > references to the preference, on in the preference
dialogue and one in
> > Project.cpp, where it is read and used to set a
variable which is then
> > not used, except by get and set methods. Those
methods are only called
> > in one place, which is in BatchCommands.cpp, where
they are used once to
> > save and restore the state of the flag round
something else that doesn't
> > seem to modify it.....
> > 
> > Unfortunately I've now run out of time, and am
unlikely to be able to do
> > anything on this until Friday now. What I would
suggest is
> > * cutting back the trailing ends to leave just the
code in
> > prefs/FileFormatPrefs.cpp
> > * change the third argument of
Tags::ShowEditDialog() from "true" to the
> > preference in the 4 places it occurs during
exports (two each in
> > export/ExportMultiple.cpp and export/Export.cpp)
> 
> I did something like that, but kept the 'get' method
(as it was 
> useful) and left the 'set' method (in case it will be).
 The pref 
> should work now.

Works fine Martyn, thanks, as you intended (i.e. not for
chains)
and another "essential" has been fixed. So for now
chains has 
regressed a little on the released 1.3.4 (can't show
Metadata Editor 
automatically) until we can sort out the link to the
"Edit Metadata"
command.  


Gale 

------------------------------------------------------------
-------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Audacity-devel mailing list
Audacity-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/audacity
-devel