$JHALFSDIR is not used everywehre

The lfs-command scripts for chapter 6 assume /jhalfs exists.
These 
should probably be changed to $JHALFSDIR instead, seeing the
config 
files allow you to change this.

-- 
Gerard Beekmans

/* If Linux doesn't have the solution, you have the wrong
problem */

-- 
http://linuxfromscratch.org/mailman/listinfo/alfs-discu
ss
FAQ: http://www.linux
fromscratch.org/faq/
Unsubscribe: See the above information page

El Domingo, 28 de Mayo de 2006 01:59, Gerard Beekmans
escribió:
> The lfs-command scripts for chapter 6 assume /jhalfs
exists. These
> should probably be changed to $JHALFSDIR instead,
seeing the config
> files allow you to change this.

Actually  $JHALFSDIR is a full path from / on the host. That
variable can't be 
used inside the chroot for obvious reasons 

But you are right, jhalfs/ could be replaced by an envar, at
least for proper 
coding style police (if a string is used in several places,
try to assign a 
variable to it to avoid to have to edit all occurrences if
the string need be 
changed in the future).

George, have you time to take care of that?


-- 
Manuel Canales Esparcia
Usuario de LFS nº2886:       http://www.linuxfroms
cratch.org
LFS en castellano: http://www.escomp
oslinux.org/lfs-es http://www.lfs-es.com
TLDP-ES:                           http://es.tldp.org
-- 
http://linuxfromscratch.org/mailman/listinfo/alfs-discu
ss
FAQ: http://www.linux
fromscratch.org/faq/
Unsubscribe: See the above information page

M.Canales.es wrote:
> El Domingo, 28 de Mayo de 2006 01:59, Gerard Beekmans
escribió:
>> The lfs-command scripts for chapter 6 assume
/jhalfs exists. These
>> should probably be changed to $JHALFSDIR instead,
seeing the config
>> files allow you to change this.
> 
> Actually  $JHALFSDIR is a full path from / on the host.
That variable can't be 
> used inside the chroot for obvious reasons 
> 
> But you are right, jhalfs/ could be replaced by an
envar, at least for proper 
> coding style police (if a string is used in several
places, try to assign a 
> variable to it to avoid to have to edit all occurrences
if the string need be 
> changed in the future).
> 
> George, have you time to take care of that?

   I need some clarification. Do you want the directory name
"jhalfs" to 
be referenced through a variable:

  define in common/config
    SCRIPT_ROOT=jhalfs
    JHALFSDIR=$BUILDDIR/$SCRIPT_ROOT

AND THEN modify all references to the directory jhalfs,
replace with the 
variable SCRIPT_ROOT?

example:
echo -e "\nKB: \`du -skx --exclude=jhalfs
\`\n" >>logs/$this_script
echo -e "\nKB: \`du -skx --exclude=$
\`\n" >>logs/$this_script

> 
> 
-- 
http://linuxfromscratch.org/mailman/listinfo/alfs-discu
ss
FAQ: http://www.linux
fromscratch.org/faq/
Unsubscribe: See the above information page