RemoveBonding

Hi Marcel,

Here is the patch to remove bondings.

Please check the logic. I read the BlueZ D-Bus API and the
Bluetooth
Spec, but I am not complete sure if I am covering all
scenarios.

Regarding the HCI disconnect complete event, I think we need
notify
the connected applications sending a D-Bus signal. What do
you think?

Regards,
Claudio.
--
---------------------------------------------------------
Claudio Takahasi
Instituto Nokia de Tecnologia - INdT

Hi Claudio,

> Here is the patch to remove bondings.
> 
> Please check the logic. I read the BlueZ D-Bus API and
the Bluetooth
> Spec, but I am not complete sure if I am covering all
scenarios.

the logic looks fine to me. However it is not that important
at the
moment, because we can sort out the details later.

Some small notes. The textfile_get() is not needed. Simply
delete the
link key. If it fails, because it doesn't exists, this is
fine. And use
hci_disconnect() instead of implementing it by yourself.

> Regarding the HCI disconnect complete event, I think we
need notify
> the connected applications sending a D-Bus signal. What
do you think?

We need to inform applications about the disconnect, but
this is not the
job of this method. It will be done by other routines inside
hcid.

Regards

Marcel




-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep
through log files
for problems?  Stop!  Download the new AJAX search engine
that makes
searching your log files as easy as surfing the  web. 
DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/
sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
Bluez-devel mailing list
Bluez-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Hi Marcel,

Your suggestions are done!

Regarding the disconnect timeout, I tested with 100ms. It is
working,
but is it enough?


On 2/21/06, Marcel Holtmann <marcelholtmann.org> wrote:
> Hi Claudio,
>
> > Here is the patch to remove bondings.
> >
> > Please check the logic. I read the BlueZ D-Bus API
and the Bluetooth
> > Spec, but I am not complete sure if I am covering
all scenarios.
>
> the logic looks fine to me. However it is not that
important at the
> moment, because we can sort out the details later.
>
> Some small notes. The textfile_get() is not needed.
Simply delete the
> link key. If it fails, because it doesn't exists, this
is fine. And use
> hci_disconnect() instead of implementing it by
yourself.
[Claudio Takahasi]
I didn't use hci_disconnect and hci_delete_stored_link_keys
to get the
error reason.


>
> > Regarding the HCI disconnect complete event, I
think we need notify
> > the connected applications sending a D-Bus signal.
What do you think?
>
> We need to inform applications about the disconnect,
but this is not the
> job of this method. It will be done by other routines
inside hcid.
[Claudio Takahasi]
Ok. I will write in my TODO list.


Regards,
Claudio
>
> Regards
>
> Marcel
>
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you
grep through log files
> for problems?  Stop!  Download the new AJAX search
engine that makes
> searching your log files as easy as surfing the  web. 
DOWNLOAD SPLUNK!
> http://sel.as-us.falkag.net/
sel?cmd=lnk&kid=103432&bid=230486&dat=121642
> _______________________________________________
> Bluez-devel mailing list
> Bluez-devellists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/bluez-devel

>


--
---------------------------------------------------------
Claudio Takahasi
Instituto Nokia de Tecnologia - INdT

Hi Claudio,

> Regarding the disconnect timeout, I tested with 100ms.
It is working,
> but is it enough?

your patch has been applied to the CVS. However I removed
some of the
syslog messages, because they are to talky. You can expect
that the
normal case is that the device is not connected and that the
key is not
stored on the chip.

Regards

Marcel




-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep
through log files
for problems?  Stop!  Download the new AJAX search engine
that makes
searching your log files as easy as surfing the  web. 
DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/
sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
Bluez-devel mailing list
Bluez-devellists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel