Re: bug 1267, take away hostname from login URL,

On Jun 19, 2007, at 07:13, slanningbricolage.cc wrote:

> -	    redirect_onload('http://' . $r->hostname .
$port . $redir,  
> $self);
> +	    redirect_onload($redir, $self);

I'm not sure about this. There is usually a very good reason
that the  
host name is included. Furthermore, it should not be
required for  
Apache 2 reverse proxying (which I've been using with
Bricolage  
installations for years now) as long as the host name
configuration  
in bricolage.conf resolves to the proxy server and the proxy
server  
knows what server to pass it back to.

Best,

David

On Jun 19, 2007, at 10:02, David E. Wheeler wrote:

> I'm not sure about this. There is usually a very good
reason that  
> the host name is included. Furthermore, it should not
be required  
> for Apache 2 reverse proxying (which I've been using
with Bricolage  
> installations for years now) as long as the host name
configuration  
> in bricolage.conf resolves to the proxy server and the
proxy server  
> knows what server to pass it back to.

Oh, and BTW, Scott, thanks for all the bug fixes today.
They're sure  
to improve the perception that Bricolage is abandoned.

Go Scott!

Best,

David

On Tue, 19 Jun 2007, David E. Wheeler wrote:
> On Jun 19, 2007, at 07:13, slanningbricolage.cc wrote:
>> -	    redirect_onload('http://' . $r->hostname .
$port . $redir, 
>> $self);
>> +	    redirect_onload($redir, $self);
>
> I'm not sure about this. There is usually a very good
reason that the host 
> name is included. Furthermore, it should not be
required for Apache 2 reverse 
> proxying (which I've been using with Bricolage
installations for years now) 
> as long as the host name configuration in
bricolage.conf resolves to the 
> proxy server and the proxy server knows what server to
pass it back to.

I think you're right, so I reverted it,
but why is the |ssl half there in Callback/Login.pm
not also using the full URL?

On Jun 19, 2007, at 10:02, David E. Wheeler wrote:

> On Jun 19, 2007, at 07:13, slanningbricolage.cc wrote:
>
>> -	    redirect_onload('http://' . $r->hostname .
$port . $redir,  
>> $self);
>> +	    redirect_onload($redir, $self);
>
> I'm not sure about this. There is usually a very good
reason that  
> the host name is included. Furthermore, it should not
be required  
> for Apache 2 reverse proxying (which I've been using
with Bricolage  
> installations for years now) as long as the host name
configuration  
> in bricolage.conf resolves to the proxy server and the
proxy server  
> knows what server to pass it back to.

Hey,

It turns out that the reason for the above was so that, if 

ALWAY_USE_SSL was false, the user would be redirected to the
non-SSL  
port. In testing the Apache 2 port, I discovered that
Bricolage was  
always staying in SSL because of this change. So I'm
reverting this  
change.

Steffen, if you set ALWAYS_USE_SSL to "Yes", then
you should once  
again be able to use Bricolage behind your Apache 2 reverse
proxy. It  
turns out that that's why I never had a problem with the
Kineticode  
Bricolage behind a reverse proxy: I had ALWAYS_USE_SSL set
to "Yes".  
That setting is effectively the same as the above patch, as
it keeps  
you in SSL and so only needs to do redirects like
"/login" instead of "http://localhost/login 
". I'll document this.

Best,

David