The "Download" link in Media Profile wasn't opening up into a new

Revision

8243

Author

slanning

Date

2008-06-12 04:47:03 -0700 (Thu, 12 Jun 2008)

Log Message

The "Download" link in Media Profile wasn't opening up into a new window
in some browsers (notably IE) due to a code typo. Reported by Tatiana Titova
(bug spotted during upgrade-rollout testing)

Modified Paths

• bricolage/branches/rev_1_10/comp/widgets/help/debuggers.html
• bricolage/branches/rev_1_10/comp/widgets/media_prof/file_section.mc
• bricolage/branches/rev_1_10/lib/Bric/Changes.pod
• bricolage/branches/rev_1_10/lib/Bric/License.pod

--- bricolage/branches/rev_1_10/comp/widgets/help/debuggers.html	2008-06-10 01:58:27 UTC (rev 8242)
+++ bricolage/branches/rev_1_10/comp/widgets/help/debuggers.html	2008-06-12 11:47:03 UTC (rev 8243)
 -82,4 +82,5 
   <li>Chauncey Thorn</li>
   <li>Matt Wlazlo</li>
   <li>Jean-Michel Caricand&lt;/li>
+  <li>Tatiana Titova</li>
 </ul>;

--- bricolage/branches/rev_1_10/comp/widgets/media_prof/file_section.mc	2008-06-10 01:58:27 UTC (rev 8242)
+++ bricolage/branches/rev_1_10/comp/widgets/media_prof/file_section.mc	2008-06-12 11:47:03 UTC (rev 8243)
 -7,7 +7,7 
   <tr>
     <th style=&quot;text-align: right;<% $indent %>";><% $lang->maketext('Download') %>:&;nbsp;</th>
 %     if (my $uri = $media->;get_local_uri) {
-    <td><a href=";<% $uri %>"; onclick=&quot;window.open(this.href, 'download_} . SERVER_WINDOW_NAME . qq{'); return false;&quot; title=&quot;<% $lang->maketext('Download this media') %>";><% $media->;get_file_name %></a></td>
+    <td><a href=";<% $uri %>"; onclick=&quot;window.open(this.href, 'download_<% SERVER_WINDOW_NAME %>'); return false;&quot; title=&quot;<% $lang->maketext('Download this media') %>";><% $media->;get_file_name %></a></td>
 %     } else {
     <td><% $lang->maketext('No file has been uploaded') %></td>
 %     }
 -34,7 +34,7 
 %   if (my $uri = $media->;get_local_uri) {
   <tr>
     <th style=&quot;text-align: right;&quot;><% $lang->maketext('Download') %>:</th>
-    <td><a href=";<% $uri %>"; onclick=&quot;window.open(this.href, 'download_} . SERVER_WINDOW_NAME . qq{'); return false;&quot; title=&quot;<% $lang->maketext('Download this media') %>";><% $media->;get_file_name %></a></td>
+    <td><a href=";<% $uri %>"; onclick=&quot;window.open(this.href, 'download_<% SERVER_WINDOW_NAME %>'); return false;&quot; title=&quot;<% $lang->maketext('Download this media') %>";><% $media->;get_file_name %></a></td>
     <td><& '/widgets/profile/imageSubmit.mc',
          formName => "theForm",

          callback => $widget ."|delete_media_cb",

--- bricolage/branches/rev_1_10/lib/Bric/Changes.pod	2008-06-10 01:58:27 UTC (rev 8242)
+++ bricolage/branches/rev_1_10/lib/Bric/Changes.pod	2008-06-12 11:47:03 UTC (rev 8243)
 -42,6 +42,11 
 
 Fixed bug 1339, editing User Prefs wasn't working. [Scott]
 
+=item *
+
+The download link in Media Profile wasn't popping up into a new window on some
+browsers due to a typo. Spotted by Tatiana Titova. [Scott]
+
 =back
 
 =head1 VERSION 1.10.5 (2008-04-29)

--- bricolage/branches/rev_1_10/lib/Bric/License.pod	2008-06-10 01:58:27 UTC (rev 8242)
+++ bricolage/branches/rev_1_10/lib/Bric/License.pod	2008-06-12 11:47:03 UTC (rev 8243)
 -444,6 +444,8 
 
 =item * Jean-Michel Caricand
 
+=item * Tatiana Titova
+

 =back
 
 Bricolage's translation team: