List Info

Thread: Patch to fix single quotes in man page find(1)




Patch to fix single quotes in man page find(1)
country flaguser name
United States
2007-02-21 19:36:22
URL:
  <http://savann
ah.gnu.org/bugs/?19120>

                 Summary: Patch to fix single quotes in man
page find(1)
                 Project: findutils
            Submitted by: rrt
            Submitted on: Thursday 22/02/07 at 01:36
                Category: documentation
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
         Originator Name: Reuben Thomas
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 4.2.28
           Fixed Release: None

    _______________________________________________________

Details:

The use of single quotes in this man page is frequently
erroneous. My fixes
fall into the following categories:

1. Use ` instead of ' at the start of quoted text.

2. Use (aq instead of ' or ' in commands to get a literal
straight quote.

3. Use ` and ' instead of `` and '' (for consistency).

I attach a unified diff against find(1) as shipped with
4.2.28.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Thursday 22/02/07 at 01:36  Name: find.1.patch  Size:
10kB   By: rrt

<http://savannah.gnu.org/bugs/download.php?file_id=120
24>

    _______________________________________________________

Reply to this item at:

  <http://savann
ah.gnu.org/bugs/?19120>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




_______________________________________________
Bug-findutils mailing list
Bug-findutilsgnu.org
h
ttp://lists.gnu.org/mailman/listinfo/bug-findutils

Patch to fix single quotes in man page find(1)
user name
2007-06-24 11:19:00
Follow-up Comment #1, bug #19120 (project findutils):

Cool. This has just been pointed out to me in <http://bugs.debian.
org/430139>
and there is already a patch. 


BTW imho for this specific example the quotes should simply
be dropped; i.e.
instead of

-find . -wholename './src/emacs' -prune -o -print
+find . -wholename (aq./src/emacs(aq -prune -o -print

this would be used:
-find . -wholename './src/emacs' -prune -o -print
+find . -wholename ./src/emacs -prune -o -print

Otherwise the patch looks fine to me in both C and UTF-8
locale.
cu andreas

    _______________________________________________________

Reply to this item at:

  <http://savann
ah.gnu.org/bugs/?19120>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.gnu.org/




_______________________________________________
Bug-findutils mailing list
Bug-findutilsgnu.org
h
ttp://lists.gnu.org/mailman/listinfo/bug-findutils

Patch to fix single quotes in man page find(1)
user name
2007-07-06 18:46:19
Follow-up Comment #2, bug #19120 (project findutils):

Is there some problem with this patch? I'd like to see a
nicer-looking (and
more useful) man page!

    _______________________________________________________

Reply to this item at:

  <http://savann
ah.gnu.org/bugs/?19120>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




_______________________________________________
Bug-findutils mailing list
Bug-findutilsgnu.org
h
ttp://lists.gnu.org/mailman/listinfo/bug-findutils

Patch to fix single quotes in man page find(1)
user name
2007-07-07 04:17:20
Follow-up Comment #3, bug #19120 (project findutils):

The only problem is size.  Because of the size of the patch,
it would require
a copyright assignment.  However, the proposed changes are
straightforward. 
This means it is probably more efficient to point out the
specific types of
things that need to be changed than to provide a patch.  
It's a bit awkward
that it should sometimes be more work to apply a patch than
re-invent it, but
that is the situation in which the GNU projct sometimes
unwillingly finds
itself.   But see also
http://lists.gnu.org/archive/html/findu
tils-patches/2007-07/msg00001.html

    _______________________________________________________

Reply to this item at:

  <http://savann
ah.gnu.org/bugs/?19120>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




_______________________________________________
Bug-findutils mailing list
Bug-findutilsgnu.org
h
ttp://lists.gnu.org/mailman/listinfo/bug-findutils

Re: Patch to fix single quotes in man page find(1)
user name
2007-07-07 04:42:57
[ bug-findutils moved to BCC: ]

On 7/7/07, Reuben Thomas <rrtsc3d.org> wrote:
> I'm quite happy to make a copyright assignment, but you
seem to be implying
> that's more trouble for you. If that's the case, please
tell me and I'll see
> if I can make a quick sed script that has the same
effect.

If you are willing to make a copyright assignment, that's
great.
Thank you for contributing!   To do the assignment, please
fill out
either of the two attached files and send it to assigngnu.org. 
 The
principal difference between the two options is that one
assignes your
existing work on findutils to the FSF, and the other assigns
your past
and future work on findutils.

Many thanks!
James.

_______________________________________________
Bug-findutils mailing list
Bug-findutilsgnu.org
h
ttp://lists.gnu.org/mailman/listinfo/bug-findutils

  
  
Re: Patch to fix single quotes in man page find(1)
country flaguser name
United Kingdom
2007-07-07 04:26:10
On Sat, 7 Jul 2007, James Youngman wrote:

>
> Follow-up Comment #3, bug #19120 (project findutils):
>
> The only problem is size.  Because of the size of the
patch, it would require
> a copyright assignment.  However, the proposed changes
are straightforward.
> This means it is probably more efficient to point out
the specific types of
> things that need to be changed than to provide a patch.
  It's a bit awkward
> that it should sometimes be more work to apply a patch
than re-invent it, but
> that is the situation in which the GNU projct sometimes
unwillingly finds
> itself.

I'm quite happy to make a copyright assignment, but you seem
to be implying 
that's more trouble for you. If that's the case, please tell
me and I'll see 
if I can make a quick sed script that has the same effect.

-- 
http://rrt.sc3d.org/ |
wet nurse, n.  lactating lackey


_______________________________________________
Bug-findutils mailing list
Bug-findutilsgnu.org
h
ttp://lists.gnu.org/mailman/listinfo/bug-findutils

Re: Patch to fix single quotes in man page find(1)
country flaguser name
United Kingdom
2007-07-07 04:27:39
On Sat, 7 Jul 2007, James Youngman wrote:

> But see also
> http://lists.gnu.org/archive/html/findu
tils-patches/2007-07/msg00001.html

OK, so you seem to have fixed this bug anyway. You can close
mine, then.

-- 
http://rrt.sc3d.org/ |
think tank, n.  a safe container for noxious gases


_______________________________________________
Bug-findutils mailing list
Bug-findutilsgnu.org
h
ttp://lists.gnu.org/mailman/listinfo/bug-findutils

Patch to fix single quotes in man page find(1)
user name
2008-05-01 08:23:43
Follow-up Comment #4, bug #19120 (project findutils):

If this patch has not already been made in some form, it may
help to know
that I've made a copyright assignment to findutils, so you
can use it.

If it has already been made, feel free to close this item.

    _______________________________________________________

Reply to this item at:

  <http://savann
ah.gnu.org/bugs/?19120>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/





[1-8]

about | contact  Other archives ( Real Estate discussion Medical topics )