Re: svn commit: r24612 - trunk/subversion/bindings/javahl/native

BLAIRTIGRIS.ORG WROTE:
> AUTHOR: BLAIR
> DATE: TUE APR 17 13:32:49 2007
> NEW REVISION: 24612
> 
> LOG:
> * SUBVERSION/BINDINGS/JAVAHL/NATIVE/*.{H,CPP}:
>   FORMATTING CLEAN UP:
>     START COMMENT SENTENCES WITH CAPITAL LETTERS.
>     DO NOT USE INLINE COMMENTS.
>     WRAP TO 80 CHARACTERS.
>     ADD VERTICAL WHITESPACE BETWEEN FUNCTIONS AND
METHODS,
>       PREPROCESSOR MACROS.
>     REMOVE COMMENTS ON CONSTRUCTOR AND DESTRUCTORS
WHERE THE COMMENT
>       WAS "THIS IS A CONSTRUCTOR" OR
"THIS IS A DESTRUCTOR".


BLAIR,
THANKS FOR THE MUCH NEEDED CLEANUPS.  IT SEEMS THAT LOTS OF
COMMENTS THAT
WERE ALREADY UNDER 80 CHARACTERS PER LINE WERE WRAPPED EVEN
FARTHER.  IS
THERE A REASON FOR THIS?

THANKS,
-HYRUM

> MODIFIED:
TRUNK/SUBVERSION/BINDINGS/JAVAHL/NATIVE/BLAMECALLBACK.H
> URL:
HTTP://SVN.COLLAB.NET/VIEWVC/SVN/TRUNK/SUBVERSION/BINDINGS/J
AVAHL/NATIVE/BLAMECALLBACK.H?PATHREV=24612&R1=24611&
R2=24612
>
============================================================
==================
> ---
TRUNK/SUBVERSION/BINDINGS/JAVAHL/NATIVE/BLAMECALLBACK.H	(ORI
GINAL)
> +++
TRUNK/SUBVERSION/BINDINGS/JAVAHL/NATIVE/BLAMECALLBACK.H	TUE
APR 17 13:32:49 2007
>  -25,12 +25,13 
>  #IF _MSC_VER > 1000
>  #PRAGMA ONCE
>  #ENDIF // _MSC_VER > 1000
> +
>  #INCLUDE <JNI.H>
>  #INCLUDE "SVN_CLIENT.H"
>  
>  /**
            1         2         3         4         5       
 6         7         8
  
123456789012345678901234567890123456789012345678901234567890
12345678901234567890
> - * THIS CLASS HOLDS A JAVA CALLBACK OBJECT, WHICH WILL
RECEIVE EVERY LINE OF
> - * THE FILE FOR WHICH THE CALLBACK INFORMATION IS
REQUESTED.
> + * THIS CLASS HOLDS A JAVA CALLBACK OBJECT, WHICH WILL
RECEIVE EVERY
> + * LINE OF THE FILE FOR WHICH THE CALLBACK INFORMATION
IS REQUESTED.
>   */
>  CLASS BLAMECALLBACK
>  {
>  -53,9 +54,10 
>  
>  PRIVATE:
>      /**
> -     * THIS A LOCAL REFERENCE TO THE JAVA OBJECT.
> +     * THIS A LOCAL REFERENCE TO THE JAVA OBJECT.
>       */
>      JOBJECT M_CALLBACK;
>  };
> +
>  //
!DEFINED(AFX_BLAMECALLBACK_H__3BBF3F0F_C80C_45C9_8AC3_E1AF07
E5B810__INCLUDED_)
>  #ENDIF
...

Hyrum K. Wright wrote:
> blairtigris.org wrote:
>> Author: blair
>> Date: Tue Apr 17 13:32:49 2007
>> New Revision: 24612
>>
>> Log:
>> * subversion/bindings/javahl/native/*.{h,cpp}:
>>   Formatting clean up:
>>     Start comment sentences with capital letters.
>>     Do not use inline comments.
>>     Wrap to 80 characters.
>>     Add vertical whitespace between functions and
methods,
>>       preprocessor macros.
>>     Remove comments on constructor and destructors
where the comment
>>       was "this is a constructor" or
"this is a destructor".
> 
> 
> Blair,
> Thanks for the much needed cleanups.  It seems that
lots of comments that
> were already under 80 characters per line were wrapped
even farther.  Is
> there a reason for this?

Hyrum,

No specific reason.  Some of them had minor changes in it,
so while I'm 
in XEmacs, I just do a reformat of the paragraph.  I think
XEmacs wraps 
it down to 72 characters, and I'm just used to seeing them
that short 
and sometimes is wraps nicer.

This is purely bike-sheddy stuff 

Regards,
Blair

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesubversion.tigris.org
For additional commands, e-mail: dev-helpsubversion.tigris.org