On Sat, 28 Apr 2007, Hyrum K. Wright wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Mark Phippard wrote:
> > I still do not agree with this part of the spec:
> >
> > svn blame
> > Two additional columns for each line, with the
original revision
> > and author of that line. Unlike other commands, we
do not need to
> > worry about multiple source revisions, because
each line can have at
> > most one author.
> >
> >
> > I object to the two additional columns. If I run
svn blame
> > --merge-sensitive I do not need to see any other
information. I
> > thought at one point we even said that were it not
for the expected
> > performance hit in getting the merge information
that svn blame should
> > just always return this information. When using
blame it is not
> > likely that someone would want any other
information.
>
> I agree. I was surprised to see that still in the
spec.
>
> The comments made elsethread about returning both sets
of data through
> the blame API express a valid concern. This should be
fairly easy to
> accommodate; the command-line client can just filter
this output, while
> other clients can cache it or hide it pending a
checkbox or whatever
> else they please.
These extra columns were removed from the func spec. The
API will
still provide "actual" and "original"
revnum and author -- this will
be noted in the design spec.
|