Re: svn commit: r26896 - in trunk/subversion: svn tests/cmdline tests/cmdline/log_tests_data

Karl,

this commit breaks the testsuite on Mac. It's difficult to
see through
all other Mac buildbot failures, but in the output of build
3070 you can
see that log_tests.py 25 is failing:

http://www.mobsol.
be/buildbot/x86-macosx-gnu%20shared/builds/3070/step-Test%20
fsfs%2Bra_neon/0

This is the extract of the test failure:

EXCEPTION: Failure: 
  {'svn:date': '',
-  'svn:log': 'After the colon are a space, 3 bad chars, 3
good chars, and a period: ?\021?\022?\017tnr.'}
?                                                           
                                               ^

+  'svn:log': u'After the colon are a space, 3 bad chars, 3
good chars, and a period: ?\021?\022?\017tnn.'}
?             +                                             
                                                ^

Traceback (most recent call last):
  File
"/Users/lgo/slavedir/osx10.4-gcc4.0.1-ia32/build/subver
sion/tests/cmdline/svntest/main.py", line 924, in run
    rc = apply(self.pred.run, (), kw)
  File
"/Users/lgo/slavedir/osx10.4-gcc4.0.1-ia32/build/subver
sion/tests/cmdline/svntest/testcase.py", line 121, in
run
    return self.func(sandbox)
  File
"/Users/lgo/slavedir/osx10.4-gcc4.0.1-ia32/build/subver
sion/tests/cmdline/log_tests.py", line 1302, in
log_xml_with_bad_data
    svntest.actions.run_and_verify_log_xml(
  File
"/Users/lgo/slavedir/osx10.4-gcc4.0.1-ia32/build/subver
sion/tests/cmdline/svntest/actions.py", line 451, in
run_and_verify_log_xml
    entry.assert_revprops(expected_revprops[index])
  File
"/Users/lgo/slavedir/osx10.4-gcc4.0.1-ia32/build/subver
sion/tests/cmdline/svntest/actions.py", line 336, in
assert_revprops
    pprint.pformat(self.revprops).splitlines())))
Failure: 
  {'svn:date': '',
-  'svn:log': 'After the colon are a space, 3 bad chars, 3
good chars, and a period: ?\021?\022?\017tnr.'}
?                                                           
                                               ^

+  'svn:log': u'After the colon are a space, 3 bad chars, 3
good chars, and a period: ?\021?\022?\017tnn.'}
?             +                                             
                                                ^

FAIL:  log_tests.py 25: log --xml escapes non-utf8 data
(issue #2866)
END: log_tests.py

Lieven

kfogeltigris.org wrote:
> Author: kfogel
> Date: Tue Oct  2 13:30:06 2007
> New Revision: 26896
>
> Log:
> Fix issue #2866: log --xml should escape characters
that are invalid in XML.
>
> * subversion/svn/log-cmd.c
>   (log_entry_receiver_xml): Do the needful.
>
> * subversion/tests/cmdline/log_tests.py
>   (log_xml_with_bad_data): New test.  Thanks to epg for
help writing it.
>   (test_list): Run it.
>
> *
subversion/tests/cmdline/log_tests_data/xml-invalid-chars.du
mp:
>   New directory, new file.
>
>   
..

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesubversion.tigris.org
For additional commands, e-mail: dev-helpsubversion.tigris.org

Lieven Govaerts <svnlgomobsol.be> writes:
> this commit breaks the testsuite on Mac. It's difficult
to see through
> all other Mac buildbot failures, but in the output of
build 3070 you can
> see that log_tests.py 25 is failing:

Whups, sorry about that.  I will change the test data so it
won't
stimulate that particular behavior on the Mac.  Thanks for
letting me
know!

-Karl

> http://www.mobsol.
be/buildbot/x86-macosx-gnu%20shared/builds/3070/step-Test%20
fsfs%2Bra_neon/0
>
> This is the extract of the test failure:
>
> EXCEPTION: Failure: 
>   {'svn:date': '',
> -  'svn:log': 'After the colon are a space, 3 bad
chars, 3 good chars, and a period:
?\021?\022?\017tnr.'}
> ?                                                      
                                                    ^
>
> +  'svn:log': u'After the colon are a space, 3 bad
chars, 3 good chars, and a period:
?\021?\022?\017tnn.'}
> ?             +                                        
                                                     ^
>
> Traceback (most recent call last):
>   File
"/Users/lgo/slavedir/osx10.4-gcc4.0.1-ia32/build/subver
sion/tests/cmdline/svntest/main.py", line 924, in run
>     rc = apply(self.pred.run, (), kw)
>   File
"/Users/lgo/slavedir/osx10.4-gcc4.0.1-ia32/build/subver
sion/tests/cmdline/svntest/testcase.py", line 121, in
run
>     return self.func(sandbox)
>   File
"/Users/lgo/slavedir/osx10.4-gcc4.0.1-ia32/build/subver
sion/tests/cmdline/log_tests.py", line 1302, in
log_xml_with_bad_data
>     svntest.actions.run_and_verify_log_xml(
>   File
"/Users/lgo/slavedir/osx10.4-gcc4.0.1-ia32/build/subver
sion/tests/cmdline/svntest/actions.py", line 451, in
run_and_verify_log_xml
>     entry.assert_revprops(expected_revprops[index])
>   File
"/Users/lgo/slavedir/osx10.4-gcc4.0.1-ia32/build/subver
sion/tests/cmdline/svntest/actions.py", line 336, in
assert_revprops
>     pprint.pformat(self.revprops).splitlines())))
> Failure: 
>   {'svn:date': '',
> -  'svn:log': 'After the colon are a space, 3 bad
chars, 3 good chars, and a period:
?\021?\022?\017tnr.'}
> ?                                                      
                                                    ^
>
> +  'svn:log': u'After the colon are a space, 3 bad
chars, 3 good chars, and a period:
?\021?\022?\017tnn.'}
> ?             +                                        
                                                     ^
>
> FAIL:  log_tests.py 25: log --xml escapes non-utf8 data
(issue #2866)
> END: log_tests.py
>
> Lieven
>
> kfogeltigris.org wrote:
>> Author: kfogel
>> Date: Tue Oct  2 13:30:06 2007
>> New Revision: 26896
>>
>> Log:
>> Fix issue #2866: log --xml should escape characters
that are invalid in XML.
>>
>> * subversion/svn/log-cmd.c
>>   (log_entry_receiver_xml): Do the needful.
>>
>> * subversion/tests/cmdline/log_tests.py
>>   (log_xml_with_bad_data): New test.  Thanks to epg
for help writing it.
>>   (test_list): Run it.
>>
>> *
subversion/tests/cmdline/log_tests_data/xml-invalid-chars.du
mp:
>>   New directory, new file.
>>
>>   
> ..

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesubversion.tigris.org
For additional commands, e-mail: dev-helpsubversion.tigris.org