Re: svn checkpoint: r27139 - checkpoints

"Justin Erenkrantz" <justinerenkrantz.com> writes:
> On Oct 13, 2007 12:55 AM, Karl Fogel <kfogelred-bean.com> wrote:
>> How about: "anything you would have formerly
attached to an issue as a
>> patch", for starters?  Now we can just say a
revision number instead.
>
> But, then, it's impossible to review it via email
because we don't have diffs.

No objection here to turning diffs back on for
/checkpoints.

> All I'm suggesting is that we turn back on diffs and
socially tell
> folks, "don't be a turd" about giving
nit-pick comments to anything in
> /checkpoints.  Yet, if the intent of /checkpoints is
that
> occassionally folks will be asked to look in it, then
that implies we
> need easy ways to review what is there.  -- justin

Agreed.  (Sorry, I didn't grok the core of your complaint
before.)

Now, one usage I forsee is

   $ svn cp -m "checkpointing current code" . http://.../checkpoints/

In that case, will it show just the diff against the files'
baselines
(what I hope), or will it show the entire tree (what I
fear)?

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesubversion.tigris.org
For additional commands, e-mail: dev-helpsubversion.tigris.org

On 10/14/2007 9:55 AM, Karl Fogel wrote:
> "Justin Erenkrantz" <justinerenkrantz.com> writes:
>> On Oct 13, 2007 12:55 AM, Karl Fogel <kfogelred-bean.com> wrote:
>>> How about: "anything you would have
formerly attached to an issue as a
>>> patch", for starters?  Now we can just say
a revision number instead.
>> But, then, it's impossible to review it via email
because we don't have diffs.
> 
> No objection here to turning diffs back on for
/checkpoints.

I guess the thing I'm not getting is:

When you merge a checkpoint back into trunk, does mailer.py
send the 
diff of the entire merge?

If it does, then great.. people can do whatever they want in

/checkpoints or /anarchy or whatever it's called.  If they
happen to 
point someone to a /checkpoints release, it's just like
uploading a 
patch.  If they don't, then it's their private whatever.

And when they merge back in, we see the whole diff.

If it doesn't... could it?  Because that seems useful for
all sorts of 
reasons.

Jay

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesubversion.tigris.org
For additional commands, e-mail: dev-helpsubversion.tigris.org