post-revprop-change hook failure prevents revprop change

Hi,

An error in a post-revprop-change hook (to be precise, a
Perl script 
which was requiring a file that wasn't there) causes the
revprop to fail 
with the following error:

svn: DAV request failed; it's possible that the repository's

pre-revprop-change hook either failed or is non-existent
svn: At least one property change failed; repository is
unchanged

Surely this is the role of the pre-revprop-change hook -
post-revprop 
shouldn't be run until the change has been committed? That's
what the 
book implies (fyi there's a small typo in  the first
sentence after 
description: "... immediately after to the modification
...")

http://svnbook.red-bean.com/ni
ghtly/en/svn.ref.reposhooks.post-revprop-change.html

client & server are both 1.4.3

thanks

Dave

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesubversion.tigris.org
For additional commands, e-mail: dev-helpsubversion.tigris.org

It sounds like you've got a user error here:  try mailing
userssubversion.tigris.org for support.  I suspect that
you're trying
to commit a revision-prop (which always fails by default,
since it
requires the existence of a pre-rev-prop-hook script, which
doesn't
exist by default).

On 10/19/07, Dave Rodgman <dave_rodgmanfastmail.co.uk> wrote:
> Hi,
>
> An error in a post-revprop-change hook (to be precise,
a Perl script
> which was requiring a file that wasn't there) causes
the revprop to fail
> with the following error:
>
> svn: DAV request failed; it's possible that the
repository's
> pre-revprop-change hook either failed or is
non-existent
> svn: At least one property change failed; repository is
unchanged
>
> Surely this is the role of the pre-revprop-change hook
- post-revprop
> shouldn't be run until the change has been committed?
That's what the
> book implies (fyi there's a small typo in  the first
sentence after
> description: "... immediately after to the
modification ...")
>
> http://svnbook.red-bean.com/ni
ghtly/en/svn.ref.reposhooks.post-revprop-change.html
>
> client & server are both 1.4.3
>
> thanks
>
> Dave
>
>
------------------------------------------------------------
---------
> To unsubscribe, e-mail: dev-unsubscribesubversion.tigris.org
> For additional commands, e-mail: dev-helpsubversion.tigris.org
>
>

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesubversion.tigris.org
For additional commands, e-mail: dev-helpsubversion.tigris.org

Ben Collins-Sussman wrote:
> It sounds like you've got a user error here:  try
mailing
> userssubversion.tigris.org for support.  I suspect that
you're trying
> to commit a revision-prop (which always fails by
default, since it
> requires the existence of a pre-rev-prop-hook script,
which doesn't
> exist by default).
>   
Hi,

No, there is a working pre-revprop-change script. Fixing the
error in 
post-revprop-change
enables revprop commits.

Dave

> On 10/19/07, Dave Rodgman <dave_rodgmanfastmail.co.uk> wrote:
>   
>> Hi,
>>
>> An error in a post-revprop-change hook (to be
precise, a Perl script
>> which was requiring a file that wasn't there)
causes the revprop to fail
>> with the following error:
>>
>> svn: DAV request failed; it's possible that the
repository's
>> pre-revprop-change hook either failed or is
non-existent
>> svn: At least one property change failed;
repository is unchanged
>>
>> Surely this is the role of the pre-revprop-change
hook - post-revprop
>> shouldn't be run until the change has been
committed? That's what the
>> book implies (fyi there's a small typo in  the
first sentence after
>> description: "... immediately after to the
modification ...")
>>
>> http://svnbook.red-bean.com/ni
ghtly/en/svn.ref.reposhooks.post-revprop-change.html
>>
>> client & server are both 1.4.3
>>
>> thanks
>>
>> Dave
>>
>>
------------------------------------------------------------
---------
>> To unsubscribe, e-mail: dev-unsubscribesubversion.tigris.org
>> For additional commands, e-mail: dev-helpsubversion.tigris.org
>>
>>
>>     

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesubversion.tigris.org
For additional commands, e-mail: dev-helpsubversion.tigris.org

On 10/19/07, Dave Rodgman <dave_rodgmanfastmail.co.uk> wrote:
> Ben Collins-Sussman wrote:
> > It sounds like you've got a user error here:  try
mailing
> > userssubversion.tigris.org for support.  I
suspect that you're trying
> > to commit a revision-prop (which always fails by
default, since it
> > requires the existence of a pre-rev-prop-hook
script, which doesn't
> > exist by default).
> >
> Hi,
>
> No, there is a working pre-revprop-change script.
Fixing the error in
> post-revprop-change
> enables revprop commits.


OK, so how do we reproduce this problem?

  * Create a pre-revprop-change script that always returns
0
  * Create a post-revprop-change script that always returns
1
  * ...try to make a remote propchange?

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesubversion.tigris.org
For additional commands, e-mail: dev-helpsubversion.tigris.org

 > OK, so how do we reproduce this problem?
 > * Create a pre-revprop-change script that always
returns 0
 > * Create a post-revprop-change script that always
returns 1
 > * ...try to make a remote propchange?

Yes, that's sufficient:

pre-revprop-change:
#!/bin/bash
exit 0

post-revprop-change:
#!/bin/bash
exit 1

fails with the previously mentioned error. Changing the exit
status to 0 
in post-revprop-change allows the revprop change.

Dave

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesubversion.tigris.org
For additional commands, e-mail: dev-helpsubversion.tigris.org

On 10/19/07, Dave Rodgman <dave_rodgmanfastmail.co.uk> wrote:
>  > OK, so how do we reproduce this problem?
>  > * Create a pre-revprop-change script that always
returns 0
>  > * Create a post-revprop-change script that always
returns 1
>  > * ...try to make a remote propchange?
>
> Yes, that's sufficient:
>
> pre-revprop-change:
> #!/bin/bash
> exit 0
>
> post-revprop-change:
> #!/bin/bash
> exit 1

Ben, my hook-reporting fixes may affect this scenario, so it
could be
this can't be reproduced on 1.5-trunk.

bye,

Erik.

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesubversion.tigris.org
For additional commands, e-mail: dev-helpsubversion.tigris.org

On 10/19/07, Dave Rodgman <dave_rodgmanfastmail.co.uk> wrote:
> Hi,
>
> An error in a post-revprop-change hook (to be precise,
a Perl script
> which was requiring a file that wasn't there) causes
the revprop to fail
> with the following error:
>
> svn: DAV request failed; it's possible that the
repository's
> pre-revprop-change hook either failed or is
non-existent
> svn: At least one property change failed; repository is
unchanged
>
> Surely this is the role of the pre-revprop-change hook
- post-revprop
> shouldn't be run until the change has been committed?
That's what the
> book implies (fyi there's a small typo in  the first
sentence after
> description: "... immediately after to the
modification ...")
>
> http://svnbook.red-bean.com/ni
ghtly/en/svn.ref.reposhooks.post-revprop-change.html
>
> client & server are both 1.4.3

Repository is FSFS or BDB?

(cat /path/to/repository/db/fs-type)

--dave

-- 
David Glasser | glasserdavidglasser.net | http://www.davidglasser.
net/

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesubversion.tigris.org
For additional commands, e-mail: dev-helpsubversion.tigris.org

Dave Rodgman wrote:
> > OK, so how do we reproduce this problem?
> > * Create a pre-revprop-change script that always
returns 0
> > * Create a post-revprop-change script that always
returns 1
> > * ...try to make a remote propchange?
>
> Yes, that's sufficient:
>
> pre-revprop-change:
> #!/bin/bash
> exit 0
>
> post-revprop-change:
> #!/bin/bash
> exit 1
>
> fails with the previously mentioned error. Changing the
exit status to 
> 0 in post-revprop-change allows the revprop change.

This was on an FSFS backend, by the way.

cheers

Dave

>
> Dave
>
>
------------------------------------------------------------
---------
> To unsubscribe, e-mail: dev-unsubscribesubversion.tigris.org
> For additional commands, e-mail: dev-helpsubversion.tigris.org
>

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesubversion.tigris.org
For additional commands, e-mail: dev-helpsubversion.tigris.org

On Mon, 22 Oct 2007, Dave Rodgman wrote:

> Dave Rodgman wrote:
> >> OK, so how do we reproduce this problem?
> >> * Create a pre-revprop-change script that
always returns 0
> >> * Create a post-revprop-change script that
always returns 1
> >> * ...try to make a remote propchange?
> >
> >Yes, that's sufficient:
> >
> >pre-revprop-change:
> >#!/bin/bash
> >exit 0
> >
> >post-revprop-change:
> >#!/bin/bash
> >exit 1
> >
> >fails with the previously mentioned error. Changing
the exit status to 
> >0 in post-revprop-change allows the revprop
change.
> 
> This was on an FSFS backend, by the way.

Yuck.  Time for a bug in the tracker?  Sounds like a
1.6-consider, which
hopefully someone can get to in time for a 1.5.x backport.

Issue raised:

http://subversion.tigris.org/issues/show_bug.cgi?id=2990


Dave

Erik Huelsmann wrote:
> On 10/19/07, Dave Rodgman <dave_rodgmanfastmail.co.uk> wrote:
>   
>>  > OK, so how do we reproduce this problem?
>>  > * Create a pre-revprop-change script that
always returns 0
>>  > * Create a post-revprop-change script that
always returns 1
>>  > * ...try to make a remote propchange?
>>
>> Yes, that's sufficient:
>>
>> pre-revprop-change:
>> #!/bin/bash
>> exit 0
>>
>> post-revprop-change:
>> #!/bin/bash
>> exit 1
>>     
>
> Ben, my hook-reporting fixes may affect this scenario,
so it could be
> this can't be reproduced on 1.5-trunk.
>
> bye,
>
> Erik.
>   

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesubversion.tigris.org
For additional commands, e-mail: dev-helpsubversion.tigris.org