List Info

Thread: Re: svn commit: r27311 - in trunk/subversion: include libsvn_ra_serf




Re: svn commit: r27311 - in trunk/subversion: include libsvn_ra_serf
user name
2007-10-23 11:10:09
Nori, just FYI: in a commit that makes the same simple
change in many
places, it's not necessary to list all the places.  You can
just have
a log message that says

   "Kill trailing periods to meet our error message
conventions."

and leave it at that.  Not a big deal, just clarifying for
next time.

Best,
-Karl

noritigris.org writes:
> Author: nori
> Date: Mon Oct 22 11:02:50 2007
> New Revision: 27311
>
> Log:
> * subversion/include/svn_error_codes.h
>   (SVN_ERR_WC_COPYFROM_PATH_NOT_FOUND):
> * subversion/libsvn_ra_serf/blame.c
>   (svn_ra_serf__get_file_revs):
> * subversion/libsvn_ra_serf/commit.c
>   (open_root,
>    add_directory,
>    close_file):
> * subversion/libsvn_ra_serf/property.c
>   (svn_ra_serf__get_baseline_info):
> * subversion/libsvn_ra_serf/serf.c
>   (svn_ra_serf__get_latest_revnum,
>    fetch_path_props,
>    svn_ra_serf__check_path,
>    svn_ra_serf__get_dir):
> * subversion/libsvn_ra_serf/update.c
>   (fetch_file,
>    end_report,
>    finish_report):
> * subversion/libsvn_ra_serf/util.c
>   (svn_ra_serf__discover_root):
> * subversion/libsvn_ra_serf/getlocations.c
>   (svn_ra_serf__get_locations):
>   Kill trailing periods to meet our error message
conventions.
>
>
> Modified:
>    trunk/subversion/include/svn_error_codes.h
>    trunk/subversion/libsvn_ra_serf/blame.c
>    trunk/subversion/libsvn_ra_serf/commit.c
>    trunk/subversion/libsvn_ra_serf/getlocations.c
>    trunk/subversion/libsvn_ra_serf/property.c
>    trunk/subversion/libsvn_ra_serf/serf.c
>    trunk/subversion/libsvn_ra_serf/update.c
>    trunk/subversion/libsvn_ra_serf/util.c
>
> Modified: trunk/subversion/include/svn_error_codes.h
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/include
/svn_error_codes.h?pathrev=27311&r1=27310&r2=27311
>
============================================================
==================
> ---
trunk/subversion/include/svn_error_codes.h	(original)
> +++ trunk/subversion/include/svn_error_codes.h	Mon Oct
22 11:02:50 2007
>  -411,7 +411,7 
>  
>    SVN_ERRDEF(SVN_ERR_WC_COPYFROM_PATH_NOT_FOUND,
>               SVN_ERR_WC_CATEGORY_START + 28,
> -             "Failed to locate 'copyfrom' path in
working copy.")
> +             "Failed to locate 'copyfrom' path in
working copy")
>  
>    /** since New in 1.5. */
>    SVN_ERRDEF(SVN_ERR_WC_CHANGELIST_MOVE,
>
> Modified: trunk/subversion/libsvn_ra_serf/blame.c
> URL: 
http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_ra_
serf/blame.c?pathrev=27311&r1=27310&r2=27311
>
============================================================
==================
> --- trunk/subversion/libsvn_ra_serf/blame.c	(original)
> +++ trunk/subversion/libsvn_ra_serf/blame.c	Mon Oct 22
11:02:50 2007
>  -462,7 +462,7 
>        return
svn_error_create(SVN_ERR_RA_DAV_OPTIONS_REQ_FAILED, NULL,
>                                _("The OPTIONS
response did not include the "
>                                  "requested
version-controlled-configuration "
> -                                "value."));
> +                                "value"));
>      }
>  
>    /* Send the request to the baseline URL */
>  -473,7 +473,7 
>      {
>        return
svn_error_create(SVN_ERR_RA_DAV_OPTIONS_REQ_FAILED, NULL,
>                                _("The OPTIONS
response did not include the "
> -                                "requested
baseline-relative-path value."));
> +                                "requested
baseline-relative-path value"));
>      }
>    relative_url = svn_path_join(relative_url,
>                                
svn_path_uri_decode(lopped_path, pool),
>  -493,7 +493,7 
>          {
>            return
svn_error_create(SVN_ERR_RA_DAV_OPTIONS_REQ_FAILED, NULL,
>                                    _("The OPTIONS
response did not include the "
> -                                    "requested
checked-in value."));
> +                                    "requested
checked-in value"));
>          }
>  
>        SVN_ERR(svn_ra_serf__retrieve_props(props,
session, session->conns[0],
>  -520,7 +520,7 
>      {
>        return
svn_error_create(SVN_ERR_RA_DAV_OPTIONS_REQ_FAILED, NULL,
>                                _("The OPTIONS
response did not include the "
> -                                "requested
baseline-collection value."));
> +                                "requested
baseline-collection value"));
>      }
>  
>    req_url = svn_path_url_add_component(basecoll_url,
relative_url, pool);
>
> Modified: trunk/subversion/libsvn_ra_serf/commit.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_ra
_serf/commit.c?pathrev=27311&r1=27310&r2=27311
>
============================================================
==================
> ---
trunk/subversion/libsvn_ra_serf/commit.c	(original)
> +++ trunk/subversion/libsvn_ra_serf/commit.c	Mon Oct 22
11:02:50 2007
>  -999,7 +999,7 
>      {
>        return
svn_error_create(SVN_ERR_RA_DAV_OPTIONS_REQ_FAILED, NULL,
>                                _("The OPTIONS
response did not include the "
> -                                "requested
activity-collection-set value."));
> +                                "requested
activity-collection-set value"));
>      }
>  
>    ctx->activity_url =
svn_path_url_add_component(activity_str,
>  -1055,7 +1055,7 
>      {
>        return
svn_error_create(SVN_ERR_RA_DAV_OPTIONS_REQ_FAILED, NULL,
>                                _("The OPTIONS
response did not include the "
> -                                "requested
checked-in value."));
> +                                "requested
checked-in value"));
>      }
>  
>    dir = apr_pcalloc(dir_pool, sizeof(*dir));
>  -1281,7 +1281,7 
>          {
>            return
svn_error_create(SVN_ERR_RA_DAV_OPTIONS_REQ_FAILED, NULL,
>                                    _("The OPTIONS
response did not include the "
> -                                    "requested
baseline-collection value."));
> +                                    "requested
baseline-collection value"));
>          }
>  
>        req_url =
svn_path_url_add_component(basecoll_url, rel_copy_path,
>  -1669,7 +1669,7 
>          {
>            return
svn_error_create(SVN_ERR_RA_DAV_OPTIONS_REQ_FAILED, NULL,
>                                    _("The OPTIONS
response did not include the "
> -                                    "requested
baseline-collection value."));
> +                                    "requested
baseline-collection value"));
>          }
>  
>        req_url =
svn_path_url_add_component(basecoll_url, rel_copy_path,
pool);
>
> Modified:
trunk/subversion/libsvn_ra_serf/getlocations.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/lib
svn_ra_serf/getlocations.c?pathrev=27311&r1=27310&r2
=27311
>
============================================================
==================
> ---
trunk/subversion/libsvn_ra_serf/getlocations.c	(original)
> +++ trunk/subversion/libsvn_ra_serf/getlocations.c	Mon
Oct 22 11:02:50 2007
>  -255,7 +255,7 
>      {
>        return
svn_error_create(SVN_ERR_RA_DAV_OPTIONS_REQ_FAILED, NULL,
>                                _("The OPTIONS
response did not include the "
> -                                "requested
baseline-collection value."));
> +                                "requested
baseline-collection value"));
>      }
>  
>    req_url = svn_path_url_add_component(basecoll_url,
relative_url, pool);
>
> Modified: trunk/subversion/libsvn_ra_serf/property.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_
ra_serf/property.c?pathrev=27311&r1=27310&r2=27311
>
============================================================
==================
> ---
trunk/subversion/libsvn_ra_serf/property.c	(original)
> +++ trunk/subversion/libsvn_ra_serf/property.c	Mon Oct
22 11:02:50 2007
>  -921,7 +921,7 
>          {
>            return
svn_error_create(SVN_ERR_RA_DAV_OPTIONS_REQ_FAILED, NULL,
>                                    _("The OPTIONS
response did not include the "
> -                                    "requested
checked-in value."));
> +                                    "requested
checked-in value"));
>          }
>  
>        SVN_ERR(svn_ra_serf__retrieve_props(props,
session, session->conns[0],
>  -935,7 +935,7 
>      {
>        return
svn_error_create(SVN_ERR_RA_DAV_OPTIONS_REQ_FAILED, NULL,
>                                _("The OPTIONS
response did not include the "
> -                                "requested
baseline-collection value."));
> +                                "requested
baseline-collection value"));
>      }
>    *bc_url = basecoll_url;
>    *bc_relative = relative_url;
>
> Modified: trunk/subversion/libsvn_ra_serf/serf.c
> URL: h
ttp://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_ra_s
erf/serf.c?pathrev=27311&r1=27310&r2=27311
>
============================================================
==================
> --- trunk/subversion/libsvn_ra_serf/serf.c	(original)
> +++ trunk/subversion/libsvn_ra_serf/serf.c	Mon Oct 22
11:02:50 2007
>  -254,7 +254,7 
>        return
svn_error_create(SVN_ERR_RA_DAV_OPTIONS_REQ_FAILED, NULL,
>                                _("The OPTIONS
response did not include the "
>                                  "requested
version-controlled-configuration "
> -                                "value."));
> +                                "value"));
>      }
>  
>    /* Using the version-controlled-configuration, fetch
the checked-in prop. */
>  -269,7 +269,7 
>      {
>        return
svn_error_create(SVN_ERR_RA_DAV_OPTIONS_REQ_FAILED, NULL,
>                                _("The OPTIONS
response did not include the "
> -                                "requested
checked-in value."));
> +                                "requested
checked-in value"));
>      }
>  
>    /* Using the checked-in property, fetch:
>  -286,7 +286,7 
>      {
>        return
svn_error_create(SVN_ERR_RA_DAV_OPTIONS_REQ_FAILED, NULL,
>                                _("The OPTIONS
response did not include the "
> -                                "requested
version-name value."));
> +                                "requested
version-name value"));
>      }
>  
>    *latest_revnum = SVN_STR_TO_REV(version_name);
>  -391,7 +391,7 
>          {
>            return
svn_error_create(SVN_ERR_RA_DAV_OPTIONS_REQ_FAILED, NULL,
>                                    _("The OPTIONS
response did not include the "
> -                                    "requested
baseline-collection value."));
> +                                    "requested
baseline-collection value"));
>          }
>  
>        /* We will try again with our new path; however,
we're now
>  -450,7 +450,7 
>            /* How did this happen? */
>            return
svn_error_create(SVN_ERR_RA_DAV_OPTIONS_REQ_FAILED, NULL,
>                                    _("The OPTIONS
response did not include the "
> -                                    "requested
resourcetype value."));
> +                                    "requested
resourcetype value"));
>          }
>        else if (strcmp(res_type,
"collection") == 0)
>          {
>  -627,7 +627,7 
>          {
>            return
svn_error_create(SVN_ERR_RA_DAV_OPTIONS_REQ_FAILED, NULL,
>                                    _("The OPTIONS
response did not include the "
> -                                    "requested
baseline-collection value."));
> +                                    "requested
baseline-collection value"));
>          }
>  
>        if (fetched_rev)
>
> Modified: trunk/subversion/libsvn_ra_serf/update.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_ra
_serf/update.c?pathrev=27311&r1=27310&r2=27311
>
============================================================
==================
> ---
trunk/subversion/libsvn_ra_serf/update.c	(original)
> +++ trunk/subversion/libsvn_ra_serf/update.c	Mon Oct 22
11:02:50 2007
>  -1101,7 +1101,7 
>      {
>        return
svn_error_create(SVN_ERR_RA_DAV_OPTIONS_REQ_FAILED, NULL,
>                          _("The OPTIONS response
did not include the "
> -                          "requested checked-in
value."));
> +                          "requested checked-in
value"));
>      }
>  
>    /* If needed, create the PROPFIND to retrieve the
file's properties. */
>  -1645,7 +1645,7 
>          {
>            return
svn_error_create(SVN_ERR_RA_DAV_OPTIONS_REQ_FAILED, NULL,
>                                    _("The OPTIONS
response did not include the "
> -                                    "requested
checked-in value."));
> +                                    "requested
checked-in value"));
>          }
>  
>        info->dir->url = checked_in_url;
>  -2165,7 +2165,7 
>        return
svn_error_create(SVN_ERR_RA_DAV_OPTIONS_REQ_FAILED, NULL,
>                                _("The OPTIONS
response did not include the "
>                                  "requested
version-controlled-configuration "
> -                                "value."));
> +                                "value"));
>      }
>  
>    /* create and deliver request */
>
> Modified: trunk/subversion/libsvn_ra_serf/util.c
> URL: h
ttp://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_ra_s
erf/util.c?pathrev=27311&r1=27310&r2=27311
>
============================================================
==================
> --- trunk/subversion/libsvn_ra_serf/util.c	(original)
> +++ trunk/subversion/libsvn_ra_serf/util.c	Mon Oct 22
11:02:50 2007
>  -1175,7 +1175,7 
>        return
svn_error_create(SVN_ERR_RA_DAV_OPTIONS_REQ_FAILED, NULL,
>                                _("The OPTIONS
response did not include the "
>                                  "requested
version-controlled-configuration "
> -                                "value."));
> +                                "value"));
>      }
>  
>    /* Store our VCC in our cache. */
>
>
------------------------------------------------------------
---------
> To unsubscribe, e-mail: svn-unsubscribesubversion.tigris.org
> For additional commands, e-mail: svn-helpsubversion.tigris.org

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesubversion.tigris.org
For additional commands, e-mail: dev-helpsubversion.tigris.org


Re: svn commit: r27311 - in trunk/subversion: include libsvn_ra_serf
user name
2007-10-23 12:36:05
Hi,

> I have no idea what caused it, but I've just subscribed
you now.  Let
> me know (personally) if you still don't get dev mails.

Thank you very much, Karl!  It seems your subscription did
work!

Many thanks,

-nori

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesubversion.tigris.org
For additional commands, e-mail: dev-helpsubversion.tigris.org


[1-2]

about | contact  Other archives ( Real Estate discussion Medical topics )