Re: svn commit: r27323 - trunk/subversion/libsvn_client

On 10/23/07, C. Michael Pilato <cmpilatocollab.net> wrote:
> David Glasser wrote:
> >> +    case svn_opt_revision_committed:
> >> +    case svn_opt_revision_working:
> >> +    case svn_opt_revision_base:
> >> +    case svn_opt_revision_previous:
> >> +      {
> >> +        svn_wc_adm_access_t *adm_access; /*
### FIXME local */
> >
> > Did you meant to leave that in?
>
> To be honest, I don't know what "FIXME local"
even means.  I didn't add it
> myself, though.

Oh, heh.  I guess it's actually 5 years old.  r27336.

--dave

-- 
David Glasser | glasserdavidglasser.net | http://www.davidglasser.
net/

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesubversion.tigris.org
For additional commands, e-mail: dev-helpsubversion.tigris.org

"David Glasser" <glasserdavidglasser.net>
writes:

> On 10/23/07, C. Michael Pilato <cmpilatocollab.net> wrote:
>> David Glasser wrote:
>> >> +    case svn_opt_revision_committed:
>> >> +    case svn_opt_revision_working:
>> >> +    case svn_opt_revision_base:
>> >> +    case svn_opt_revision_previous:
>> >> +      {
>> >> +        svn_wc_adm_access_t *adm_access;
/* ### FIXME local */
>> >
>> > Did you meant to leave that in?
>>
>> To be honest, I don't know what "FIXME
local" even means.  I didn't add it
>> myself, though.
>
> Oh, heh.  I guess it's actually 5 years old.  r27336.

I can explain... that was to remind me that having this
function open
a local, i.e. temporary and read-only, view of the working
copy is a
bit of a hack as it means that the information obtained
could be
out-of-date even before the function returns, and also that
if/when
the operation opens the working copy "for real"
the same entries file
needs to be read a second time.

------------------------------------------------------------
---------
To unsubscribe, e-mail: dev-unsubscribesubversion.tigris.org
For additional commands, e-mail: dev-helpsubversion.tigris.org