editing and commiting special files under windows renders repository unusable

Thread: editing and commiting special files under windows renders repository unusable

Search this list only Search all lists
editing and commiting special files under windows renders repository unusable
	2007-01-24 18:01:37
http://subversion.tigris.org/issues/show_bug.cgi?id=2692 ------- Additional comments from garrisontigris.org Wed Jan 24 16:01:37 -0800 2007 ------- >From recent (Jan 23, 2007) discussion on #svn-dev -- 1. If we get a special file of unknown type, just write the internal representation out, don't error. That is what is now done for symlinks on windows. 2. If we try to commit changes to a special file of unknown type, error. This may be done on client side - to inform user about erroneous change to item of unknown type and to stop feeding the server with garbage change. -- By looking at the code a real problem with wc code appears to be in too much coupling between checks for svn:special and HAVE_SYMLINK dependent conditional compilation. For example, assemble_status() on windows does not check for svn:special property value at all, because all the checking is under ifdef HAVE_SYMLINK! Instead, checks for svn:special property value should be done unconditionally. At the time the actual wc item is to be inspected, platforms with HAVE_SYMLINK set should do the symlink stat stuff and others resort to the appropriate emulation. Then, to my mind repository code should do appropriate checking on it's own anyway, to prevent inconsistent changes crippling in. If a change is to an item of special type, server can decide if that change is allowed, because all supported svn:special types are known. For example, svn:special "link" can change it's special type only if it is "replaced", but svn:special "link dest1" can be changed to svn:special "link dest2" as one would expect for symlinks. --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribesubversion.tigris.org For additional commands, e-mail: issues-helpsubversion.tigris.org