New - Invalid diff format under Chinese locale

http://subversion.tigris.org/issues/show_bug.cgi?id=2906

                 Issue #|2906
                 Summary|Invalid diff format under Chinese
locale
               Component|subversion
                 Version|1.4.x
                Platform|All
                     URL|
              OS/Version|All
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P3
            Subcomponent|libsvn_diff
             Assigned to|issuessubversion
             Reported by|sits






------- Additional comments from sitstigris.org Mon Sep  3
15:03:32 -0700 2007 -------
This issue was first reported on the user mailing list:

http://svn.haxx.se/users/archive-2007-08/0427.shtml.

For convenience, here is the text of the message again:

Hi there,

I received a diff file from a Chinese user of Subversion,
the relevant
bit is as follows, which is the end of one diff segment, and
the start
of another:

#endif
 在文件
 末尾没有新行Index: src/file.cpp

The Chinese is the translation of "No newline at end of
file".

My question is, why does this sentence have a newline in the
middle of
it? Also the "Index:" text doesn't start at the
beginning of a
newline.

To be properly formatted as a diff, I would have thought
this should be:

#endif
 在文件末尾没有新行
Index: src/file.cpp

Is this a bug?

This came up, as I am the author of Codestriker, which is a
web
application for code reviewing. As input, it can receive
diff files
from different SCMs, including Subversion. This diff came up
which it
couldn't parse, because of this extra newline.

Cheers,
David

------------------------------------------------------------
---------
To unsubscribe, e-mail: issues-unsubscribesubversion.tigris.org
For additional commands, e-mail: issues-helpsubversion.tigris.org

http://subversion.tigris.org/issues/show_bug.cgi?id=2906




User malcolm changed the following:

                What    ld value 
               |New value
============================================================
====================
             Assigned to|issuessubversion        
|dionisos
------------------------------------------------------------
--------------------




------- Additional comments from malcolmtigris.org Fri Sep  7 01:23:58 -0700 2007 -------
As Erik points out in the referenced email, this has been
fixed on trunk (what will become 1.5.0) such that 
the message is no longer marked for translation.

I've nominated the fix for backport to 1.4.6.



------------------------------------------------------------
---------
To unsubscribe, e-mail: issues-unsubscribesubversion.tigris.org
For additional commands, e-mail: issues-helpsubversion.tigris.org

http://subversion.tigris.org/issues/show_bug.cgi?id=2906




User malcolm changed the following:

                What    ld value 
               |New value
============================================================
====================
                  Status|NEW                      
|RESOLVED
------------------------------------------------------------
--------------------
              Resolution|                          |FIXED
------------------------------------------------------------
--------------------




------- Additional comments from malcolmtigris.org Fri Sep  7 01:24:16 -0700 2007 -------
(Marking this issue fixed because it's no longer a problem
on trunk.)

------------------------------------------------------------
---------
To unsubscribe, e-mail: issues-unsubscribesubversion.tigris.org
For additional commands, e-mail: issues-helpsubversion.tigris.org

http://subversion.tigris.org/issues/show_bug.cgi?id=2906







------- Additional comments from sitstigris.org Fri Sep  7
02:56:19 -0700 2007 -------
Thanks - I hope to see this in 1.4.6 as well, as this was
the main purpose in me
creating this bug report!

------------------------------------------------------------
---------
To unsubscribe, e-mail: issues-unsubscribesubversion.tigris.org
For additional commands, e-mail: issues-helpsubversion.tigris.org