New - svnsync fails (hangs) when no read permission on trunk

http://subversion.tigris.org/issues/show_bug.cgi?id=2960

                 Issue #|2960
                 Summary|svnsync fails (hangs) when no read
permission on trunk
               Component|subversion
                 Version|---
                Platform|All
                     URL|http://subversion.tigris.org/servlets/BrowseList?list=

                        |dev&by=thread&from=613022
              OS/Version|All
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P1
            Subcomponent|svnsync
             Assigned to|issuessubversion
             Reported by|quinot






------- Additional comments from quinottigris.org Tue Oct  9 02:13:47 -0700 2007 -------
We have come across an issue trying to use svnsync to
synchronize
a repository where the user doing the syncrhonization has
read
permissions on some selected subtrees of the repository, but
not on the
repository root or top-level trunk.

To reproduce:

1. set up master repo

2. load attached dump

3. configure access control

[/]
*=
[/trunk/module]
*=r

4. check that the access control is properly enforced

svn ls svn+ssh://localhost/path/to/master
--> svn: Authorization failed

svn ls svn+ssh://localhost/path/to/master/trunk/module
--> README

5. set up slave repo

$ svnsync init file:///path/to/slave
svn+ssh://localhost/path/to/master
--> Copied properties for revision 0.

6. launch sync
$ svnsync sync file:///path/to/slave
svn+ssh://localhost/path/to/master
--> svnsync hangs because it fails to execute the
open-dir operation
    on non-existent directory 'trunk' (because it never saw
the
    directory creating operation, having no visibility on
it)

Proposed fix is for svnsync to create any directory that
does not exist
at the time it tries to open it. I have a patch to this
effect, which seems
to work well here (see mailing list message:
http://subversion.tigris.org/servlets/Rea
dMsg?list=dev&msgNo=130877).
Alternative solution is to fix
the issue at the replay level (I'm not very familiar with
the code yet, so I'll
likely need help if this solution is preferred).
level.

------------------------------------------------------------
---------
To unsubscribe, e-mail: issues-unsubscribesubversion.tigris.org
For additional commands, e-mail: issues-helpsubversion.tigris.org

http://subversion.tigris.org/issues/show_bug.cgi?id=2960




User quinot changed the following:

                What    ld value 
               |New value
============================================================
====================
     Attachment is patch|                          |Created
an attachment (id=
                        |                          |748)
Proposed patch (fix a
                        |                          |t
svnsync level)

------------------------------------------------------------
--------------------




------- Additional comments from quinottigris.org Tue Oct  9 02:14:36 -0700 2007 -------
Created an attachment (id=748)
Proposed patch (fix at svnsync level)


------------------------------------------------------------
---------
To unsubscribe, e-mail: issues-unsubscribesubversion.tigris.org
For additional commands, e-mail: issues-helpsubversion.tigris.org

http://subversion.tigris.org/issues/show_bug.cgi?id=2960




User quinot changed the following:

                What    ld value 
               |New value
============================================================
====================
         Attachment data|                          |Created
an attachment (id=
                        |                          |749)
Master repository dum
                        |                          |p

------------------------------------------------------------
--------------------




------- Additional comments from quinottigris.org Tue Oct  9 02:15:26 -0700 2007 -------
Created an attachment (id=749)
Master repository dump


------------------------------------------------------------
---------
To unsubscribe, e-mail: issues-unsubscribesubversion.tigris.org
For additional commands, e-mail: issues-helpsubversion.tigris.org

http://subversion.tigris.org/issues/show_bug.cgi?id=2960




User dlr changed the following:

                What    ld value 
               |New value
============================================================
====================
        Target milestone|---                      
|1.6-consider
------------------------------------------------------------
--------------------




------------------------------------------------------------
---------
To unsubscribe, e-mail: issues-unsubscribesubversion.tigris.org
For additional commands, e-mail: issues-helpsubversion.tigris.org

http://subversion.tigris.org/issues/show_bug.cgi?id=2960




User glasser changed the following:

                What    ld value 
               |New value
============================================================
====================
                 Summary|svnsync fails (hangs) when|authz
problems when you ca
                        | no read permission on tru|n read
children of paths y
                        |nk                        |ou can't
read (svnsync, lo
                        |                          |g, etc)
------------------------------------------------------------
--------------------




------- Additional comments from glassertigris.org Tue Nov  6 16:04:24 -0800 2007 -------
When Thomas first submitted his patch, I thought it should
be done at the level
of svn_repos_replay.  But that wouldn't work either... how
would the replay
repository know if the destination has "already
added" the deeper level?

The entire concept of having access to a subdirectory of
something you can't
read seems a little fraught with problems.  See the patch
I'm about to attach
for an example where "svn log svn://some/repos/root
-r1" works when r1 is HEAD
(showing only the changed paths that the user can see), but
then fails to work
after the invisible parent of visible paths is deleted!

I'm changing the summary to be broader than just svnsync.

------------------------------------------------------------
---------
To unsubscribe, e-mail: issues-unsubscribesubversion.tigris.org
For additional commands, e-mail: issues-helpsubversion.tigris.org

http://subversion.tigris.org/issues/show_bug.cgi?id=2960




User glasser changed the following:

                What    ld value 
               |New value
============================================================
====================
         Attachment data|                          |Created
an attachment (id=
                        |                          |788)
script showing how th
                        |                          |e same
log command can wor
                        |                          |k once
and fail later

------------------------------------------------------------
--------------------




------- Additional comments from glassertigris.org Tue Nov  6 16:05:14 -0800 2007 -------
Created an attachment (id=788)
script showing how the same log command can work once and
fail later


------------------------------------------------------------
---------
To unsubscribe, e-mail: issues-unsubscribesubversion.tigris.org
For additional commands, e-mail: issues-helpsubversion.tigris.org