New - copy-on-update needs to use loggy correctly

http://subversion.tigris.org/issues/show_bug.cgi?id=2986

                 Issue #|2986
                 Summary|copy-on-update needs to use loggy
correctly
               Component|subversion
                 Version|trunk
                Platform|All
                     URL|
              OS/Version|All
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P3
            Subcomponent|libsvn_wc
             Assigned to|issuessubversion
             Reported by|glasser






------- Additional comments from glassertigris.org Tue Oct 23 17:16:42 -0700 2007 -------
It is potentially possible for a CTRL-C in an update to
leave you with a
silently corrupted and un-cleanup-able wc.

There are two issues with the way that add_file_with_history
uses loggy.

The first is that it uses loggy too much: it explicitly runs
a loggy early to
make a new file appear, but that file is not a file that
should ever exist --
its metadata is incomplete (no svn:entry props) and
it doesn't represent any
actual state of the repository's history.  It is being
created early just so
that apply_textdelta has something to morph into the correct
object.  If you
interrupts the update right after these logs are run, you
have a silently
corrupted wc.

The second (semi-related) issue is that when we copy over
local mods (definitely
text, not sure if props is a problem too) we do *not* do it
loggily: we just
copy directly into the wc, a big no-no.  We need to have
this happen loggily, in
the *same log* as the rest of the operations on the file.

------------------------------------------------------------
---------
To unsubscribe, e-mail: issues-unsubscribesubversion.tigris.org
For additional commands, e-mail: issues-helpsubversion.tigris.org

http://subversion.tigris.org/issues/show_bug.cgi?id=2986




User glasser changed the following:

                What    ld value 
               |New value
============================================================
====================
             Assigned to|issuessubversion        
|glasser
------------------------------------------------------------
--------------------
        Target milestone|---                       |1.5
------------------------------------------------------------
--------------------




------- Additional comments from glassertigris.org Tue Oct 23 17:22:57 -0700 2007 -------
(This is a 1.5 blocker.)

Proposed solution (sussman and glasser): Drop the whole
close_file/run-logs/open_file charade in
add_file_with_history.  Instead, copy
both the text-base and the local-modded version into unique
files in .svn/tmp;
add fields to the file baton to track them; make
apply_textdelta use this
text-base instead of the empty file as a source; and the
small planet has to use
the second field instead of the working file.

Also we need to think carefully about substitution. (What I
really mean is, we
should have at least one test of this feature with subst.)

------------------------------------------------------------
---------
To unsubscribe, e-mail: issues-unsubscribesubversion.tigris.org
For additional commands, e-mail: issues-helpsubversion.tigris.org

http://subversion.tigris.org/issues/show_bug.cgi?id=2986




User markphip changed the following:

                What    ld value 
               |New value
============================================================
====================
                      CC|''                       
|'markphip'
------------------------------------------------------------
--------------------




------- Additional comments from markphiptigris.org Wed Oct 24 08:56:03 -0700 2007 -------
I think we should give serious consideration to pulling this
feature from 1.5.  It will
be a great feature but with the potential problems it is
introducing and the fact that
it is still somewhat indeterminate when the feature will
work and when you will get the
old behavior, I think it is best that we pull this until it
can be solved as part of a
complete solution to the problem.


------------------------------------------------------------
---------
To unsubscribe, e-mail: issues-unsubscribesubversion.tigris.org
For additional commands, e-mail: issues-helpsubversion.tigris.org