List Info

Thread: patch: C::P::Compress::Deflate




patch: C::P::Compress::Deflate
user name
2006-09-19 15:32:41
> +    # skip if we have a particular browser type
> +    if (    $c->request->browser
> +        and $c->request->browser->windows
> +        and $c->request->browser->ie
> +        and $c->request->browser->major()
<
> +        ( $c->config->->
|| 0 ) )

Unless I'm missing something, these are going to blow up
(throw an
exception) if you don't have C::P::Browser.  I think you
should try
calling can first:

if ($c->request->can('browser')->() &&
...

Regards,
Jonathan Rockway

_______________________________________________
Catalyst-dev mailing list
Catalyst-devlists.rawmode.org
http://lists.rawmode.org/mailman/listinfo/catalyst-dev

[1]

about | contact  Other archives ( Real Estate discussion Medical topics )